[v2,0/2] Misc fixes on vfio display

Message

Duan, Zhenzhong July 1, 2024, 1:48 a.m. UTC

Hi,

This is trying to address an issue Cédric found.
See https://www.mail-archive.com/[e-mail]/msg1043142.html
While looking into it, also found a potential memory leak.

I'm sorry that I didn't find how to test this fix, because it looks
a GFX card is needed. Any idea on how to test or help test are quite
appreciated.

Thanks
Zhenzhong

v2:
- set dpy->edid_info to NULL in vfio_display_edid_init() err path (Marc-André)
- remove a wrongly added g_free(*info) in vfio_get_dev_region_info() (Marc-André)
- add R-B on patch2


Zhenzhong Duan (2):
  vfio/display: Fix potential memleak of edid info
  vfio/display: Fix vfio_display_edid_init() error path

 hw/vfio/display.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

Comments

Cédric Le Goater July 2, 2024, 4:05 p.m. UTC | #1

On 7/1/24 3:48 AM, Zhenzhong Duan wrote:
> Hi,
> 
> This is trying to address an issue Cédric found.
> See https://www.mail-archive.com/[e-mail]/msg1043142.html
> While looking into it, also found a potential memory leak.
> 
> I'm sorry that I didn't find how to test this fix, because it looks
> a GFX card is needed. Any idea on how to test or help test are quite
> appreciated.
> 
> Thanks
> Zhenzhong
> 
> v2:
> - set dpy->edid_info to NULL in vfio_display_edid_init() err path (Marc-André)
> - remove a wrongly added g_free(*info) in vfio_get_dev_region_info() (Marc-André)
> - add R-B on patch2
> 
> 
> Zhenzhong Duan (2):
>    vfio/display: Fix potential memleak of edid info
>    vfio/display: Fix vfio_display_edid_init() error path
> 
>   hw/vfio/display.c | 16 ++++++++++------
>   1 file changed, 10 insertions(+), 6 deletions(-)
> 


Applied to vfio-next.

Thanks,

C.