[11/20] iio: accel: sca3300: make use of iio_for_each_active_channel()

Commit Message

Nuno Sa via B4 Relay July 2, 2024, 4:02 p.m. UTC

From: Nuno Sa <[e-mail]>

Use iio_for_each_active_channel() to iterate over active channels
accessing '.masklength' so it can be annotated as __private when there are
no more direct users of it.

Signed-off-by: Nuno Sa <[e-mail]>
---
 drivers/iio/accel/sca3300.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Alexandru Ardelean July 3, 2024, 6:26 a.m. UTC | #1

On Tue, Jul 2, 2024 at 7:03 PM Nuno Sa via B4 Relay
<[e-mail]> wrote:
>
> From: Nuno Sa <[e-mail]>
>
> Use iio_for_each_active_channel() to iterate over active channels
> accessing '.masklength' so it can be annotated as __private when there are
> no more direct users of it.
>

Reviewed-by: Alexandru Ardelean <[e-mail]>

> Signed-off-by: Nuno Sa <[e-mail]>
> ---
>  drivers/iio/accel/sca3300.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iio/accel/sca3300.c b/drivers/iio/accel/sca3300.c
> index 306482b70fad..fca77d660625 100644
> --- a/drivers/iio/accel/sca3300.c
> +++ b/drivers/iio/accel/sca3300.c
> @@ -494,8 +494,7 @@ static irqreturn_t sca3300_trigger_handler(int irq, void *p)
>         int bit, ret, val, i = 0;
>         s16 *channels = (s16 *)data->buffer;
>
> -       for_each_set_bit(bit, indio_dev->active_scan_mask,
> -                        indio_dev->masklength) {
> +       iio_for_each_active_channel(indio_dev, bit) {
>                 ret = sca3300_read_reg(data, indio_dev->channels[bit].address, &val);
>                 if (ret) {
>                         dev_err_ratelimited(&data->spi->dev,
>
> --
> 2.45.2
>
>
>

Patch

diff --git a/drivers/iio/accel/sca3300.c b/drivers/iio/accel/sca3300.c
index 306482b70fad..fca77d660625 100644
--- a/drivers/iio/accel/sca3300.c
+++ b/drivers/iio/accel/sca3300.c
@@ -494,8 +494,7 @@  static irqreturn_t sca3300_trigger_handler(int irq, void *p)
 	int bit, ret, val, i = 0;
 	s16 *channels = (s16 *)data->buffer;
 
-	for_each_set_bit(bit, indio_dev->active_scan_mask,
-			 indio_dev->masklength) {
+	iio_for_each_active_channel(indio_dev, bit) {
 		ret = sca3300_read_reg(data, indio_dev->channels[bit].address, &val);
 		if (ret) {
 			dev_err_ratelimited(&data->spi->dev,