mbox series

[0/2] ASoC: cs35l56: Set correct upper volume limit

Message ID 20240703095517.208077-1-rf@opensource.cirrus.com (mailing list archive)
Headers show
Series ASoC: cs35l56: Set correct upper volume limit | expand

Message

Richard Fitzgerald July 3, 2024, 9:55 a.m. UTC
These two commits set the upper limit of the Speaker Volume control
to +12dB instead of +100dB.

This should have been a simple 1-line change to the #define in the
header file, but only the HDA cs35l56 driver is using this define.
The ASoC cs35l56 driver was using hardcoded numbers instead of the
header defines.

So the first commit changes the ASoC driver to use the #defined
constants. The second commit corrects the value of the constant.

Richard Fitzgerald (2):
  ASoC: cs35l56: Use header defines for Speaker Volume control
    definition
  ASoC: cs35l56: Limit Speaker Volume to +12dB maximum

 include/sound/cs35l56.h    | 2 +-
 sound/soc/codecs/cs35l56.c | 6 +++++-
 2 files changed, 6 insertions(+), 2 deletions(-)

Comments

Mark Brown July 3, 2024, 5:21 p.m. UTC | #1
On Wed, 03 Jul 2024 10:55:15 +0100, Richard Fitzgerald wrote:
> These two commits set the upper limit of the Speaker Volume control
> to +12dB instead of +100dB.
> 
> This should have been a simple 1-line change to the #define in the
> header file, but only the HDA cs35l56 driver is using this define.
> The ASoC cs35l56 driver was using hardcoded numbers instead of the
> header defines.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: cs35l56: Use header defines for Speaker Volume control definition
      commit: c66995ae403073212f5ba60d2079003866c6e130
[2/2] ASoC: cs35l56: Limit Speaker Volume to +12dB maximum
      commit: 244389bd42870640c4b5ef672a360da329b579ed

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark