[v2,0/4] Add clock provider support to Rockchip RK3588 HDMI TX PHY

Message

Cristian Ciocaltea June 20, 2024, 12:36 a.m. UTC

The HDMI PHY PLL can be used as an alternative clock source to RK3588
SoC CRU. Since it provides more accurate clock rates, it can be used by
VOP2 to improve display modes handling, such as supporting non-integer
refresh rates.

The first two patches in the series provide a couple of fixes and
improvements to the existing HDPTX PHY driver, while the next two add
the necessary changes to support the clock provider functionality.

To: Vinod Koul <[e-mail]>
To: Kishon Vijay Abraham I <[e-mail]>
To: Heiko Stuebner <[e-mail]>
To: Algea Cao <[e-mail]>
To: Rob Herring <[e-mail]>
To: Krzysztof Kozlowski <[e-mail]>
To: Conor Dooley <[e-mail]>
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Signed-off-by: Cristian Ciocaltea <[e-mail]>

--- Changes in v2:
- Collected Reviewed-by tag from Heiko on PATCH 1 & 2, and Acked-by from
  Krzysztof on PATCH 3
- Updated PATCH 4 to make use of a forced consumer put in
  rk_hdptx_phy_power_on() and rk_hdptx_phy_clk_unprepare()
- Link to v1: https://lore.kernel.org/r/[e-mail]

---
Cristian Ciocaltea (4):
      phy: phy-rockchip-samsung-hdptx: Explicitly include pm_runtime.h
      phy: phy-rockchip-samsung-hdptx: Enable runtime PM at PHY core level
      dt-bindings: phy: rockchip,rk3588-hdptx-phy: Add #clock-cells
      phy: phy-rockchip-samsung-hdptx: Add clock provider support

 .../bindings/phy/rockchip,rk3588-hdptx-phy.yaml    |   3 +
 drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c  | 206 +++++++++++++++++----
 2 files changed, 176 insertions(+), 33 deletions(-)
---
base-commit: 6906a84c482f098d31486df8dc98cead21cce2d0
change-id: 20240617-rk3588-hdmiphy-clkprov-f05f165ac029

Comments

Cristian Ciocaltea July 4, 2024, 8:29 a.m. UTC | #1

Hi Vinod,

Please let me know if there are any additional items required for this
series to be picked up.

Thanks,
Cristian

On 6/20/24 3:36 AM, Cristian Ciocaltea wrote:
> The HDMI PHY PLL can be used as an alternative clock source to RK3588
> SoC CRU. Since it provides more accurate clock rates, it can be used by
> VOP2 to improve display modes handling, such as supporting non-integer
> refresh rates.
> 
> The first two patches in the series provide a couple of fixes and
> improvements to the existing HDPTX PHY driver, while the next two add
> the necessary changes to support the clock provider functionality.
> 
> To: Vinod Koul <[e-mail]>
> To: Kishon Vijay Abraham I <[e-mail]>
> To: Heiko Stuebner <[e-mail]>
> To: Algea Cao <[e-mail]>
> To: Rob Herring <[e-mail]>
> To: Krzysztof Kozlowski <[e-mail]>
> To: Conor Dooley <[e-mail]>
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> Signed-off-by: Cristian Ciocaltea <[e-mail]>
> 
> --- Changes in v2:
> - Collected Reviewed-by tag from Heiko on PATCH 1 & 2, and Acked-by from
>   Krzysztof on PATCH 3
> - Updated PATCH 4 to make use of a forced consumer put in
>   rk_hdptx_phy_power_on() and rk_hdptx_phy_clk_unprepare()
> - Link to v1: https://lore.kernel.org/r/[e-mail]
> 
> ---
> Cristian Ciocaltea (4):
>       phy: phy-rockchip-samsung-hdptx: Explicitly include pm_runtime.h
>       phy: phy-rockchip-samsung-hdptx: Enable runtime PM at PHY core level
>       dt-bindings: phy: rockchip,rk3588-hdptx-phy: Add #clock-cells
>       phy: phy-rockchip-samsung-hdptx: Add clock provider support
> 
>  .../bindings/phy/rockchip,rk3588-hdptx-phy.yaml    |   3 +
>  drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c  | 206 +++++++++++++++++----
>  2 files changed, 176 insertions(+), 33 deletions(-)
> ---
> base-commit: 6906a84c482f098d31486df8dc98cead21cce2d0
> change-id: 20240617-rk3588-hdmiphy-clkprov-f05f165ac029
> 
> _______________________________________________
> Kernel mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> This list is managed by https://mailman.collabora.com

Vinod Koul Aug. 5, 2024, 4:25 p.m. UTC | #2

On Thu, 20 Jun 2024 03:36:21 +0300, Cristian Ciocaltea wrote:
> The HDMI PHY PLL can be used as an alternative clock source to RK3588
> SoC CRU. Since it provides more accurate clock rates, it can be used by
> VOP2 to improve display modes handling, such as supporting non-integer
> refresh rates.
> 
> The first two patches in the series provide a couple of fixes and
> improvements to the existing HDPTX PHY driver, while the next two add
> the necessary changes to support the clock provider functionality.
> 
> [...]

Applied, thanks!

[1/4] phy: phy-rockchip-samsung-hdptx: Explicitly include pm_runtime.h
      commit: 1b369ff94bc36d2e16c8a91c0ea8ebd329555976
[2/4] phy: phy-rockchip-samsung-hdptx: Enable runtime PM at PHY core level
      commit: 10ba8479f460e9256f7d884dc1b7d89006a89c7b
[3/4] dt-bindings: phy: rockchip,rk3588-hdptx-phy: Add #clock-cells
      commit: a652f2210054276990d45626a3b9ad5c99465f5a
[4/4] phy: phy-rockchip-samsung-hdptx: Add clock provider support
      commit: c4b09c562086f32588d962d30d0b7e93fe3e7cbb

Best regards,