| Message ID | 20240704084759.1824420-5-zhao1.liu@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | trivial: Fix superfluous trailing semicolon | expand |
On Thu, 4 Jul 2024 at 09:33, Zhao Liu <zhao1.liu@intel.com> wrote: > > Fix the superfluous trailing semicolon in target/hexagon/imported/mmvec/ > ext.idef. > > Cc: Brian Cain <bcain@quicinc.com> > Signed-off-by: Zhao Liu <zhao1.liu@intel.com> > --- > target/hexagon/imported/mmvec/ext.idef | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/hexagon/imported/mmvec/ext.idef b/target/hexagon/imported/mmvec/ext.idef > index 98daabfb07c4..03d31f6181d7 100644 > --- a/target/hexagon/imported/mmvec/ext.idef > +++ b/target/hexagon/imported/mmvec/ext.idef > @@ -2855,7 +2855,7 @@ EXTINSN(V6_vscattermhw_add, "vscatter(Rt32,Mu2,Vvv32.w).h+=Vw32", ATTRIBS(A_EXT > fVALIGN(RtV, element_size); > fVFOREACH(32, i) { > for(j = 0; j < 2; j++) { > - EA = RtV + fVALIGN(VvvV.v[j].uw[i],ALIGNMENT);; > + EA = RtV + fVALIGN(VvvV.v[j].uw[i],ALIGNMENT); > fVLOG_VTCM_HALFWORD_INCREMENT_DV(EA,VvvV.v[j].uw[i],VwV,(2*i+j),i,j,ALIGNMENT,MuV); > } > } > -- > 2.34.1 As a change this is obviously fine, but given the "imported" in the pathname I don't know if this is something that should be fixed in whatever upstream source we got this from instead or as well. Brian ? thanks -- PMM
Zhao Liu <zhao1.liu@intel.com> writes: > Fix the superfluous trailing semicolon in target/hexagon/imported/mmvec/ > ext.idef. > > Cc: Brian Cain <bcain@quicinc.com> > Signed-off-by: Zhao Liu <zhao1.liu@intel.com> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
On 7/4/2024 3:47 AM, Zhao Liu wrote: > Fix the superfluous trailing semicolon in target/hexagon/imported/mmvec/ > ext.idef. > > Cc: Brian Cain <bcain@quicinc.com> > Signed-off-by: Zhao Liu <zhao1.liu@intel.com> Reviewed-by: Brian Cain <bcain@quicinc.com> > --- > target/hexagon/imported/mmvec/ext.idef | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/hexagon/imported/mmvec/ext.idef b/target/hexagon/imported/mmvec/ext.idef > index 98daabfb07c4..03d31f6181d7 100644 > --- a/target/hexagon/imported/mmvec/ext.idef > +++ b/target/hexagon/imported/mmvec/ext.idef > @@ -2855,7 +2855,7 @@ EXTINSN(V6_vscattermhw_add, "vscatter(Rt32,Mu2,Vvv32.w).h+=Vw32", ATTRIBS(A_EXT > fVALIGN(RtV, element_size); > fVFOREACH(32, i) { > for(j = 0; j < 2; j++) { > - EA = RtV + fVALIGN(VvvV.v[j].uw[i],ALIGNMENT);; > + EA = RtV + fVALIGN(VvvV.v[j].uw[i],ALIGNMENT); > fVLOG_VTCM_HALFWORD_INCREMENT_DV(EA,VvvV.v[j].uw[i],VwV,(2*i+j),i,j,ALIGNMENT,MuV); > } > }
06.07.2024 00:50, Brian Cain wrote: > > On 7/4/2024 3:47 AM, Zhao Liu wrote: >> Fix the superfluous trailing semicolon in target/hexagon/imported/mmvec/ >> ext.idef. >> >> Cc: Brian Cain <bcain@quicinc.com> >> Signed-off-by: Zhao Liu <zhao1.liu@intel.com> > > Reviewed-by: Brian Cain <bcain@quicinc.com> Brian, is it okay to fix this in something "imported" ? I realize you added your R-b, but do you realize it's "imported"? Thanks, /mjt >> --- >> target/hexagon/imported/mmvec/ext.idef | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/target/hexagon/imported/mmvec/ext.idef b/target/hexagon/imported/mmvec/ext.idef >> index 98daabfb07c4..03d31f6181d7 100644 >> --- a/target/hexagon/imported/mmvec/ext.idef >> +++ b/target/hexagon/imported/mmvec/ext.idef >> @@ -2855,7 +2855,7 @@ EXTINSN(V6_vscattermhw_add, "vscatter(Rt32,Mu2,Vvv32.w).h+=Vw32", ATTRIBS(A_EXT >> fVALIGN(RtV, element_size); >> fVFOREACH(32, i) { >> for(j = 0; j < 2; j++) { >> - EA = RtV + fVALIGN(VvvV.v[j].uw[i],ALIGNMENT);; >> + EA = RtV + fVALIGN(VvvV.v[j].uw[i],ALIGNMENT); >> fVLOG_VTCM_HALFWORD_INCREMENT_DV(EA,VvvV.v[j].uw[i],VwV,(2*i+j),i,j,ALIGNMENT,MuV); >> } >> } >
On 7/15/2024 4:59 AM, Michael Tokarev wrote: > 06.07.2024 00:50, Brian Cain wrote: >> >> On 7/4/2024 3:47 AM, Zhao Liu wrote: >>> Fix the superfluous trailing semicolon in >>> target/hexagon/imported/mmvec/ >>> ext.idef. >>> >>> Cc: Brian Cain <bcain@quicinc.com> >>> Signed-off-by: Zhao Liu <zhao1.liu@intel.com> >> >> Reviewed-by: Brian Cain <bcain@quicinc.com> > > Brian, is it okay to fix this in something "imported" ? > I realize you added your R-b, but do you realize it's "imported"? > Sure, it's fine - I'll just have to take extra care not to re-introduce issues like these when making updates. I can try and work with the original sources to make sure it's addressed there. > Thanks, > > /mjt > >>> --- >>> target/hexagon/imported/mmvec/ext.idef | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/target/hexagon/imported/mmvec/ext.idef >>> b/target/hexagon/imported/mmvec/ext.idef >>> index 98daabfb07c4..03d31f6181d7 100644 >>> --- a/target/hexagon/imported/mmvec/ext.idef >>> +++ b/target/hexagon/imported/mmvec/ext.idef >>> @@ -2855,7 +2855,7 @@ EXTINSN(V6_vscattermhw_add, >>> "vscatter(Rt32,Mu2,Vvv32.w).h+=Vw32", ATTRIBS(A_EXT >>> fVALIGN(RtV, element_size); >>> fVFOREACH(32, i) { >>> for(j = 0; j < 2; j++) { >>> - EA = RtV + fVALIGN(VvvV.v[j].uw[i],ALIGNMENT);; >>> + EA = RtV + fVALIGN(VvvV.v[j].uw[i],ALIGNMENT); >>> fVLOG_VTCM_HALFWORD_INCREMENT_DV(EA,VvvV.v[j].uw[i],VwV,(2*i+j),i,j,ALIGNMENT,MuV); >>> } >>> } >> >
diff --git a/target/hexagon/imported/mmvec/ext.idef b/target/hexagon/imported/mmvec/ext.idef index 98daabfb07c4..03d31f6181d7 100644 --- a/target/hexagon/imported/mmvec/ext.idef +++ b/target/hexagon/imported/mmvec/ext.idef @@ -2855,7 +2855,7 @@ EXTINSN(V6_vscattermhw_add, "vscatter(Rt32,Mu2,Vvv32.w).h+=Vw32", ATTRIBS(A_EXT fVALIGN(RtV, element_size); fVFOREACH(32, i) { for(j = 0; j < 2; j++) { - EA = RtV + fVALIGN(VvvV.v[j].uw[i],ALIGNMENT);; + EA = RtV + fVALIGN(VvvV.v[j].uw[i],ALIGNMENT); fVLOG_VTCM_HALFWORD_INCREMENT_DV(EA,VvvV.v[j].uw[i],VwV,(2*i+j),i,j,ALIGNMENT,MuV); } }
Fix the superfluous trailing semicolon in target/hexagon/imported/mmvec/ ext.idef. Cc: Brian Cain <bcain@quicinc.com> Signed-off-by: Zhao Liu <zhao1.liu@intel.com> --- target/hexagon/imported/mmvec/ext.idef | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)