diff mbox series

[v2,3/3] dt-bindings: display: panel: correct Anbernic RG35XX panel example

Message ID 20240703103710.31169-4-ryan@testtoast.com (mailing list archive)
State New, archived
Headers show
Series Correct WL-355608-A8 panel compatible | expand

Commit Message

Ryan Walklin July 3, 2024, 10:31 a.m. UTC
make dt_bindings_check reports that sck-gpios and num-chipselects are
required for spi nodes, therefore add these to the example.

Signed-off-by: Ryan Walklin <ryan@testtoast.com>
---
 .../bindings/display/panel/anbernic,wl-355608-a8.yaml          | 3 +++
 1 file changed, 3 insertions(+)

Comments

Conor Dooley July 3, 2024, 3:38 p.m. UTC | #1
On Wed, Jul 03, 2024 at 10:31:46PM +1200, Ryan Walklin wrote:
> make dt_bindings_check reports that sck-gpios and num-chipselects are
> required for spi nodes, therefore add these to the example.
> 
> Signed-off-by: Ryan Walklin <ryan@testtoast.com>

I forgot to reply to, or somehow didn't notice your reply to my comments
on this patch. I would just drop this change as I think it's a tooling
issue. I checked the version of dt-schema etc that I have here locally
and there were no complaints with the binding prior to your patches.

Sorry for missing your reply,
Conor.

> ---
>  .../bindings/display/panel/anbernic,wl-355608-a8.yaml          | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/anbernic,wl-355608-a8.yaml b/Documentation/devicetree/bindings/display/panel/anbernic,wl-355608-a8.yaml
> index dde3600f0189c..bbe016453c9b2 100644
> --- a/Documentation/devicetree/bindings/display/panel/anbernic,wl-355608-a8.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/anbernic,wl-355608-a8.yaml
> @@ -40,6 +40,9 @@ examples:
>          #address-cells = <1>;
>          #size-cells = <0>;
>  
> +        sck-gpios = <&pio 8 9 GPIO_ACTIVE_HIGH>; // PI9
> +        num-chipselects = <1>;
> +
>          panel@0 {
>              compatible = "anbernic,wl-355608-a8";
>              reg = <0>;
> -- 
> 2.45.2
>
Ryan Walklin July 5, 2024, 8:41 a.m. UTC | #2
On Thu, 4 Jul 2024, at 3:38 AM, Conor Dooley wrote:
> I forgot to reply to, or somehow didn't notice your reply to my comments
> on this patch. I would just drop this change as I think it's a tooling
> issue. I checked the version of dt-schema etc that I have here locally
> and there were no complaints with the binding prior to your patches.
>
> Sorry for missing your reply,
> Conor.
>
Thanks Conor, no worries. Happy to resend without this patch in that case, or just have it dropped.

Regards,

Ryan
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/anbernic,wl-355608-a8.yaml b/Documentation/devicetree/bindings/display/panel/anbernic,wl-355608-a8.yaml
index dde3600f0189c..bbe016453c9b2 100644
--- a/Documentation/devicetree/bindings/display/panel/anbernic,wl-355608-a8.yaml
+++ b/Documentation/devicetree/bindings/display/panel/anbernic,wl-355608-a8.yaml
@@ -40,6 +40,9 @@  examples:
         #address-cells = <1>;
         #size-cells = <0>;
 
+        sck-gpios = <&pio 8 9 GPIO_ACTIVE_HIGH>; // PI9
+        num-chipselects = <1>;
+
         panel@0 {
             compatible = "anbernic,wl-355608-a8";
             reg = <0>;