| Message ID | 20240705100356.16760-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | MAINTAINERS: drm/sti: mark it as Odd Fixes | expand |
On Fri, Jul 05, 2024 at 12:03:56PM +0200, Krzysztof Kozlowski wrote: > Patches to STI DRM are not being picked up, so even though there is > maintainer activity, it seems that these drivers are not being actively > looked at. Reflect this in maintainer status. Note that since the driver is in drm-misc, other committers can also pick up patches and push them. Both Neil and Dimtry have commit rights and should be able to pick up your patches for you, if they get stuck. -Sima > > Link: https://lore.kernel.org/all/77b4e4ad-2b1e-4b6d-bc3b-0c7b339bc295@linaro.org/ > Link: https://lore.kernel.org/all/f207b481-f530-4f54-a482-218908869050@linaro.org/ > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Cc: Neil Armstrong <neil.armstrong@linaro.org> > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index c8e16a649a0e..f284cb8db544 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -7595,7 +7595,7 @@ F: drivers/gpu/drm/rockchip/ > DRM DRIVERS FOR STI > M: Alain Volmat <alain.volmat@foss.st.com> > L: dri-devel@lists.freedesktop.org > -S: Maintained > +S: Odd Fixes > T: git https://gitlab.freedesktop.org/drm/misc/kernel.git > F: Documentation/devicetree/bindings/display/st,stih4xx.txt > F: drivers/gpu/drm/sti > -- > 2.43.0 >
On Fri, Jul 05, 2024 at 01:19:50PM GMT, Daniel Vetter wrote: > On Fri, Jul 05, 2024 at 12:03:56PM +0200, Krzysztof Kozlowski wrote: > > Patches to STI DRM are not being picked up, so even though there is > > maintainer activity, it seems that these drivers are not being actively > > looked at. Reflect this in maintainer status. > > Note that since the driver is in drm-misc, other committers can also pick > up patches and push them. Both Neil and Dimtry have commit rights and > should be able to pick up your patches for you, if they get stuck. I've applied the patches. I don't think we should merge this one though, a one-off mishap can happen. Maxime
On 05/07/2024 13:22, Maxime Ripard wrote: > On Fri, Jul 05, 2024 at 01:19:50PM GMT, Daniel Vetter wrote: >> On Fri, Jul 05, 2024 at 12:03:56PM +0200, Krzysztof Kozlowski wrote: >>> Patches to STI DRM are not being picked up, so even though there is >>> maintainer activity, it seems that these drivers are not being actively >>> looked at. Reflect this in maintainer status. >> >> Note that since the driver is in drm-misc, other committers can also pick >> up patches and push them. Both Neil and Dimtry have commit rights and >> should be able to pick up your patches for you, if they get stuck. > > I've applied the patches. > > I don't think we should merge this one though, a one-off mishap can happen. Sure. Folks, maybe then pattern in maintainers should be somehow changed or grew? The recommendation to all submitters is to use get_maintainers.pl. b4 also does it. In this particular case, using get_maintainers.pl or b4 will result in patches not being picked up. Best regards, Krzysztof
On Fri, Jul 05, 2024 at 01:33:38PM +0200, Krzysztof Kozlowski wrote: > On 05/07/2024 13:22, Maxime Ripard wrote: > > On Fri, Jul 05, 2024 at 01:19:50PM GMT, Daniel Vetter wrote: > >> On Fri, Jul 05, 2024 at 12:03:56PM +0200, Krzysztof Kozlowski wrote: > >>> Patches to STI DRM are not being picked up, so even though there is > >>> maintainer activity, it seems that these drivers are not being actively > >>> looked at. Reflect this in maintainer status. > >> > >> Note that since the driver is in drm-misc, other committers can also pick > >> up patches and push them. Both Neil and Dimtry have commit rights and > >> should be able to pick up your patches for you, if they get stuck. > > > > I've applied the patches. > > > > I don't think we should merge this one though, a one-off mishap can happen. > > Sure. > > Folks, maybe then pattern in maintainers should be somehow changed or grew? > > The recommendation to all submitters is to use get_maintainers.pl. b4 > also does it. In this particular case, using get_maintainers.pl or b4 > will result in patches not being picked up. I think get_maintainers.pl is correct: You get the driver maintainer, plus drm-misc maintainers as official fallback, plus Dave&me as fallback of last resorts. So all correct. What's special with the commit rights model is that other committers that work all over the subsystem can also pick up the patches for you, so that the drm-misc mainters don't become a bottleneck. But the ideal person there are drm-misc committers who work in your team or company, or someone else where you have some goodwill credits to spend with and ask them for a favour. And there's just no way to model that and make sure the script gives you the right suggestions. -Sima
Hi Krzysztof, Daniel, and Maxime, On Fri, Jul 05, 2024 at 03:41:26PM +0200, Daniel Vetter wrote: > On Fri, Jul 05, 2024 at 01:33:38PM +0200, Krzysztof Kozlowski wrote: > > On 05/07/2024 13:22, Maxime Ripard wrote: > > > On Fri, Jul 05, 2024 at 01:19:50PM GMT, Daniel Vetter wrote: > > >> On Fri, Jul 05, 2024 at 12:03:56PM +0200, Krzysztof Kozlowski wrote: > > >>> Patches to STI DRM are not being picked up, so even though there is > > >>> maintainer activity, it seems that these drivers are not being actively > > >>> looked at. Reflect this in maintainer status. > > >> > > >> Note that since the driver is in drm-misc, other committers can also pick > > >> up patches and push them. Both Neil and Dimtry have commit rights and > > >> should be able to pick up your patches for you, if they get stuck. > > > > > > I've applied the patches. > > > > > > I don't think we should merge this one though, a one-off mishap can happen. > > > > Sure. > > > > Folks, maybe then pattern in maintainers should be somehow changed or grew? > > > > The recommendation to all submitters is to use get_maintainers.pl. b4 > > also does it. In this particular case, using get_maintainers.pl or b4 > > will result in patches not being picked up. > > I think get_maintainers.pl is correct: You get the driver maintainer, plus > drm-misc maintainers as official fallback, plus Dave&me as fallback of > last resorts. So all correct. > > What's special with the commit rights model is that other committers that > work all over the subsystem can also pick up the patches for you, so that > the drm-misc mainters don't become a bottleneck. But the ideal person > there are drm-misc committers who work in your team or company, or someone > else where you have some goodwill credits to spend with and ask them for a > favour. And there's just no way to model that and make sure the script > gives you the right suggestions. Many thanks for all your emails and your support. In the past, I've never committed patches to drm-misc myself and, to be honest, missed the point that as a drm driver maintainer, I should also do so. Thanks to recent discussions, I now fully understand how it should be done. That said, since the volume of drm/sti patches is rather small, I will from now on request help for commit from drm/stm (Philippe, Yannick, and Raphael) and drm-misc maintainers in a more "pro-active" way :-) Sorry for the inconvenience, and once again, many thanks for your support. Alain > -Sima > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch
On Fri, Jul 05, 2024 at 05:14:36PM GMT, Alain Volmat wrote: > Hi Krzysztof, Daniel, and Maxime, > > On Fri, Jul 05, 2024 at 03:41:26PM +0200, Daniel Vetter wrote: > > On Fri, Jul 05, 2024 at 01:33:38PM +0200, Krzysztof Kozlowski wrote: > > > On 05/07/2024 13:22, Maxime Ripard wrote: > > > > On Fri, Jul 05, 2024 at 01:19:50PM GMT, Daniel Vetter wrote: > > > >> On Fri, Jul 05, 2024 at 12:03:56PM +0200, Krzysztof Kozlowski wrote: > > > >>> Patches to STI DRM are not being picked up, so even though there is > > > >>> maintainer activity, it seems that these drivers are not being actively > > > >>> looked at. Reflect this in maintainer status. > > > >> > > > >> Note that since the driver is in drm-misc, other committers can also pick > > > >> up patches and push them. Both Neil and Dimtry have commit rights and > > > >> should be able to pick up your patches for you, if they get stuck. > > > > > > > > I've applied the patches. > > > > > > > > I don't think we should merge this one though, a one-off mishap can happen. > > > > > > Sure. > > > > > > Folks, maybe then pattern in maintainers should be somehow changed or grew? > > > > > > The recommendation to all submitters is to use get_maintainers.pl. b4 > > > also does it. In this particular case, using get_maintainers.pl or b4 > > > will result in patches not being picked up. > > > > I think get_maintainers.pl is correct: You get the driver maintainer, plus > > drm-misc maintainers as official fallback, plus Dave&me as fallback of > > last resorts. So all correct. > > > > What's special with the commit rights model is that other committers that > > work all over the subsystem can also pick up the patches for you, so that > > the drm-misc mainters don't become a bottleneck. But the ideal person > > there are drm-misc committers who work in your team or company, or someone > > else where you have some goodwill credits to spend with and ask them for a > > favour. And there's just no way to model that and make sure the script > > gives you the right suggestions. > > Many thanks for all your emails and your support. > > In the past, I've never committed patches to drm-misc myself and, to be honest, > missed the point that as a drm driver maintainer, I should also do so. Are you saying you don't have a drm-misc account, or that you don't want to participate? > Thanks to recent discussions, I now fully understand how it should be done. > > That said, since the volume of drm/sti patches is rather small, I will > from now on request help for commit from drm/stm (Philippe, Yannick, > and Raphael) and drm-misc maintainers in a more "pro-active" way :-) > > Sorry for the inconvenience, and once again, many thanks for your > support. Sorry, but the expectation is very much that you merge at least some of the patches for the driver you maintain, and not just rely on someone eventually picking it up. Maxime
Hi Maxime, On Mon, Jul 08, 2024 at 04:57:49PM +0200, Maxime Ripard wrote: > On Fri, Jul 05, 2024 at 05:14:36PM GMT, Alain Volmat wrote: > > Hi Krzysztof, Daniel, and Maxime, > > > > On Fri, Jul 05, 2024 at 03:41:26PM +0200, Daniel Vetter wrote: > > > On Fri, Jul 05, 2024 at 01:33:38PM +0200, Krzysztof Kozlowski wrote: > > > > On 05/07/2024 13:22, Maxime Ripard wrote: > > > > > On Fri, Jul 05, 2024 at 01:19:50PM GMT, Daniel Vetter wrote: > > > > >> On Fri, Jul 05, 2024 at 12:03:56PM +0200, Krzysztof Kozlowski wrote: > > > > >>> Patches to STI DRM are not being picked up, so even though there is > > > > >>> maintainer activity, it seems that these drivers are not being actively > > > > >>> looked at. Reflect this in maintainer status. > > > > >> > > > > >> Note that since the driver is in drm-misc, other committers can also pick > > > > >> up patches and push them. Both Neil and Dimtry have commit rights and > > > > >> should be able to pick up your patches for you, if they get stuck. > > > > > > > > > > I've applied the patches. > > > > > > > > > > I don't think we should merge this one though, a one-off mishap can happen. > > > > > > > > Sure. > > > > > > > > Folks, maybe then pattern in maintainers should be somehow changed or grew? > > > > > > > > The recommendation to all submitters is to use get_maintainers.pl. b4 > > > > also does it. In this particular case, using get_maintainers.pl or b4 > > > > will result in patches not being picked up. > > > > > > I think get_maintainers.pl is correct: You get the driver maintainer, plus > > > drm-misc maintainers as official fallback, plus Dave&me as fallback of > > > last resorts. So all correct. > > > > > > What's special with the commit rights model is that other committers that > > > work all over the subsystem can also pick up the patches for you, so that > > > the drm-misc mainters don't become a bottleneck. But the ideal person > > > there are drm-misc committers who work in your team or company, or someone > > > else where you have some goodwill credits to spend with and ask them for a > > > favour. And there's just no way to model that and make sure the script > > > gives you the right suggestions. > > > > Many thanks for all your emails and your support. > > > > In the past, I've never committed patches to drm-misc myself and, to be honest, > > missed the point that as a drm driver maintainer, I should also do so. > > Are you saying you don't have a drm-misc account, or that you don't want > to participate? I don't have (yet) a drm-misc account. But following recents email exchanges, expectations are now clear so I will request an account in order to merge as well patches of drm/sti. Thanks a lot Maxime for all the explanations. Alain > > > Thanks to recent discussions, I now fully understand how it should be done. > > > > That said, since the volume of drm/sti patches is rather small, I will > > from now on request help for commit from drm/stm (Philippe, Yannick, > > and Raphael) and drm-misc maintainers in a more "pro-active" way :-) > > > > Sorry for the inconvenience, and once again, many thanks for your > > support. > > Sorry, but the expectation is very much that you merge at least some of > the patches for the driver you maintain, and not just rely on someone > eventually picking it up. > > Maxime
diff --git a/MAINTAINERS b/MAINTAINERS index c8e16a649a0e..f284cb8db544 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7595,7 +7595,7 @@ F: drivers/gpu/drm/rockchip/ DRM DRIVERS FOR STI M: Alain Volmat <alain.volmat@foss.st.com> L: dri-devel@lists.freedesktop.org -S: Maintained +S: Odd Fixes T: git https://gitlab.freedesktop.org/drm/misc/kernel.git F: Documentation/devicetree/bindings/display/st,stih4xx.txt F: drivers/gpu/drm/sti
Patches to STI DRM are not being picked up, so even though there is maintainer activity, it seems that these drivers are not being actively looked at. Reflect this in maintainer status. Link: https://lore.kernel.org/all/77b4e4ad-2b1e-4b6d-bc3b-0c7b339bc295@linaro.org/ Link: https://lore.kernel.org/all/f207b481-f530-4f54-a482-218908869050@linaro.org/ Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Cc: Neil Armstrong <neil.armstrong@linaro.org> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)