diff mbox series

[BlueZ] client/player: fix incompatible pointer type

Message ID 20240707112452.3522-1-gudni.m.g@gmail.com (mailing list archive)
State Superseded
Headers show
Series [BlueZ] client/player: fix incompatible pointer type | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/CheckPatch warning WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #103: To resolve the compiler warnings, cast the pointer with (struct sockaddr *). WARNING:LONG_LINE: line length of 92 exceeds 80 columns #117: FILE: client/player.c:5150: + err = getpeername(transport->sk, (struct sockaddr *)&addr, &optlen); /github/workspace/src/src/13725999.patch total: 0 errors, 2 warnings, 8 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. /github/workspace/src/src/13725999.patch has style problems, please review. NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
tedd_an/GitLint success Gitlint PASS
tedd_an/BuildEll success Build ELL PASS
tedd_an/BluezMake success Bluez Make PASS
tedd_an/MakeCheck success Bluez Make Check PASS
tedd_an/MakeDistcheck success Make Distcheck PASS
tedd_an/CheckValgrind success Check Valgrind PASS
tedd_an/CheckSmatch success CheckSparse PASS
tedd_an/bluezmakeextell success Make External ELL PASS
tedd_an/IncrementalBuild success Incremental Build PASS
tedd_an/ScanBuild success Scan Build PASS

Commit Message

Guðni Már Gilbert July 7, 2024, 11:24 a.m. UTC 
In function 'cmd_send_transport':
error: passing argument 2 of 'getpeername' from incompatible pointer type
[-Wincompatible-pointer-types]

err = getpeername(transport->sk, &addr, &optlen);
|       |                        ^~~~~
|       |                        |
|       |                        struct sockaddr_iso *

note: expected 'struct sockaddr * restrict' but argument is of
type 'struct sockaddr_iso *'
int getpeername (int, struct sockaddr *__restrict, socklen_t *__restrict);

To resolve the compiler warnings, cast the pointer with (struct sockaddr *).
---
 client/player.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

bluez.test.bot@gmail.com July 7, 2024, 1:01 p.m. UTC | #1 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=869066

---Test result---

Test Summary:
CheckPatch                    FAIL      0.62 seconds
GitLint                       PASS      0.31 seconds
BuildEll                      PASS      26.95 seconds
BluezMake                     PASS      1665.88 seconds
MakeCheck                     PASS      13.34 seconds
MakeDistcheck                 PASS      177.89 seconds
CheckValgrind                 PASS      254.56 seconds
CheckSmatch                   PASS      355.71 seconds
bluezmakeextell               PASS      121.30 seconds
IncrementalBuild              PASS      1401.95 seconds
ScanBuild                     PASS      982.52 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[BlueZ] client/player: fix incompatible pointer type
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#103: 
To resolve the compiler warnings, cast the pointer with (struct sockaddr *).

WARNING:LONG_LINE: line length of 92 exceeds 80 columns
#117: FILE: client/player.c:5150:
+			err = getpeername(transport->sk, (struct sockaddr *)&addr, &optlen);

/github/workspace/src/src/13725999.patch total: 0 errors, 2 warnings, 8 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/src/13725999.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.




---
Regards,
Linux Bluetooth
diff mbox series

Patch

diff --git a/client/player.c b/client/player.c
index 0d031e4b0..c394c7921 100644
--- a/client/player.c
+++ b/client/player.c
@@ -5147,7 +5147,7 @@  static void cmd_send_transport(int argc, char *argv[])
 			struct sockaddr_iso addr;
 			socklen_t optlen = sizeof(addr);
 
-			err = getpeername(transport->sk, &addr, &optlen);
+			err = getpeername(transport->sk, (struct sockaddr *)&addr, &optlen);
 			if (!err) {
 				if (!(bacmp(&addr.iso_bdaddr, BDADDR_ANY)))
 					err = transport_send(transport, fd,