[BlueZ,v2,00/11] Fix a number of static analysis issues #5

Message

Bastien Nocera July 5, 2024, 8:57 a.m. UTC

Fixed review comments in:
gatt-server: Don't allocate negative data
shared/shell: Free memory allocated by wordexp()
tools/mesh: Fix integer overflow due to cast operation

Bastien Nocera (11):
  gatt-server: Don't allocate negative data
  shared/shell: Free memory allocated by wordexp()
  shared/shell: Fix fd leak if -s is passed multiple times
  btsnoop: Fix possible negative memcpy length
  sdp: Fix possible null dereference
  sdp: Fix mismatched int casting
  emulator: Fix integer truncation warnings
  gatt-server: Fix integer overflow due to cast operation
  mesh: Fix integer overflow due to cast operation
  tools/mesh: Fix integer overflow due to cast operation
  unit/ringbuf: Fix ineffective guard due to signedness

 emulator/amp.c           |  3 ++-
 emulator/bthost.c        |  8 +++++---
 lib/sdp.c                |  6 +++++-
 mesh/pb-adv.c            |  2 +-
 src/shared/gatt-server.c |  8 ++++----
 src/shared/ringbuf.c     |  2 +-
 src/shared/shell.c       | 29 ++++++++++++++++++++---------
 tools/btsnoop.c          |  4 ++--
 tools/mesh/mesh-db.c     |  9 ++++-----
 9 files changed, 44 insertions(+), 27 deletions(-)

Comments

[e-mail] July 8, 2024, 2:50 p.m. UTC | #1

Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[e-mail]>:

On Fri,  5 Jul 2024 10:57:28 +0200 you wrote:
> Fixed review comments in:
> gatt-server: Don't allocate negative data
> shared/shell: Free memory allocated by wordexp()
> tools/mesh: Fix integer overflow due to cast operation
> 
> Bastien Nocera (11):
>   gatt-server: Don't allocate negative data
>   shared/shell: Free memory allocated by wordexp()
>   shared/shell: Fix fd leak if -s is passed multiple times
>   btsnoop: Fix possible negative memcpy length
>   sdp: Fix possible null dereference
>   sdp: Fix mismatched int casting
>   emulator: Fix integer truncation warnings
>   gatt-server: Fix integer overflow due to cast operation
>   mesh: Fix integer overflow due to cast operation
>   tools/mesh: Fix integer overflow due to cast operation
>   unit/ringbuf: Fix ineffective guard due to signedness
> 
> [...]

Here is the summary with links:
  - [BlueZ,v2,01/11] gatt-server: Don't allocate negative data
    (no matching commit)
  - [BlueZ,v2,02/11] shared/shell: Free memory allocated by wordexp()
    (no matching commit)
  - [BlueZ,v2,03/11] shared/shell: Fix fd leak if -s is passed multiple times
    (no matching commit)
  - [BlueZ,v2,04/11] btsnoop: Fix possible negative memcpy length
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=8de21f74c5f3
  - [BlueZ,v2,05/11] sdp: Fix possible null dereference
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=0de4b9f71eb9
  - [BlueZ,v2,06/11] sdp: Fix mismatched int casting
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=0b52ecca60ea
  - [BlueZ,v2,07/11] emulator: Fix integer truncation warnings
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=1d73dc6a1a9a
  - [BlueZ,v2,08/11] gatt-server: Fix integer overflow due to cast operation
    (no matching commit)
  - [BlueZ,v2,09/11] mesh: Fix integer overflow due to cast operation
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=249d2120bd90
  - [BlueZ,v2,10/11] tools/mesh: Fix integer overflow due to cast operation
    (no matching commit)
  - [BlueZ,v2,11/11] unit/ringbuf: Fix ineffective guard due to signedness
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=c44a2a233d1b

You are awesome, thank you!