mbox series

[net-next,v3,0/2] net: stmmac: qcom-ethqos: enable 2.5G ethernet on sa8775p-ride

Message ID 20240703181500.28491-1-brgl@bgdev.pl (mailing list archive)
Headers show
Series net: stmmac: qcom-ethqos: enable 2.5G ethernet on sa8775p-ride | expand

Message

Bartosz Golaszewski July 3, 2024, 6:14 p.m. UTC
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Here are the changes required to enable 2.5G ethernet on sa8775p-ride.
As advised by Andrew Lunn and Russell King, I am reusing the existing
stmmac infrastructure to enable the SGMII loopback and so I dropped the
patches adding new callbacks to the driver core. I also added more
details to the commit message and made sure the workaround is only
enabled on Rev 3 of the board (with AQR115C PHY). Also: dropped any
mentions of the OCSGMII mode.

Changes since v2:
- only apply the SGMII loopback quirk on Rev 3 of the sa8775p-ride board
- extend the commit message in patch 2 to explain the situation in detail
Link to v2: https://lore.kernel.org/netdev/20240627113948.25358-1-brgl@bgdev.pl/

Changes since v1:
- split out the stmmac patches into their own series
- don't add new callbacks to the stmmac core, reuse existing
  infrastructure instead
- don't try to add a new PHY mode (OCSGMII) but reuse 2500BASEX instead
Link to v1: https://lore.kernel.org/linux-arm-kernel/20240619184550.34524-1-brgl@bgdev.pl/T/

Bartosz Golaszewski (2):
  net: stmmac: qcom-ethqos: add support for 2.5G BASEX mode
  net: stmmac: qcom-ethqos: enable SGMII loopback during DMA reset on
    sa8775p-ride-r3

 .../stmicro/stmmac/dwmac-qcom-ethqos.c        | 34 +++++++++++++++++++
 1 file changed, 34 insertions(+)

Comments

patchwork-bot+netdevbpf@kernel.org July 9, 2024, 3:40 a.m. UTC | #1
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed,  3 Jul 2024 20:14:57 +0200 you wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> Here are the changes required to enable 2.5G ethernet on sa8775p-ride.
> As advised by Andrew Lunn and Russell King, I am reusing the existing
> stmmac infrastructure to enable the SGMII loopback and so I dropped the
> patches adding new callbacks to the driver core. I also added more
> details to the commit message and made sure the workaround is only
> enabled on Rev 3 of the board (with AQR115C PHY). Also: dropped any
> mentions of the OCSGMII mode.
> 
> [...]

Here is the summary with links:
  - [net-next,v3,1/2] net: stmmac: qcom-ethqos: add support for 2.5G BASEX mode
    https://git.kernel.org/netdev/net-next/c/61e9be0efbe8
  - [net-next,v3,2/2] net: stmmac: qcom-ethqos: enable SGMII loopback during DMA reset on sa8775p-ride-r3
    https://git.kernel.org/netdev/net-next/c/3c466d6537b9

You are awesome, thank you!
Bartosz Golaszewski July 9, 2024, 8:22 a.m. UTC | #2
On Tue, Jul 9, 2024 at 5:40 AM <patchwork-bot+netdevbpf@kernel.org> wrote:
>
> Hello:
>
> This series was applied to netdev/net-next.git (main)
> by Jakub Kicinski <kuba@kernel.org>:
>
> On Wed,  3 Jul 2024 20:14:57 +0200 you wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > Here are the changes required to enable 2.5G ethernet on sa8775p-ride.
> > As advised by Andrew Lunn and Russell King, I am reusing the existing
> > stmmac infrastructure to enable the SGMII loopback and so I dropped the
> > patches adding new callbacks to the driver core. I also added more
> > details to the commit message and made sure the workaround is only
> > enabled on Rev 3 of the board (with AQR115C PHY). Also: dropped any
> > mentions of the OCSGMII mode.
> >
> > [...]
>
> Here is the summary with links:
>   - [net-next,v3,1/2] net: stmmac: qcom-ethqos: add support for 2.5G BASEX mode
>     https://git.kernel.org/netdev/net-next/c/61e9be0efbe8
>   - [net-next,v3,2/2] net: stmmac: qcom-ethqos: enable SGMII loopback during DMA reset on sa8775p-ride-r3
>     https://git.kernel.org/netdev/net-next/c/3c466d6537b9
>

Hi Jakub,

Does picking these patches up now mean they will still make the v6.11
merge window? If so: could you also consider picking up the associated
PHY changes[1] as - with the DT changes already in next - this is the
last missing bit allowing enabling the 2.5G ethernet on the
sa8775p-ride-r3 board?

Best Regards,
Bartosz

[1] https://lore.kernel.org/netdev/20240708075023.14893-1-brgl@bgdev.pl/