[mptcp-net,v2,0/4] mptcp: fix signal endpoint readd

Message

Paolo Abeni July 5, 2024, 8:33 p.m. UTC

Issues/501 showed that the NL PM currently don't add corectly removal
and re-add of signal endpoint.

Patches 1 and 2 addresses the issue, patch 3/4 introduce a related
self-test, and the last patch address a pre-existing buglet in the
self-test infra.

v1 -> v2:
 - splitted the first 2 patches
 - fixed accounting in mptcp_pm_remove_anno_addr
 - self-tests depends on subflow_rebuild_header

Paolo Abeni (4):
  mptcp: fix user-space PM announced address accounting
  mptcp: fix NL PM announced address accounting
  selftests: mptcp: add explicit test case for remove/readd
  selftests: mptcp: fix error path

 net/mptcp/pm_netlink.c                        | 27 +++++++++++-----
 .../testing/selftests/net/mptcp/mptcp_join.sh | 31 ++++++++++++++++++-
 2 files changed, 49 insertions(+), 9 deletions(-)

Comments

MPTCP CI July 5, 2024, 9:25 p.m. UTC | #1

Hi Paolo,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Unstable: 1 failed test(s): packetdrill_mp_capable 

Matthieu Baerts July 9, 2024, 9:03 a.m. UTC | #2

Hi Paolo,

On 05/07/2024 22:33, Paolo Abeni wrote:
> Issues/501 showed that the NL PM currently don't add corectly removal
> and re-add of signal endpoint.
> 
> Patches 1 and 2 addresses the issue, patch 3/4 introduce a related
> self-test, and the last patch address a pre-existing buglet in the
> self-test infra.
> 
> v1 -> v2:
>  - splitted the first 2 patches
>  - fixed accounting in mptcp_pm_remove_anno_addr
>  - self-tests depends on subflow_rebuild_header

Thank you for the v2, it looks good to me:

Reviewed-by: Matthieu Baerts (NGI0) <[e-mail]>

I will do a follow-up regarding the re-use of the same ID (if needed --
but I guess yes, because we never mark the ID as available again when we
remove a signal endpoint).

For the issue with Packetdrill, reported by the CI, I think it should be
fixed by this PR:

  https://github.com/multipath-tcp/packetdrill/pull/151

Cheers,
Matt

Matthieu Baerts July 9, 2024, 9:14 a.m. UTC | #3

Hi Paolo,

On 05/07/2024 22:33, Paolo Abeni wrote:
> Issues/501 showed that the NL PM currently don't add corectly removal
> and re-add of signal endpoint.

(I didn't close it, I didn't check if it is fully fixed yet)

> Patches 1 and 2 addresses the issue, patch 3/4 introduce a related
> self-test, and the last patch address a pre-existing buglet in the
> self-test infra.
Now in our tree:

New patches for t/upstream-net and t/upstream:
- a973aebd56ba: mptcp: fix user-space PM announced address accounting
- ed70cf97ff31: mptcp: fix NL PM announced address accounting
- dc47c6d60de4: selftests: mptcp: add explicit test case for remove/readd
- 538cf9db944b: selftests: mptcp: fix error path
- Results: 8db44fbab258..e21a2574f711 (export-net)
- Results: 91e30f779125..a1f720d3a383 (export)

Tests are now in progress:

- export-net:
https://github.com/multipath-tcp/mptcp_net-next/commit/93dd443c35874ff0a74cb51f747c08a9e0d1a5aa/checks
- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/52d4e14b827f1d4694bbb23dc513351ef0ac00fb/checks

Cheers,
Matt