| Message ID | 20240709113311.37168-1-make24@iscas.ac.cn (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v4] drm/gma500: fix null pointer dereference in cdv_intel_lvds_get_modes | expand |
… > Signed-off-by: Ma Ke <make24@iscas.ac.cn> Are you going to adjust this information anyhow? > --- > Changes in v4: > - revised the recipient email list, apologize for the inadvertent mistake. … The usage of mailing list addresses is probably undesirable for the Developer's Certificate of Origin, isn't it? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc7#n398 Regards, Markus
On Tue, Jul 9, 2024 at 1:33 PM Ma Ke <make24@iscas.ac.cn> wrote: > > In cdv_intel_lvds_get_modes(), the return value of drm_mode_duplicate() > is assigned to mode, which will lead to a NULL pointer dereference on > failure of drm_mode_duplicate(). Add a check to avoid npd. > > Cc: stable@vger.kernel.org > Fixes: 6a227d5fd6c4 ("gma500: Add support for Cedarview") > Signed-off-by: Ma Ke <make24@iscas.ac.cn> Thanks for the patch! Pushed to drm-misc-fixes -Patrik > --- > Changes in v4: > - revised the recipient email list, apologize for the inadvertent mistake. > Changes in v3: > - added the recipient's email address, due to the prolonged absence of a > response from the recipients. > Changes in v2: > - modified the patch according to suggestions from other patchs; > - added Fixes line; > - added Cc stable; > - Link: https://lore.kernel.org/lkml/20240622072514.1867582-1-make24@iscas.ac.cn/T/ > --- > drivers/gpu/drm/gma500/cdv_intel_lvds.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/gma500/cdv_intel_lvds.c b/drivers/gpu/drm/gma500/cdv_intel_lvds.c > index f08a6803dc18..3adc2c9ab72d 100644 > --- a/drivers/gpu/drm/gma500/cdv_intel_lvds.c > +++ b/drivers/gpu/drm/gma500/cdv_intel_lvds.c > @@ -311,6 +311,9 @@ static int cdv_intel_lvds_get_modes(struct drm_connector *connector) > if (mode_dev->panel_fixed_mode != NULL) { > struct drm_display_mode *mode = > drm_mode_duplicate(dev, mode_dev->panel_fixed_mode); > + if (!mode) > + return 0; > + > drm_mode_probed_add(connector, mode); > return 1; > } > -- > 2.25.1 >
… > > Signed-off-by: Ma Ke <make24@iscas.ac.cn> > > Thanks for the patch! > Pushed to drm-misc-fixes Do you care for the applicability of the available information according to this tag? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc7#n398 Regards, Markus
diff --git a/drivers/gpu/drm/gma500/cdv_intel_lvds.c b/drivers/gpu/drm/gma500/cdv_intel_lvds.c index f08a6803dc18..3adc2c9ab72d 100644 --- a/drivers/gpu/drm/gma500/cdv_intel_lvds.c +++ b/drivers/gpu/drm/gma500/cdv_intel_lvds.c @@ -311,6 +311,9 @@ static int cdv_intel_lvds_get_modes(struct drm_connector *connector) if (mode_dev->panel_fixed_mode != NULL) { struct drm_display_mode *mode = drm_mode_duplicate(dev, mode_dev->panel_fixed_mode); + if (!mode) + return 0; + drm_mode_probed_add(connector, mode); return 1; }
In cdv_intel_lvds_get_modes(), the return value of drm_mode_duplicate() is assigned to mode, which will lead to a NULL pointer dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. Cc: stable@vger.kernel.org Fixes: 6a227d5fd6c4 ("gma500: Add support for Cedarview") Signed-off-by: Ma Ke <make24@iscas.ac.cn> --- Changes in v4: - revised the recipient email list, apologize for the inadvertent mistake. Changes in v3: - added the recipient's email address, due to the prolonged absence of a response from the recipients. Changes in v2: - modified the patch according to suggestions from other patchs; - added Fixes line; - added Cc stable; - Link: https://lore.kernel.org/lkml/20240622072514.1867582-1-make24@iscas.ac.cn/T/ --- drivers/gpu/drm/gma500/cdv_intel_lvds.c | 3 +++ 1 file changed, 3 insertions(+)