[v2] Bluetooth: btnxpuart: Fix warnings for suspend and resume functions

Commit Message

Neeraj Sanjay Kale July 10, 2024, 12:34 p.m. UTC

This fixes the warnings 'nxp_serdev_resume' and 'nxp_serdev_suspend'
defined but not used.

Signed-off-by: Neeraj Sanjay Kale <[e-mail]>
Reported-by: kernel test robot <[e-mail]>
Closes: https://lore.kernel.org/oe-kbuild-all/[e-mail]/
---
v2: Rebase master, fix conflict due to copy-paste error from previous
patch (bluez.test.bot)
---
 drivers/bluetooth/btnxpuart.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

[e-mail] July 10, 2024, 1:16 p.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=870105

---Test result---

Test Summary:
CheckPatch                    PASS      0.70 seconds
GitLint                       FAIL      0.50 seconds
SubjectPrefix                 PASS      0.13 seconds
BuildKernel                   PASS      30.53 seconds
CheckAllWarning               PASS      32.96 seconds
CheckSparse                   PASS      38.44 seconds
CheckSmatch                   PASS      103.44 seconds
BuildKernel32                 PASS      32.49 seconds
TestRunnerSetup               PASS      531.52 seconds
TestRunner_l2cap-tester       PASS      20.31 seconds
TestRunner_iso-tester         PASS      37.02 seconds
TestRunner_bnep-tester        PASS      4.95 seconds
TestRunner_mgmt-tester        PASS      115.92 seconds
TestRunner_rfcomm-tester      PASS      10.37 seconds
TestRunner_sco-tester         PASS      15.14 seconds
TestRunner_ioctl-tester       PASS      8.03 seconds
TestRunner_mesh-tester        PASS      6.10 seconds
TestRunner_smp-tester         PASS      7.04 seconds
TestRunner_userchan-tester    PASS      5.21 seconds
IncrementalBuild              PASS      28.18 seconds

Details
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[v2] Bluetooth: btnxpuart: Fix warnings for suspend and resume functions

WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
8: B1 Line exceeds max length (82>80): "Closes: https://lore.kernel.org/oe-kbuild-all/[e-mail]/"


---
Regards,
Linux Bluetooth

[e-mail] July 10, 2024, 2:10 p.m. UTC | #2

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[e-mail]>:

On Wed, 10 Jul 2024 18:04:26 +0530 you wrote:
> This fixes the warnings 'nxp_serdev_resume' and 'nxp_serdev_suspend'
> defined but not used.
> 
> Signed-off-by: Neeraj Sanjay Kale <[e-mail]>
> Reported-by: kernel test robot <[e-mail]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[e-mail]/
> 
> [...]

Here is the summary with links:
  - [v2] Bluetooth: btnxpuart: Fix warnings for suspend and resume functions
    https://git.kernel.org/bluetooth/bluetooth-next/c/d752881e4cd2

You are awesome, thank you!

Patch

diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c
index f75b24bd3045..31d3dd90b672 100644
--- a/drivers/bluetooth/btnxpuart.c
+++ b/drivers/bluetooth/btnxpuart.c
@@ -1522,6 +1522,7 @@  static void nxp_serdev_remove(struct serdev_device *serdev)
 	hci_free_dev(hdev);
 }
 
+#ifdef CONFIG_PM_SLEEP
 static int nxp_serdev_suspend(struct device *dev)
 {
 	struct btnxpuart_dev *nxpdev = dev_get_drvdata(dev);
@@ -1539,6 +1540,7 @@  static int nxp_serdev_resume(struct device *dev)
 	ps_control(psdata->hdev, PS_STATE_AWAKE);
 	return 0;
 }
+#endif
 
 static struct btnxpuart_data w8987_data __maybe_unused = {
 	.helper_fw_name = NULL,