| Message ID | 20240702085508.30513-1-r.smirnov@omp.ru (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ba70a116d97108f21a853f5549758a720fdbefb3 |
| Headers | show |
| Series | [BlueZ,v1] shared/vcp: add NULL checks to foreach_aics_service() | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=867451 ---Test result--- Test Summary: CheckPatch PASS 0.44 seconds GitLint PASS 0.31 seconds BuildEll PASS 25.07 seconds BluezMake PASS 1697.26 seconds MakeCheck PASS 13.52 seconds MakeDistcheck PASS 176.92 seconds CheckValgrind PASS 253.95 seconds CheckSmatch PASS 354.89 seconds bluezmakeextell PASS 120.31 seconds IncrementalBuild PASS 1450.21 seconds ScanBuild PASS 1008.57 seconds --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Tue, 2 Jul 2024 11:55:08 +0300 you wrote: > Make foreach_aics_service() safe for passing NULL pointers. > > Found with the SVACE static analysis tool. > --- > src/shared/vcp.c | 3 +++ > 1 file changed, 3 insertions(+) Here is the summary with links: - [BlueZ,v1] shared/vcp: add NULL checks to foreach_aics_service() https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=ba70a116d971 You are awesome, thank you!
diff --git a/src/shared/vcp.c b/src/shared/vcp.c index b7e17e448..1f84da4a0 100644 --- a/src/shared/vcp.c +++ b/src/shared/vcp.c @@ -2714,6 +2714,9 @@ static void foreach_aics_service(struct gatt_db_attribute *attr, struct bt_vcp *vcp = user_data; struct bt_aics *aics = vcp_get_aics(vcp); + if (!aics || !attr) + return; + aics->service = attr; gatt_db_service_set_claimed(attr, true);