| Message ID | 20240708150130.54484-1-marex@denx.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v4,1/2] dt-bindings: display: bridge: tc358867: Document default DP preemphasis | expand |
On Mon, 08 Jul 2024 17:01:13 +0200, Marek Vasut wrote: > Document default DP port preemphasis configurable via new DT property > "toshiba,pre-emphasis". This is useful in case the DP link properties > are known and starting link training from preemphasis setting of 0 dB > is not useful. The preemphasis can be set separately for both DP lanes > in range 0=0dB, 1=3.5dB, 2=6dB . > > This is an endpoint property, not a port property, because the TC9595 > datasheet does mention that the DP might operate in some sort of split > mode, where each DP lane is used to feed one display, so in that case > there might be two endpoints. > > Signed-off-by: Marek Vasut <marex@denx.de> > --- > Cc: Alexander Stein <alexander.stein@ew.tq-group.com> > Cc: Andrzej Hajda <andrzej.hajda@intel.com> > Cc: Conor Dooley <conor+dt@kernel.org> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: David Airlie <airlied@gmail.com> > Cc: Jernej Skrabec <jernej.skrabec@gmail.com> > Cc: Jonas Karlman <jonas@kwiboo.se> > Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> > Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com> > Cc: Lucas Stach <l.stach@pengutronix.de> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Cc: Maxime Ripard <mripard@kernel.org> > Cc: Neil Armstrong <neil.armstrong@linaro.org> > Cc: Rob Herring <robh@kernel.org> > Cc: Robert Foss <rfoss@kernel.org> > Cc: Thomas Zimmermann <tzimmermann@suse.de> > Cc: devicetree@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: kernel@dh-electronics.com > --- > V2: - Fix the type to u8 array > - Fix the enum items to match what they represent > V3: - Update commit message, expand on this being an endpoint property > V4: - Fix ref: /schemas/graph.yaml#/$defs/port-base and add unevaluatedProperties > --- > .../display/bridge/toshiba,tc358767.yaml | 21 ++++++++++++++++++- > 1 file changed, 20 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
On 7/10/24 5:33 PM, Rob Herring (Arm) wrote: > > On Mon, 08 Jul 2024 17:01:13 +0200, Marek Vasut wrote: >> Document default DP port preemphasis configurable via new DT property >> "toshiba,pre-emphasis". This is useful in case the DP link properties >> are known and starting link training from preemphasis setting of 0 dB >> is not useful. The preemphasis can be set separately for both DP lanes >> in range 0=0dB, 1=3.5dB, 2=6dB . >> >> This is an endpoint property, not a port property, because the TC9595 >> datasheet does mention that the DP might operate in some sort of split >> mode, where each DP lane is used to feed one display, so in that case >> there might be two endpoints. >> >> Signed-off-by: Marek Vasut <marex@denx.de> >> --- >> Cc: Alexander Stein <alexander.stein@ew.tq-group.com> >> Cc: Andrzej Hajda <andrzej.hajda@intel.com> >> Cc: Conor Dooley <conor+dt@kernel.org> >> Cc: Daniel Vetter <daniel@ffwll.ch> >> Cc: David Airlie <airlied@gmail.com> >> Cc: Jernej Skrabec <jernej.skrabec@gmail.com> >> Cc: Jonas Karlman <jonas@kwiboo.se> >> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> >> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com> >> Cc: Lucas Stach <l.stach@pengutronix.de> >> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> >> Cc: Maxime Ripard <mripard@kernel.org> >> Cc: Neil Armstrong <neil.armstrong@linaro.org> >> Cc: Rob Herring <robh@kernel.org> >> Cc: Robert Foss <rfoss@kernel.org> >> Cc: Thomas Zimmermann <tzimmermann@suse.de> >> Cc: devicetree@vger.kernel.org >> Cc: dri-devel@lists.freedesktop.org >> Cc: kernel@dh-electronics.com >> --- >> V2: - Fix the type to u8 array >> - Fix the enum items to match what they represent >> V3: - Update commit message, expand on this being an endpoint property >> V4: - Fix ref: /schemas/graph.yaml#/$defs/port-base and add unevaluatedProperties >> --- >> .../display/bridge/toshiba,tc358767.yaml | 21 ++++++++++++++++++- >> 1 file changed, 20 insertions(+), 1 deletion(-) >> > > Reviewed-by: Rob Herring (Arm) <robh@kernel.org> If there are no objections, I will apply these two patches to drm-misc soon ?
diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml index 2ad0cd6dd49e0..b78f64c9c5f44 100644 --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml @@ -92,12 +92,31 @@ properties: reference to a valid DPI output or input endpoint node. port@2: - $ref: /schemas/graph.yaml#/properties/port + $ref: /schemas/graph.yaml#/$defs/port-base + unevaluatedProperties: false description: | eDP/DP output port. The remote endpoint phandle should be a reference to a valid eDP panel input endpoint node. This port is optional, treated as DP panel if not defined + properties: + endpoint: + $ref: /schemas/media/video-interfaces.yaml# + unevaluatedProperties: false + + properties: + toshiba,pre-emphasis: + description: + Display port output Pre-Emphasis settings for both DP lanes. + $ref: /schemas/types.yaml#/definitions/uint8-array + minItems: 2 + maxItems: 2 + items: + enum: + - 0 # No pre-emphasis + - 1 # 3.5dB pre-emphasis + - 2 # 6dB pre-emphasis + oneOf: - required: - port@0
Document default DP port preemphasis configurable via new DT property "toshiba,pre-emphasis". This is useful in case the DP link properties are known and starting link training from preemphasis setting of 0 dB is not useful. The preemphasis can be set separately for both DP lanes in range 0=0dB, 1=3.5dB, 2=6dB . This is an endpoint property, not a port property, because the TC9595 datasheet does mention that the DP might operate in some sort of split mode, where each DP lane is used to feed one display, so in that case there might be two endpoints. Signed-off-by: Marek Vasut <marex@denx.de> --- Cc: Alexander Stein <alexander.stein@ew.tq-group.com> Cc: Andrzej Hajda <andrzej.hajda@intel.com> Cc: Conor Dooley <conor+dt@kernel.org> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: David Airlie <airlied@gmail.com> Cc: Jernej Skrabec <jernej.skrabec@gmail.com> Cc: Jonas Karlman <jonas@kwiboo.se> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com> Cc: Lucas Stach <l.stach@pengutronix.de> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Maxime Ripard <mripard@kernel.org> Cc: Neil Armstrong <neil.armstrong@linaro.org> Cc: Rob Herring <robh@kernel.org> Cc: Robert Foss <rfoss@kernel.org> Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: devicetree@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: kernel@dh-electronics.com --- V2: - Fix the type to u8 array - Fix the enum items to match what they represent V3: - Update commit message, expand on this being an endpoint property V4: - Fix ref: /schemas/graph.yaml#/$defs/port-base and add unevaluatedProperties --- .../display/bridge/toshiba,tc358767.yaml | 21 ++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-)