| Message ID | 20240710-x1e80100-crd-backlight-v1-2-eb242311a23e@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/panel: atna33xc20: Fix the Samsung ATNA45AF01 panel | expand |
Hi, On Wed, Jul 10, 2024 at 10:05 AM Stephan Gerhold <stephan.gerhold@linaro.org> wrote: > > The Samsung ATNA45AF01 panel needs exactly the same non-standard power > sequence as the Samsung ATNA33XC20 panel for backlight to work properly. > Add the new "samsung,atna45af01" compatible to the driver to make it handle > these panels as well. > > While ATNA45AF01 would also work with "samsung,atna33xc20" as a fallback > compatible, the original submission of the compatible in commit > 4bfe6c8f7c23 ("drm/panel-simple: Add Samsung ATNA33XC20") had the timings > and resolution hardcoded. These would not work for ATNA45AF01. > > Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org> > --- > drivers/gpu/drm/panel/panel-samsung-atna33xc20.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c b/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c > index 9a482a744b8c..fd56fd02df87 100644 > --- a/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c > +++ b/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c > @@ -333,6 +333,7 @@ static void atana33xc20_remove(struct dp_aux_ep_device *aux_ep) > > static const struct of_device_id atana33xc20_dt_match[] = { > { .compatible = "samsung,atna33xc20", }, > + { .compatible = "samsung,atna45af01", }, As per my response to patch #1, you don't need this change at all if you just add a fallback compatible. Later if there is anything special we need to do for this panel we can match against it, but right now there is no need. -Doug
diff --git a/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c b/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c index 9a482a744b8c..fd56fd02df87 100644 --- a/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c +++ b/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c @@ -333,6 +333,7 @@ static void atana33xc20_remove(struct dp_aux_ep_device *aux_ep) static const struct of_device_id atana33xc20_dt_match[] = { { .compatible = "samsung,atna33xc20", }, + { .compatible = "samsung,atna45af01", }, { /* sentinal */ } }; MODULE_DEVICE_TABLE(of, atana33xc20_dt_match);
The Samsung ATNA45AF01 panel needs exactly the same non-standard power sequence as the Samsung ATNA33XC20 panel for backlight to work properly. Add the new "samsung,atna45af01" compatible to the driver to make it handle these panels as well. While ATNA45AF01 would also work with "samsung,atna33xc20" as a fallback compatible, the original submission of the compatible in commit 4bfe6c8f7c23 ("drm/panel-simple: Add Samsung ATNA33XC20") had the timings and resolution hardcoded. These would not work for ATNA45AF01. Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org> --- drivers/gpu/drm/panel/panel-samsung-atna33xc20.c | 1 + 1 file changed, 1 insertion(+)