| Message ID | 20240710-x1e80100-crd-backlight-v1-3-eb242311a23e@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/panel: atna33xc20: Fix the Samsung ATNA45AF01 panel | expand |
Hi, On Wed, Jul 10, 2024 at 10:05 AM Stephan Gerhold <stephan.gerhold@linaro.org> wrote: > > This reverts commit 8ebb1fc2e69ab8b89a425e402c7bd85e053b7b01. > > The panel should be handled through the samsung-atna33xc20 driver for > correct power up timings. Otherwise the backlight does not work correctly. > > We have existing users of this panel through the generic "edp-panel" > compatible (e.g. the Qualcomm X1E80100 CRD), but the screen works only > partially in that configuration: It works after boot but once the screen > gets disabled it does not turn on again until after reboot. It behaves the > same way with the default "conservative" timings, so we might as well drop > the configuration from the panel-edp driver. That way, users with old DTBs > will get a warning and can move to the new driver. > > Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org> > --- > drivers/gpu/drm/panel/panel-edp.c | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Douglas Anderson <dianders@chromium.org>
diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index 3a574a9b46e7..d2d682385e89 100644 --- a/drivers/gpu/drm/panel/panel-edp.c +++ b/drivers/gpu/drm/panel/panel-edp.c @@ -1960,8 +1960,6 @@ static const struct edp_panel_entry edp_panels[] = { EDP_PANEL_ENTRY('L', 'G', 'D', 0x05af, &delay_200_500_e200_d200, "Unknown"), EDP_PANEL_ENTRY('L', 'G', 'D', 0x05f1, &delay_200_500_e200_d200, "Unknown"), - EDP_PANEL_ENTRY('S', 'D', 'C', 0x416d, &delay_100_500_e200, "ATNA45AF01"), - EDP_PANEL_ENTRY('S', 'H', 'P', 0x1511, &delay_200_500_e50, "LQ140M1JW48"), EDP_PANEL_ENTRY('S', 'H', 'P', 0x1523, &delay_80_500_e50, "LQ140M1JW46"), EDP_PANEL_ENTRY('S', 'H', 'P', 0x153a, &delay_200_500_e50, "LQ140T1JH01"),
This reverts commit 8ebb1fc2e69ab8b89a425e402c7bd85e053b7b01. The panel should be handled through the samsung-atna33xc20 driver for correct power up timings. Otherwise the backlight does not work correctly. We have existing users of this panel through the generic "edp-panel" compatible (e.g. the Qualcomm X1E80100 CRD), but the screen works only partially in that configuration: It works after boot but once the screen gets disabled it does not turn on again until after reboot. It behaves the same way with the default "conservative" timings, so we might as well drop the configuration from the panel-edp driver. That way, users with old DTBs will get a warning and can move to the new driver. Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org> --- drivers/gpu/drm/panel/panel-edp.c | 2 -- 1 file changed, 2 deletions(-)