diff mbox series

[for-4.20,v2] automation: Use a different ImageBuilder repository URL

Message ID 20240710093751.25154-1-michal.orzel@amd.com (mailing list archive)
State New
Headers show
Series [for-4.20,v2] automation: Use a different ImageBuilder repository URL | expand

Commit Message

Michal Orzel July 10, 2024, 9:37 a.m. UTC 
Switch to using https://gitlab.com/xen-project/imagebuilder.git which
should be considered official ImageBuilder repo.

Take the opportunity to truncate the git history when cloning using
--depth 1.

Signed-off-by: Michal Orzel <michal.orzel@amd.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
Changes in v2:
 - truncate history when cloning
---
 automation/scripts/qemu-smoke-dom0-arm32.sh       | 2 +-
 automation/scripts/qemu-smoke-dom0-arm64.sh       | 2 +-
 automation/scripts/qemu-smoke-dom0less-arm32.sh   | 2 +-
 automation/scripts/qemu-smoke-dom0less-arm64.sh   | 2 +-
 automation/scripts/qemu-xtf-dom0less-arm64.sh     | 2 +-
 automation/scripts/xilinx-smoke-dom0less-arm64.sh | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

Comments

Andrew Cooper July 10, 2024, 9:44 a.m. UTC | #1 
On 10/07/2024 10:37 am, Michal Orzel wrote:
> Switch to using https://gitlab.com/xen-project/imagebuilder.git which
> should be considered official ImageBuilder repo.
>
> Take the opportunity to truncate the git history when cloning using
> --depth 1.
>
> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

Given the current overhaul I'm (still) doing for CI in 4.19, I'd suggest
taking this.

It will mean an 8-month improvement in switching over fully.

~Andrew
Alejandro Vallejo July 10, 2024, 11:09 a.m. UTC | #2 
On Wed Jul 10, 2024 at 10:37 AM BST, Michal Orzel wrote:
> Switch to using https://gitlab.com/xen-project/imagebuilder.git which
> should be considered official ImageBuilder repo.
>
> Take the opportunity to truncate the git history when cloning using
> --depth 1.
>
> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> Changes in v2:
>  - truncate history when cloning
> ---
>  automation/scripts/qemu-smoke-dom0-arm32.sh       | 2 +-
>  automation/scripts/qemu-smoke-dom0-arm64.sh       | 2 +-
>  automation/scripts/qemu-smoke-dom0less-arm32.sh   | 2 +-
>  automation/scripts/qemu-smoke-dom0less-arm64.sh   | 2 +-
>  automation/scripts/qemu-xtf-dom0less-arm64.sh     | 2 +-
>  automation/scripts/xilinx-smoke-dom0less-arm64.sh | 2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)

lgtm,

Reviewed-by: Alejandro Vallejo <alejandro.vallejo@cloud.com>
Stefano Stabellini July 10, 2024, 8:42 p.m. UTC | #3 
On Wed, 10 Jul 2024, Andrew Cooper wrote:
> On 10/07/2024 10:37 am, Michal Orzel wrote:
> > Switch to using https://gitlab.com/xen-project/imagebuilder.git which
> > should be considered official ImageBuilder repo.
> >
> > Take the opportunity to truncate the git history when cloning using
> > --depth 1.
> >
> > Signed-off-by: Michal Orzel <michal.orzel@amd.com>
> > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> 
> Given the current overhaul I'm (still) doing for CI in 4.19, I'd suggest
> taking this.
> 
> It will mean an 8-month improvement in switching over fully.

Agreed
Oleksii Kurochko July 11, 2024, 8:11 a.m. UTC | #4 
On Wed, 2024-07-10 at 10:44 +0100, Andrew Cooper wrote:
> On 10/07/2024 10:37 am, Michal Orzel wrote:
> > Switch to using
> > https://gitlab.com/xen-project/imagebuilder.git which
> > should be considered official ImageBuilder repo.
> > 
> > Take the opportunity to truncate the git history when cloning using
> > --depth 1.
> > 
> > Signed-off-by: Michal Orzel <michal.orzel@amd.com>
> > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> 
> Given the current overhaul I'm (still) doing for CI in 4.19, I'd
> suggest
> taking this.

-git clone https://gitlab.com/ViryaOS/imagebuilder
+git clone https://gitlab.com/xen-project/imagebuilder.git

But is it the same imagebuilders and only location is changed?

~ Oleksii

> 
> It will mean an 8-month improvement in switching over fully.
> 
> ~Andrew
Michal Orzel July 11, 2024, 8:14 a.m. UTC | #5 
Hi Oleksii,

On 11/07/2024 10:11, Oleksii wrote:
> 
> 
> On Wed, 2024-07-10 at 10:44 +0100, Andrew Cooper wrote:
>> On 10/07/2024 10:37 am, Michal Orzel wrote:
>>> Switch to using
>>> https://gitlab.com/xen-project/imagebuilder.git which
>>> should be considered official ImageBuilder repo.
>>>
>>> Take the opportunity to truncate the git history when cloning using
>>> --depth 1.
>>>
>>> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
>>> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>>
>> Given the current overhaul I'm (still) doing for CI in 4.19, I'd
>> suggest
>> taking this.
> 
> -git clone https://gitlab.com/ViryaOS/imagebuilder
> +git clone https://gitlab.com/xen-project/imagebuilder.git
> 
> But is it the same imagebuilders and only location is changed?
That's the same project but the repo under xen-project is more up-to-date and we decided
that it should be considered the official repo location.

You can check that it contains more commits.

~Michal
Oleksii Kurochko July 11, 2024, 8:56 a.m. UTC | #6 
On Thu, 2024-07-11 at 10:14 +0200, Michal Orzel wrote:
> Hi Oleksii,
> 
> On 11/07/2024 10:11, Oleksii wrote:
> > 
> > 
> > On Wed, 2024-07-10 at 10:44 +0100, Andrew Cooper wrote:
> > > On 10/07/2024 10:37 am, Michal Orzel wrote:
> > > > Switch to using
> > > > https://gitlab.com/xen-project/imagebuilder.git which
> > > > should be considered official ImageBuilder repo.
> > > > 
> > > > Take the opportunity to truncate the git history when cloning
> > > > using
> > > > --depth 1.
> > > > 
> > > > Signed-off-by: Michal Orzel <michal.orzel@amd.com>
> > > > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> > > 
> > > Given the current overhaul I'm (still) doing for CI in 4.19, I'd
> > > suggest
> > > taking this.
> > 
> > -git clone https://gitlab.com/ViryaOS/imagebuilder
> > +git clone https://gitlab.com/xen-project/imagebuilder.git
> > 
> > But is it the same imagebuilders and only location is changed?
> That's the same project but the repo under xen-project is more up-to-
> date and we decided
> that it should be considered the official repo location.
Then I am okay to have this change in 4.19:
Release-Acked-By: Oleksii Kurochko <oleksii.kurochko@gmail.com>

~ Oleksii
diff mbox series

Patch

diff --git a/automation/scripts/qemu-smoke-dom0-arm32.sh b/automation/scripts/qemu-smoke-dom0-arm32.sh
index d91648905669..31c05cc840e5 100755
--- a/automation/scripts/qemu-smoke-dom0-arm32.sh
+++ b/automation/scripts/qemu-smoke-dom0-arm32.sh
@@ -73,7 +73,7 @@  UBOOT_SOURCE="boot.source"
 UBOOT_SCRIPT="boot.scr"' > config
 
 rm -rf imagebuilder
-git clone https://gitlab.com/ViryaOS/imagebuilder
+git clone --depth 1 https://gitlab.com/xen-project/imagebuilder.git
 bash imagebuilder/scripts/uboot-script-gen -t tftp -d . -c config
 
 rm -f ${serial_log}
diff --git a/automation/scripts/qemu-smoke-dom0-arm64.sh b/automation/scripts/qemu-smoke-dom0-arm64.sh
index e0bb37af3610..352963a741ce 100755
--- a/automation/scripts/qemu-smoke-dom0-arm64.sh
+++ b/automation/scripts/qemu-smoke-dom0-arm64.sh
@@ -87,7 +87,7 @@  LOAD_CMD="tftpb"
 UBOOT_SOURCE="boot.source"
 UBOOT_SCRIPT="boot.scr"' > binaries/config
 rm -rf imagebuilder
-git clone https://gitlab.com/ViryaOS/imagebuilder
+git clone --depth 1 https://gitlab.com/xen-project/imagebuilder.git
 bash imagebuilder/scripts/uboot-script-gen -t tftp -d binaries/ -c binaries/config
 
 
diff --git a/automation/scripts/qemu-smoke-dom0less-arm32.sh b/automation/scripts/qemu-smoke-dom0less-arm32.sh
index 1e2b939aadf7..c027c8c5c823 100755
--- a/automation/scripts/qemu-smoke-dom0less-arm32.sh
+++ b/automation/scripts/qemu-smoke-dom0less-arm32.sh
@@ -125,7 +125,7 @@  if [[ "${test_variant}" == "without-dom0" ]]; then
 fi
 
 rm -rf imagebuilder
-git clone https://gitlab.com/ViryaOS/imagebuilder
+git clone --depth 1 https://gitlab.com/xen-project/imagebuilder.git
 bash imagebuilder/scripts/uboot-script-gen -t tftp -d . -c config
 
 # Run the test
diff --git a/automation/scripts/qemu-smoke-dom0less-arm64.sh b/automation/scripts/qemu-smoke-dom0less-arm64.sh
index 292c38a56147..15258692d58c 100755
--- a/automation/scripts/qemu-smoke-dom0less-arm64.sh
+++ b/automation/scripts/qemu-smoke-dom0less-arm64.sh
@@ -198,7 +198,7 @@  NUM_CPUPOOLS=1' >> binaries/config
 fi
 
 rm -rf imagebuilder
-git clone https://gitlab.com/ViryaOS/imagebuilder
+git clone --depth 1 https://gitlab.com/xen-project/imagebuilder.git
 bash imagebuilder/scripts/uboot-script-gen -t tftp -d binaries/ -c binaries/config
 
 
diff --git a/automation/scripts/qemu-xtf-dom0less-arm64.sh b/automation/scripts/qemu-xtf-dom0less-arm64.sh
index a667e0412c92..b08c2d44fb4f 100755
--- a/automation/scripts/qemu-xtf-dom0less-arm64.sh
+++ b/automation/scripts/qemu-xtf-dom0less-arm64.sh
@@ -45,7 +45,7 @@  UBOOT_SOURCE="boot.source"
 UBOOT_SCRIPT="boot.scr"' > binaries/config
 
 rm -rf imagebuilder
-git clone https://gitlab.com/ViryaOS/imagebuilder
+git clone --depth 1 https://gitlab.com/xen-project/imagebuilder.git
 bash imagebuilder/scripts/uboot-script-gen -t tftp -d binaries/ -c binaries/config
 
 # Run the test
diff --git a/automation/scripts/xilinx-smoke-dom0less-arm64.sh b/automation/scripts/xilinx-smoke-dom0less-arm64.sh
index 4a071c6ef148..666411d6a065 100755
--- a/automation/scripts/xilinx-smoke-dom0less-arm64.sh
+++ b/automation/scripts/xilinx-smoke-dom0less-arm64.sh
@@ -122,7 +122,7 @@  if [[ "${test_variant}" == "gem-passthrough" ]]; then
 fi
 
 rm -rf imagebuilder
-git clone https://gitlab.com/ViryaOS/imagebuilder
+git clone --depth 1 https://gitlab.com/xen-project/imagebuilder.git
 bash imagebuilder/scripts/uboot-script-gen -t tftp -d $TFTP/ -c $TFTP/config
 
 # restart the board