| Message ID | 20240705-btaml-v1-4-7f1538f98cef@amlogic.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add support for Amlogic HCI UART | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/SubjectPrefix | fail | "Bluetooth: " prefix is not specified in the subject |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
On 05/07/2024 13:20, Yang Li via B4 Relay wrote: > From: Yang Li <yang.li@amlogic.com> > > Add Amlogic Bluetooth driver and driver document. > > Signed-off-by: Yang Li <yang.li@amlogic.com> > --- > MAINTAINERS | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index cd3277a98cfe..b81089290930 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1140,6 +1140,14 @@ S: Supported > F: arch/arm64/boot/dts/amd/amd-seattle-xgbe*.dtsi > F: drivers/net/ethernet/amd/xgbe/ > > +AMLOGIC BLUETOOTH DRIVER > +M: Yang Li <yang.li@amlogic.com> > +L: linux-bluetooth@vger.kernel.org > +S: Maintained > +W: http://www.amlogic.com Same as in your other patches. Drop. It's not a place for marketing. Or provide useful link. Best regards, Krzysztof
On 2024/7/7 21:11, Krzysztof Kozlowski wrote: > On 05/07/2024 13:20, Yang Li via B4 Relay wrote: >> From: Yang Li <yang.li@amlogic.com> >> >> Add Amlogic Bluetooth driver and driver document. >> >> Signed-off-by: Yang Li <yang.li@amlogic.com> >> --- >> MAINTAINERS | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index cd3277a98cfe..b81089290930 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -1140,6 +1140,14 @@ S: Supported >> F: arch/arm64/boot/dts/amd/amd-seattle-xgbe*.dtsi >> F: drivers/net/ethernet/amd/xgbe/ >> >> +AMLOGIC BLUETOOTH DRIVER >> +M: Yang Li <yang.li@amlogic.com> >> +L: linux-bluetooth@vger.kernel.org >> +S: Maintained >> +W: http://www.amlogic.com > Same as in your other patches. Drop. It's not a place for marketing. Or > provide useful link. Will do. > > > Best regards, > Krzysztof >
Dear Yang,
Thank you for the patch. `git log --oneline` does not contain the/your
name, so people would need to look it up. Maybe:
MAINTAINERS: Add Amlogic Bluetooth entry maintained by Yang Li
or
MAINTAINERS: Add Amlogic Bluetooth entry (M: Yang Li)
Am 05.07.24 um 13:20 schrieb Yang Li via B4 Relay:
> From: Yang Li <yang.li@amlogic.com>
>
> Add Amlogic Bluetooth driver and driver document.
Does this match the change of `MAINTAINERS`?
> Signed-off-by: Yang Li <yang.li@amlogic.com>
> ---
> MAINTAINERS | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index cd3277a98cfe..b81089290930 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1140,6 +1140,14 @@ S: Supported
> F: arch/arm64/boot/dts/amd/amd-seattle-xgbe*.dtsi
> F: drivers/net/ethernet/amd/xgbe/
>
> +AMLOGIC BLUETOOTH DRIVER
> +M: Yang Li <yang.li@amlogic.com>
> +L: linux-bluetooth@vger.kernel.org
> +S: Maintained
> +W: http://www.amlogic.com
> +F: Documentation/devicetree/bindings/net/bluetooth/amlogic,w155s2-bt.yaml
> +F: drivers/bluetooth/hci_aml.c
> +
> AMLOGIC DDR PMU DRIVER
> M: Jiucheng Xu <jiucheng.xu@amlogic.com>
> L: linux-amlogic@lists.infradead.org
Acked-by: Paul Menzel <pmenzel@molgen.mpg.de>
Kind regards,
Paul
Dear Paul Thanks for your remind. On 2024/7/12 20:34, Paul Menzel wrote: > > Dear Yang, > > > Thank you for the patch. `git log --oneline` does not contain the/your > name, so people would need to look it up. Maybe: > > MAINTAINERS: Add Amlogic Bluetooth entry maintained by Yang Li > > or > > MAINTAINERS: Add Amlogic Bluetooth entry (M: Yang Li) Well, I got it. > > Am 05.07.24 um 13:20 schrieb Yang Li via B4 Relay: >> From: Yang Li <yang.li@amlogic.com> >> >> Add Amlogic Bluetooth driver and driver document. > > Does this match the change of `MAINTAINERS`? Well, I initially interpreted the 'driver document' as the device tree (dt) binding file, but this might be a misalignment. Therefore, I will revise it to: 'Add an Amlogic Bluetooth entry in the MAINTAINERS file to clarify the maintainers.' thanks~ > >> Signed-off-by: Yang Li <yang.li@amlogic.com> >> --- >> MAINTAINERS | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index cd3277a98cfe..b81089290930 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -1140,6 +1140,14 @@ S: Supported >> F: arch/arm64/boot/dts/amd/amd-seattle-xgbe*.dtsi >> F: drivers/net/ethernet/amd/xgbe/ >> >> +AMLOGIC BLUETOOTH DRIVER >> +M: Yang Li <yang.li@amlogic.com> >> +L: linux-bluetooth@vger.kernel.org >> +S: Maintained >> +W: http://www.amlogic.com >> +F: >> Documentation/devicetree/bindings/net/bluetooth/amlogic,w155s2-bt.yaml >> +F: drivers/bluetooth/hci_aml.c >> + >> AMLOGIC DDR PMU DRIVER >> M: Jiucheng Xu <jiucheng.xu@amlogic.com> >> L: linux-amlogic@lists.infradead.org > > Acked-by: Paul Menzel <pmenzel@molgen.mpg.de> > > > Kind regards, > > Paul
diff --git a/MAINTAINERS b/MAINTAINERS index cd3277a98cfe..b81089290930 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1140,6 +1140,14 @@ S: Supported F: arch/arm64/boot/dts/amd/amd-seattle-xgbe*.dtsi F: drivers/net/ethernet/amd/xgbe/ +AMLOGIC BLUETOOTH DRIVER +M: Yang Li <yang.li@amlogic.com> +L: linux-bluetooth@vger.kernel.org +S: Maintained +W: http://www.amlogic.com +F: Documentation/devicetree/bindings/net/bluetooth/amlogic,w155s2-bt.yaml +F: drivers/bluetooth/hci_aml.c + AMLOGIC DDR PMU DRIVER M: Jiucheng Xu <jiucheng.xu@amlogic.com> L: linux-amlogic@lists.infradead.org