diff mbox series

[2/3] btrfs-progs: btrfstune: fix documentation for --enable-simple-quota

Message ID e30318f3bd2579e9492d2e1e0fd4b408c2bd0fb9.1720732480.git.boris@bur.io (mailing list archive)
State New, archived
Headers show
Series btrfs-progs: btrfstune --remove-simple-quota | expand

Commit Message

Boris Burkov July 11, 2024, 9:18 p.m. UTC
The documentation lists -q as the flag for enabling simple quotas, but
the actual parsing only handles --enable-simple-quota. Update the
documentation string.

Signed-off-by: Boris Burkov <boris@bur.io>
---
 tune/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Qu Wenruo July 11, 2024, 10:34 p.m. UTC | #1
在 2024/7/12 06:48, Boris Burkov 写道:
> The documentation lists -q as the flag for enabling simple quotas, but
> the actual parsing only handles --enable-simple-quota. Update the
> documentation string.
>
> Signed-off-by: Boris Burkov <boris@bur.io>

I didn't find the man page entry for simple quota in the latest devel
branch.

Is it missing or still experimental?

Otherwise the change itself is good.

Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu
> ---
>   tune/main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tune/main.c b/tune/main.c
> index bec896907..cb93d2cb3 100644
> --- a/tune/main.c
> +++ b/tune/main.c
> @@ -103,7 +103,7 @@ static const char * const tune_usage[] = {
>   	OPTLINE("-x", "enable skinny metadata extent refs (mkfs: skinny-metadata)"),
>   	OPTLINE("-n", "enable no-holes feature (mkfs: no-holes, more efficient sparse file representation)"),
>   	OPTLINE("-S <0|1>", "set/unset seeding status of a device"),
> -	OPTLINE("-q", "enable simple quotas on the file system. (mkfs: squota)"),
> +	OPTLINE("--enable-simple-quota", "enable simple quotas on the file system. (mkfs: squota)"),
>   	OPTLINE("--convert-to-block-group-tree", "convert filesystem to track block groups in "
>   			"the separate block-group-tree instead of extent tree (sets the incompat bit)"),
>   	OPTLINE("--convert-from-block-group-tree",
diff mbox series

Patch

diff --git a/tune/main.c b/tune/main.c
index bec896907..cb93d2cb3 100644
--- a/tune/main.c
+++ b/tune/main.c
@@ -103,7 +103,7 @@  static const char * const tune_usage[] = {
 	OPTLINE("-x", "enable skinny metadata extent refs (mkfs: skinny-metadata)"),
 	OPTLINE("-n", "enable no-holes feature (mkfs: no-holes, more efficient sparse file representation)"),
 	OPTLINE("-S <0|1>", "set/unset seeding status of a device"),
-	OPTLINE("-q", "enable simple quotas on the file system. (mkfs: squota)"),
+	OPTLINE("--enable-simple-quota", "enable simple quotas on the file system. (mkfs: squota)"),
 	OPTLINE("--convert-to-block-group-tree", "convert filesystem to track block groups in "
 			"the separate block-group-tree instead of extent tree (sets the incompat bit)"),
 	OPTLINE("--convert-from-block-group-tree",