| Message ID | f5f38709c01d369ed9e375ceb2a9a12986457a1a.1720707932.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | platform: arm64: EC_ACER_ASPIRE1 should depend on ARCH_QCOM | expand |
Hi Geert, On 7/11/24 4:30 PM, Geert Uytterhoeven wrote: > The Acer Aspire 1 Embedded Controller is only present on the Qualcomm > Snapdragon-based Acer Aspire 1 laptop. Hence add a dependency on > ARCH_QCOM, to prevent asking the user about this driver when configuring > a kernel without Qualcomm SoC support. > > Fixes: 2b3efb7c515111ea ("platform: arm64: Add Acer Aspire 1 embedded controller driver") Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Not sure if this warrants a fixes tag though, anyways I'll leave that up to Ilpo when he applies this. Regards, Hans > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > drivers/platform/arm64/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/arm64/Kconfig b/drivers/platform/arm64/Kconfig > index 8c103b3150d1d0a6..058a4baa216a83b8 100644 > --- a/drivers/platform/arm64/Kconfig > +++ b/drivers/platform/arm64/Kconfig > @@ -18,6 +18,7 @@ if ARM64_PLATFORM_DEVICES > > config EC_ACER_ASPIRE1 > tristate "Acer Aspire 1 Embedded Controller driver" > + depends on ARCH_QCOM || COMPILE_TEST > depends on I2C > depends on DRM > depends on POWER_SUPPLY
Geert Uytterhoeven писал(а) 11.07.2024 19:30: > The Acer Aspire 1 Embedded Controller is only present on the Qualcomm > Snapdragon-based Acer Aspire 1 laptop. Hence add a dependency on > ARCH_QCOM, to prevent asking the user about this driver when configuring > a kernel without Qualcomm SoC support. > Oh yeah, you're right. Thanks for fixing this! Acked-by: Nikita Travkin <nikita@trvn.ru> We should probably do the same for the C630 driver as well... > Fixes: 2b3efb7c515111ea ("platform: arm64: Add Acer Aspire 1 embedded controller driver") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > drivers/platform/arm64/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/arm64/Kconfig b/drivers/platform/arm64/Kconfig > index 8c103b3150d1d0a6..058a4baa216a83b8 100644 > --- a/drivers/platform/arm64/Kconfig > +++ b/drivers/platform/arm64/Kconfig > @@ -18,6 +18,7 @@ if ARM64_PLATFORM_DEVICES > > config EC_ACER_ASPIRE1 > tristate "Acer Aspire 1 Embedded Controller driver" > + depends on ARCH_QCOM || COMPILE_TEST > depends on I2C > depends on DRM > depends on POWER_SUPPLY
On Thu, 11 Jul 2024, Nikita Travkin wrote: > Geert Uytterhoeven писал(а) 11.07.2024 19:30: > > The Acer Aspire 1 Embedded Controller is only present on the Qualcomm > > Snapdragon-based Acer Aspire 1 laptop. Hence add a dependency on > > ARCH_QCOM, to prevent asking the user about this driver when configuring > > a kernel without Qualcomm SoC support. > > > > Oh yeah, you're right. Thanks for fixing this! > > Acked-by: Nikita Travkin <nikita@trvn.ru> > > We should probably do the same for the C630 driver as well... Yes, Geert sent another patch for that already.
On Thu, 11 Jul 2024 16:30:36 +0200, Geert Uytterhoeven wrote: > The Acer Aspire 1 Embedded Controller is only present on the Qualcomm > Snapdragon-based Acer Aspire 1 laptop. Hence add a dependency on > ARCH_QCOM, to prevent asking the user about this driver when configuring > a kernel without Qualcomm SoC support. > > Thank you for your contribution, it has been applied to my local review-ilpo branch. Note it will show up in the public platform-drivers-x86/review-ilpo branch only once I've pushed my local branch there, which might take a while. The list of commits applied: [1/1] platform: arm64: EC_ACER_ASPIRE1 should depend on ARCH_QCOM commit: 03b927565057dae39da3e4b46e5ab65274b5dcdc -- i.
diff --git a/drivers/platform/arm64/Kconfig b/drivers/platform/arm64/Kconfig index 8c103b3150d1d0a6..058a4baa216a83b8 100644 --- a/drivers/platform/arm64/Kconfig +++ b/drivers/platform/arm64/Kconfig @@ -18,6 +18,7 @@ if ARM64_PLATFORM_DEVICES config EC_ACER_ASPIRE1 tristate "Acer Aspire 1 Embedded Controller driver" + depends on ARCH_QCOM || COMPILE_TEST depends on I2C depends on DRM depends on POWER_SUPPLY
The Acer Aspire 1 Embedded Controller is only present on the Qualcomm Snapdragon-based Acer Aspire 1 laptop. Hence add a dependency on ARCH_QCOM, to prevent asking the user about this driver when configuring a kernel without Qualcomm SoC support. Fixes: 2b3efb7c515111ea ("platform: arm64: Add Acer Aspire 1 embedded controller driver") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/platform/arm64/Kconfig | 1 + 1 file changed, 1 insertion(+)