Message ID | 20240713180607.147942-3-virag.david003@gmail.com (mailing list archive) |
---|---|
State | Accepted |
Headers | show |
Series | arm64: dts: exynos: exynos7885-jackpotlte: Correct RAM amount to 4GB | expand |
On Sat, Jul 13, 2024 at 1:08 PM David Virag <virag.david003@gmail.com> wrote: > > All known jackpotlte variants have 4GB of RAM, let's use it all. > RAM was set to 3GB from a mistake in the vendor provided DTS file. > > Fixes: 06874015327b ("arm64: dts: exynos: Add initial device tree support for Exynos7885 SoC") > Signed-off-by: David Virag <virag.david003@gmail.com> > --- Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> > arch/arm64/boot/dts/exynos/exynos7885-jackpotlte.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/exynos/exynos7885-jackpotlte.dts b/arch/arm64/boot/dts/exynos/exynos7885-jackpotlte.dts > index ed2925b4715f..0d5c26a197d8 100644 > --- a/arch/arm64/boot/dts/exynos/exynos7885-jackpotlte.dts > +++ b/arch/arm64/boot/dts/exynos/exynos7885-jackpotlte.dts > @@ -57,7 +57,7 @@ memory@80000000 { > device_type = "memory"; > reg = <0x0 0x80000000 0x3da00000>, > <0x0 0xc0000000 0x40000000>, > - <0x8 0x80000000 0x40000000>; > + <0x8 0x80000000 0x80000000>; > }; > > gpio-keys { > -- > 2.45.2 >
On 13/07/2024 19:58, David Virag wrote: > All known jackpotlte variants have 4GB of RAM, let's use it all. > RAM was set to 3GB from a mistake in the vendor provided DTS file. Hm, vendor DTS rarely has a mistake of missing 1 GB of RAM, so I assume there was some reason behind it. Trusted apps? Some shared memory for other co-processor? Anyway, if this works 100% for you, then I am fine with it. It is too late in the cycle for me to pick it up. I will take it after the merge window. Best regards, Krzysztof
On Sat, 2024-07-13 at 20:54 +0200, Krzysztof Kozlowski wrote: > On 13/07/2024 19:58, David Virag wrote: > > All known jackpotlte variants have 4GB of RAM, let's use it all. > > RAM was set to 3GB from a mistake in the vendor provided DTS file. > > Hm, vendor DTS rarely has a mistake of missing 1 GB of RAM, so I > assume > there was some reason behind it. Trusted apps? Some shared memory for > other co-processor? Honestly I'm not sure, maybe some prototype had 3GB of RAM? The stock bootloader does update it to 4GB, but the stock bootloader also doesn't even respect the arm64 boot protocol, and doesn't let us change the kernel cmdline, so we don't like using it. > > Anyway, if this works 100% for you, then I am fine with it. Yup, works perfectly! > > It is too late in the cycle for me to pick it up. I will take it > after > the merge window. That's fine with me. > > > > > Best regards, > Krzysztof > Best regards, David
On Sat, 13 Jul 2024 19:58:32 +0200, David Virag wrote: > All known jackpotlte variants have 4GB of RAM, let's use it all. > RAM was set to 3GB from a mistake in the vendor provided DTS file. > > Applied, thanks! [1/1] arm64: dts: exynos: exynos7885-jackpotlte: Correct RAM amount to 4GB https://git.kernel.org/krzk/linux/c/d281814b8f7a710a75258da883fb0dfe1329c031 Best regards,
diff --git a/arch/arm64/boot/dts/exynos/exynos7885-jackpotlte.dts b/arch/arm64/boot/dts/exynos/exynos7885-jackpotlte.dts index ed2925b4715f..0d5c26a197d8 100644 --- a/arch/arm64/boot/dts/exynos/exynos7885-jackpotlte.dts +++ b/arch/arm64/boot/dts/exynos/exynos7885-jackpotlte.dts @@ -57,7 +57,7 @@ memory@80000000 { device_type = "memory"; reg = <0x0 0x80000000 0x3da00000>, <0x0 0xc0000000 0x40000000>, - <0x8 0x80000000 0x40000000>; + <0x8 0x80000000 0x80000000>; }; gpio-keys {
All known jackpotlte variants have 4GB of RAM, let's use it all. RAM was set to 3GB from a mistake in the vendor provided DTS file. Fixes: 06874015327b ("arm64: dts: exynos: Add initial device tree support for Exynos7885 SoC") Signed-off-by: David Virag <virag.david003@gmail.com> --- arch/arm64/boot/dts/exynos/exynos7885-jackpotlte.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)