mbox series

[net-next,v4,00/12] net: dsa: vsc73xx: Implement VLAN operations

Message ID 20240713211620.1125910-1-paweldembicki@gmail.com (mailing list archive)
Headers show
Series net: dsa: vsc73xx: Implement VLAN operations | expand

Message

Pawel Dembicki July 13, 2024, 9:16 p.m. UTC
This patch series is a result of splitting a larger patch series [0],
where some parts was merged before.

The first patch implements port state configuration, which is required
for bridge functionality. STP frames are not forwarded at this moment.
BPDU frames are only forwarded from/to the PI/SI interface.
For more information, see chapter 2.7.1 (CPU Forwarding) in the
datasheet.

Patches 2, 7-9 and 11 provide a basic implementation of tag_8021q
functionality with QinQ support, without VLAN filtering in
the bridge and simple VLAN awareness in VLAN filtering mode.

Patches 3-6 came from Vladimir Oltean. They prepare for making
tag8021q more common. VSC73XX uses very similar tag recognition,
and some code from tag_sja1105 could be moved to tag_8021q for
common use.

Patch 10 is preparation for use tag_8021q bridge functions as generic
implementation of the 'ds->ops->port_bridge_*()'.

Patch 12 is required to avoid problem with learning on standalone ports.

[0] https://patchwork.kernel.org/project/netdevbpf/list/?series=841034&state=%2A&archive=both

Pawel Dembicki (8):
  net: dsa: vsc73xx: add port_stp_state_set function
  net: dsa: vsc73xx: Add vlan filtering
  net: dsa: vsc73xx: introduce tag 8021q for vsc73xx
  net: dsa: vsc73xx: Implement the tag_8021q VLAN operations
  net: dsa: Define max num of bridges in tag8021q implementation
  net: dsa: prepare 'dsa_tag_8021q_bridge_join' for standalone use
  net: dsa: vsc73xx: Add bridge support
  net: dsa: vsc73xx: start treating the BR_LEARNING flag

Vladimir Oltean (4):
  net: dsa: tag_sja1105: absorb logic for not overwriting precise info
    into dsa_8021q_rcv()
  net: dsa: tag_sja1105: absorb entire sja1105_vlan_rcv() into
    dsa_8021q_rcv()
  net: dsa: tag_sja1105: prefer precise source port info on SJA1110 too
  net: dsa: tag_sja1105: refactor skb->dev assignment to
    dsa_tag_8021q_find_user()

 drivers/net/dsa/Kconfig                |   2 +-
 drivers/net/dsa/sja1105/sja1105_main.c |   8 +-
 drivers/net/dsa/vitesse-vsc73xx-core.c | 735 ++++++++++++++++++++++++-
 drivers/net/dsa/vitesse-vsc73xx.h      |  37 ++
 include/linux/dsa/8021q.h              |   8 +-
 include/net/dsa.h                      |   2 +
 net/dsa/Kconfig                        |   6 +
 net/dsa/Makefile                       |   1 +
 net/dsa/tag_8021q.c                    |  84 ++-
 net/dsa/tag_8021q.h                    |   7 +-
 net/dsa/tag_ocelot_8021q.c             |   2 +-
 net/dsa/tag_sja1105.c                  |  72 +--
 net/dsa/tag_vsc73xx_8021q.c            |  68 +++
 13 files changed, 934 insertions(+), 98 deletions(-)
 create mode 100644 net/dsa/tag_vsc73xx_8021q.c

Comments

Vladimir Oltean July 13, 2024, 10:36 p.m. UTC | #1
On Sat, Jul 13, 2024 at 11:16:06PM +0200, Pawel Dembicki wrote:
> This patch series is a result of splitting a larger patch series [0],
> where some parts was merged before.

It is a good day for this driver. Thanks for your perseverence with this.
patchwork-bot+netdevbpf@kernel.org July 15, 2024, 2 p.m. UTC | #2
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sat, 13 Jul 2024 23:16:06 +0200 you wrote:
> This patch series is a result of splitting a larger patch series [0],
> where some parts was merged before.
> 
> The first patch implements port state configuration, which is required
> for bridge functionality. STP frames are not forwarded at this moment.
> BPDU frames are only forwarded from/to the PI/SI interface.
> For more information, see chapter 2.7.1 (CPU Forwarding) in the
> datasheet.
> 
> [...]

Here is the summary with links:
  - [net-next,v4,01/12] net: dsa: vsc73xx: add port_stp_state_set function
    https://git.kernel.org/netdev/net-next/c/1e5b23e50ffb
  - [net-next,v4,02/12] net: dsa: vsc73xx: Add vlan filtering
    https://git.kernel.org/netdev/net-next/c/6b783ded364a
  - [net-next,v4,03/12] net: dsa: tag_sja1105: absorb logic for not overwriting precise info into dsa_8021q_rcv()
    https://git.kernel.org/netdev/net-next/c/dcfe7673787b
  - [net-next,v4,04/12] net: dsa: tag_sja1105: absorb entire sja1105_vlan_rcv() into dsa_8021q_rcv()
    https://git.kernel.org/netdev/net-next/c/0064b863abdc
  - [net-next,v4,05/12] net: dsa: tag_sja1105: prefer precise source port info on SJA1110 too
    https://git.kernel.org/netdev/net-next/c/823e5cc141c6
  - [net-next,v4,06/12] net: dsa: tag_sja1105: refactor skb->dev assignment to dsa_tag_8021q_find_user()
    https://git.kernel.org/netdev/net-next/c/d124cf54df6f
  - [net-next,v4,07/12] net: dsa: vsc73xx: introduce tag 8021q for vsc73xx
    https://git.kernel.org/netdev/net-next/c/6c87e1a47928
  - [net-next,v4,08/12] net: dsa: vsc73xx: Implement the tag_8021q VLAN operations
    https://git.kernel.org/netdev/net-next/c/e3386ec4ec90
  - [net-next,v4,09/12] net: dsa: Define max num of bridges in tag8021q implementation
    https://git.kernel.org/netdev/net-next/c/ce20fdd670ac
  - [net-next,v4,10/12] net: dsa: prepare 'dsa_tag_8021q_bridge_join' for standalone use
    https://git.kernel.org/netdev/net-next/c/85aabd1fe9d6
  - [net-next,v4,11/12] net: dsa: vsc73xx: Add bridge support
    https://git.kernel.org/netdev/net-next/c/6dfaaa276337
  - [net-next,v4,12/12] net: dsa: vsc73xx: start treating the BR_LEARNING flag
    https://git.kernel.org/netdev/net-next/c/259a7061c2f1

You are awesome, thank you!
Pawel Dembicki July 16, 2024, 5:47 p.m. UTC | #3
niedz., 14 lip 2024 o 00:36 Vladimir Oltean <olteanv@gmail.com> napisał(a):
>
> On Sat, Jul 13, 2024 at 11:16:06PM +0200, Pawel Dembicki wrote:
> > This patch series is a result of splitting a larger patch series [0],
> > where some parts was merged before.
>
> It is a good day for this driver. Thanks for your perseverence with this.

It's a small step for the kernel but a big one for me. I'm glad that
we managed to finalize this series of patches. I want to thank
everyone for their help and the many valuable lessons. Especially you,
Vladimir, for your immense patience and willingness to help.