| Message ID | 20240703-clk-const-regmap-v1-2-7d15a0671d6f@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | clk: constify struct regmap_config | expand |
On 03/07/2024 11:50, Javier Carrasco wrote: > `a1_pll_regmap_cfg` is not modified and can be declared as const to > move its data to a read-only section. > > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> > --- > drivers/clk/meson/a1-pll.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/meson/a1-pll.c b/drivers/clk/meson/a1-pll.c > index a16e537d139a..4d0a6305b07f 100644 > --- a/drivers/clk/meson/a1-pll.c > +++ b/drivers/clk/meson/a1-pll.c > @@ -295,7 +295,7 @@ static struct clk_regmap *const a1_pll_regmaps[] = { > &hifi_pll, > }; > > -static struct regmap_config a1_pll_regmap_cfg = { > +static const struct regmap_config a1_pll_regmap_cfg = { > .reg_bits = 32, > .val_bits = 32, > .reg_stride = 4, > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
On Wed, Jul 03, 2024 at 11:50:15AM +0200, Javier Carrasco wrote: > `a1_pll_regmap_cfg` is not modified and can be declared as const to > move its data to a read-only section. > > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> Reviewed-by: Dmitry Rokosov <ddrokosov@salutedevices.com> > --- > drivers/clk/meson/a1-pll.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/meson/a1-pll.c b/drivers/clk/meson/a1-pll.c > index a16e537d139a..4d0a6305b07f 100644 > --- a/drivers/clk/meson/a1-pll.c > +++ b/drivers/clk/meson/a1-pll.c > @@ -295,7 +295,7 @@ static struct clk_regmap *const a1_pll_regmaps[] = { > &hifi_pll, > }; > > -static struct regmap_config a1_pll_regmap_cfg = { > +static const struct regmap_config a1_pll_regmap_cfg = { > .reg_bits = 32, > .val_bits = 32, > .reg_stride = 4, > > -- > 2.40.1 > > > _______________________________________________ > linux-amlogic mailing list > linux-amlogic@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-amlogic
diff --git a/drivers/clk/meson/a1-pll.c b/drivers/clk/meson/a1-pll.c index a16e537d139a..4d0a6305b07f 100644 --- a/drivers/clk/meson/a1-pll.c +++ b/drivers/clk/meson/a1-pll.c @@ -295,7 +295,7 @@ static struct clk_regmap *const a1_pll_regmaps[] = { &hifi_pll, }; -static struct regmap_config a1_pll_regmap_cfg = { +static const struct regmap_config a1_pll_regmap_cfg = { .reg_bits = 32, .val_bits = 32, .reg_stride = 4,
`a1_pll_regmap_cfg` is not modified and can be declared as const to move its data to a read-only section. Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> --- drivers/clk/meson/a1-pll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)