diff mbox series

pktgen: Use seq_putc() in pktgen_if_show()

Message ID cc21bbb8-e6d3-4670-9d39-f5db0f27f8ce@web.de (mailing list archive)
State Deferred
Delegated to: Netdev Maintainers
Headers show
Series pktgen: Use seq_putc() in pktgen_if_show() | expand

Checks

Context Check Description
netdev/series_format warning Single patches do not need cover letters; Target tree name not specified in the subject
netdev/tree_selection success Guessed tree name to be net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 816 this patch: 816
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 5 of 5 maintainers
netdev/build_clang success Errors and warnings before: 821 this patch: 821
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 821 this patch: 821
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 24 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-07-15--06-00 (tests: 695)

Commit Message

Markus Elfring July 14, 2024, 6:34 p.m. UTC 
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 14 Jul 2024 20:23:49 +0200

Single line breaks should be put into a sequence.
Thus use the corresponding function “seq_putc”.

This issue was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 net/core/pktgen.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--
2.45.2

Comments

Jiri Pirko July 16, 2024, 1:29 p.m. UTC | #1 
Sun, Jul 14, 2024 at 08:34:14PM CEST, Markus.Elfring@web.de wrote:
>From: Markus Elfring <elfring@users.sourceforge.net>
>Date: Sun, 14 Jul 2024 20:23:49 +0200
>
>Single line breaks should be put into a sequence.
>Thus use the corresponding function “seq_putc”.
>
>This issue was transformed by using the Coccinelle software.
>
>Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Reviewed-by: Jiri Pirko <jiri@nvidia.com>
diff mbox series

Patch

diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index ea55a758a475..441e058d6726 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -577,7 +577,7 @@  static int pktgen_if_show(struct seq_file *seq, void *v)
 				   pkt_dev->imix_entries[i].size,
 				   pkt_dev->imix_entries[i].weight);
 		}
-		seq_puts(seq, "\n");
+		seq_putc(seq, '\n');
 	}

 	seq_printf(seq,
@@ -685,7 +685,7 @@  static int pktgen_if_show(struct seq_file *seq, void *v)
 		}
 	}

-	seq_puts(seq, "\n");
+	seq_putc(seq, '\n');

 	/* not really stopped, more like last-running-at */
 	stopped = pkt_dev->running ? ktime_get() : pkt_dev->stopped_at;
@@ -706,7 +706,7 @@  static int pktgen_if_show(struct seq_file *seq, void *v)
 				   pkt_dev->imix_entries[i].size,
 				   pkt_dev->imix_entries[i].count_so_far);
 		}
-		seq_puts(seq, "\n");
+		seq_putc(seq, '\n');
 	}

 	seq_printf(seq,