| Message ID | 20240715024457.3743560-1-nichen@iscas.ac.cn (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: bridge: remove unnecessary cast from netdev_priv() | expand |
On 15/07/2024 05:44, Chen Ni wrote: > Remove unnecessary cast of void * returned by netdev_priv(). > > Fixes: 928990631327 ("net: bridge: add notifications for the bridge dev on vlan change") > Signed-off-by: Chen Ni <nichen@iscas.ac.cn> > --- > net/bridge/br_netlink.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c This is not a fix, the code isn't broken and it doesn't violate anything. Nacked-by: Nikolay Aleksandrov <razor@blackwall.org>
Mon, Jul 15, 2024 at 10:04:26AM CEST, razor@blackwall.org wrote: >On 15/07/2024 05:44, Chen Ni wrote: >> Remove unnecessary cast of void * returned by netdev_priv(). >> >> Fixes: 928990631327 ("net: bridge: add notifications for the bridge dev on vlan change") >> Signed-off-by: Chen Ni <nichen@iscas.ac.cn> >> --- >> net/bridge/br_netlink.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c >This is not a fix, the code isn't broken and it doesn't violate >anything. Yeah, it's cosmetics, send it to net-next without "Fixes" tag. > >Nacked-by: Nikolay Aleksandrov <razor@blackwall.org> > >
diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c index f17dbac7d828..d02cc1497281 100644 --- a/net/bridge/br_netlink.c +++ b/net/bridge/br_netlink.c @@ -1085,7 +1085,7 @@ static int br_setport(struct net_bridge_port *p, struct nlattr *tb[], int br_setlink(struct net_device *dev, struct nlmsghdr *nlh, u16 flags, struct netlink_ext_ack *extack) { - struct net_bridge *br = (struct net_bridge *)netdev_priv(dev); + struct net_bridge *br = netdev_priv(dev); struct nlattr *tb[IFLA_BRPORT_MAX + 1]; struct net_bridge_port *p; struct nlattr *protinfo; @@ -1143,7 +1143,7 @@ int br_setlink(struct net_device *dev, struct nlmsghdr *nlh, u16 flags, /* Delete port information */ int br_dellink(struct net_device *dev, struct nlmsghdr *nlh, u16 flags) { - struct net_bridge *br = (struct net_bridge *)netdev_priv(dev); + struct net_bridge *br = netdev_priv(dev); struct net_bridge_port *p; struct nlattr *afspec; bool changed = false;
Remove unnecessary cast of void * returned by netdev_priv(). Fixes: 928990631327 ("net: bridge: add notifications for the bridge dev on vlan change") Signed-off-by: Chen Ni <nichen@iscas.ac.cn> --- net/bridge/br_netlink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)