| Message ID | 20240715073604.30307-2-xni@redhat.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
| Series | mdadm: fix coverity issues | expand |
| Context | Check | Description |
|---|---|---|
| mdraidci/vmtest-md-6_11-PR | fail | merge-conflict |
On Mon, 15 Jul 2024 15:35:50 +0800 Xiao Ni <xni@redhat.com> wrote: > This patch fixes a regression issue which is checked by 01r1fail case. > > Fixes: 1b4b73fd535a ('mdadm: Manage.c fix coverity issues') > Signed-off-by: Xiao Ni <xni@redhat.com> > --- > Manage.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Manage.c b/Manage.c > index aa5e80b2805d..f0304e1e4d3d 100644 > --- a/Manage.c > +++ b/Manage.c > @@ -1333,7 +1333,7 @@ bool is_remove_safe(mdu_array_info_t *array, const int > fd, char *devname, const > char *avail = xcalloc(array->raid_disks, sizeof(char)); > > - for (disk = mdi->devs; disk; disk = mdi->next) { > + for (disk = mdi->devs; disk; disk = disk->next) { > if (disk->disk.raid_disk < 0) > continue; > if (!(disk->disk.state & (1 << MD_DISK_SYNC))) Hi Xiao, I didn't looked into your serie and I fixed it myself today. I will skip this patch then. Thanks, Mariusz
diff --git a/Manage.c b/Manage.c index aa5e80b2805d..f0304e1e4d3d 100644 --- a/Manage.c +++ b/Manage.c @@ -1333,7 +1333,7 @@ bool is_remove_safe(mdu_array_info_t *array, const int fd, char *devname, const char *avail = xcalloc(array->raid_disks, sizeof(char)); - for (disk = mdi->devs; disk; disk = mdi->next) { + for (disk = mdi->devs; disk; disk = disk->next) { if (disk->disk.raid_disk < 0) continue; if (!(disk->disk.state & (1 << MD_DISK_SYNC)))
This patch fixes a regression issue which is checked by 01r1fail case. Fixes: 1b4b73fd535a ('mdadm: Manage.c fix coverity issues') Signed-off-by: Xiao Ni <xni@redhat.com> --- Manage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)