| Message ID | 20240717072706.1821584-1-nichen@iscas.ac.cn (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | dmaengine: pl330: Handle the return value of pl330_resume | expand |
On Wed, 17 Jul 2024 at 09:29, Chen Ni <nichen@iscas.ac.cn> wrote: > > As pm_runtime_force_resume() can return error numbers, it should be > better to check the return value and deal with the exception. > > Fixes: a39cddc9e377 ("dmaengine: pl330: Drop boilerplate code for suspend/resume") > Signed-off-by: Chen Ni <nichen@iscas.ac.cn> Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org> Kind regards Uffe > --- > drivers/dma/pl330.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c > index 60c4de8dac1d..624ab4eee156 100644 > --- a/drivers/dma/pl330.c > +++ b/drivers/dma/pl330.c > @@ -2993,9 +2993,7 @@ static int __maybe_unused pl330_resume(struct device *dev) > if (ret) > return ret; > > - pm_runtime_force_resume(dev); > - > - return ret; > + return pm_runtime_force_resume(dev); > } > > static const struct dev_pm_ops pl330_pm = { > -- > 2.25.1 > >
> As pm_runtime_force_resume() can return error numbers, it should be > better to check the return value and deal with the exception. Please improve such a change description with an imperative wording. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10#n94 How do you think about to use a summary phrase like “Return value from a pm_runtime_force_resume() call in pl330_resume()”? Regards, Markus
> > As pm_runtime_force_resume() can return error numbers, it should be > > better to check the return value and deal with the exception. … > Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org> Is there a need to complete the exception handling with a clk_unprepare() call? Regards, Markus
diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c index 60c4de8dac1d..624ab4eee156 100644 --- a/drivers/dma/pl330.c +++ b/drivers/dma/pl330.c @@ -2993,9 +2993,7 @@ static int __maybe_unused pl330_resume(struct device *dev) if (ret) return ret; - pm_runtime_force_resume(dev); - - return ret; + return pm_runtime_force_resume(dev); } static const struct dev_pm_ops pl330_pm = {
As pm_runtime_force_resume() can return error numbers, it should be better to check the return value and deal with the exception. Fixes: a39cddc9e377 ("dmaengine: pl330: Drop boilerplate code for suspend/resume") Signed-off-by: Chen Ni <nichen@iscas.ac.cn> --- drivers/dma/pl330.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)