| Message ID | 20240717-dispcc-sm8550-fixes-v2-1-5c4a3128c40b@linaro.org (mailing list archive) |
|---|---|
| State | Awaiting Upstream, archived |
| Headers | show |
| Series | clk: qcom: merge SM8550 and SM8650 display clock controller drivers | expand |
On 17/07/2024 12:04, Dmitry Baryshkov wrote: > Fix seveal odd-looking places in SM8550's dispcc driver: > > - duplicate entries in disp_cc_parent_map_4 and disp_cc_parent_map_5 > - using &disp_cc_mdss_dptx0_link_div_clk_src as a source for > disp_cc_mdss_dptx1_usb_router_link_intf_clk > > The SM8650 driver has been used as a reference. > > Fixes: 90114ca11476 ("clk: qcom: add SM8550 DISPCC driver") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/clk/qcom/dispcc-sm8550.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/qcom/dispcc-sm8550.c b/drivers/clk/qcom/dispcc-sm8550.c > index 31ae46f180a5..954b0f6fcea2 100644 > --- a/drivers/clk/qcom/dispcc-sm8550.c > +++ b/drivers/clk/qcom/dispcc-sm8550.c > @@ -196,7 +196,7 @@ static const struct clk_parent_data disp_cc_parent_data_3[] = { > static const struct parent_map disp_cc_parent_map_4[] = { > { P_BI_TCXO, 0 }, > { P_DP0_PHY_PLL_LINK_CLK, 1 }, > - { P_DP1_PHY_PLL_VCO_DIV_CLK, 2 }, > + { P_DP0_PHY_PLL_VCO_DIV_CLK, 2 }, > { P_DP3_PHY_PLL_VCO_DIV_CLK, 3 }, > { P_DP1_PHY_PLL_VCO_DIV_CLK, 4 }, > { P_DP2_PHY_PLL_VCO_DIV_CLK, 6 }, > @@ -213,7 +213,7 @@ static const struct clk_parent_data disp_cc_parent_data_4[] = { > > static const struct parent_map disp_cc_parent_map_5[] = { > { P_BI_TCXO, 0 }, > - { P_DSI0_PHY_PLL_OUT_BYTECLK, 4 }, > + { P_DSI0_PHY_PLL_OUT_BYTECLK, 2 }, > { P_DSI1_PHY_PLL_OUT_BYTECLK, 4 }, > }; > > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
diff --git a/drivers/clk/qcom/dispcc-sm8550.c b/drivers/clk/qcom/dispcc-sm8550.c index 31ae46f180a5..954b0f6fcea2 100644 --- a/drivers/clk/qcom/dispcc-sm8550.c +++ b/drivers/clk/qcom/dispcc-sm8550.c @@ -196,7 +196,7 @@ static const struct clk_parent_data disp_cc_parent_data_3[] = { static const struct parent_map disp_cc_parent_map_4[] = { { P_BI_TCXO, 0 }, { P_DP0_PHY_PLL_LINK_CLK, 1 }, - { P_DP1_PHY_PLL_VCO_DIV_CLK, 2 }, + { P_DP0_PHY_PLL_VCO_DIV_CLK, 2 }, { P_DP3_PHY_PLL_VCO_DIV_CLK, 3 }, { P_DP1_PHY_PLL_VCO_DIV_CLK, 4 }, { P_DP2_PHY_PLL_VCO_DIV_CLK, 6 }, @@ -213,7 +213,7 @@ static const struct clk_parent_data disp_cc_parent_data_4[] = { static const struct parent_map disp_cc_parent_map_5[] = { { P_BI_TCXO, 0 }, - { P_DSI0_PHY_PLL_OUT_BYTECLK, 4 }, + { P_DSI0_PHY_PLL_OUT_BYTECLK, 2 }, { P_DSI1_PHY_PLL_OUT_BYTECLK, 4 }, };
Fix seveal odd-looking places in SM8550's dispcc driver: - duplicate entries in disp_cc_parent_map_4 and disp_cc_parent_map_5 - using &disp_cc_mdss_dptx0_link_div_clk_src as a source for disp_cc_mdss_dptx1_usb_router_link_intf_clk The SM8650 driver has been used as a reference. Fixes: 90114ca11476 ("clk: qcom: add SM8550 DISPCC driver") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/clk/qcom/dispcc-sm8550.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)