diff mbox series

[bpf-next] bpf: kprobe: remove unused declaring of bpf_kprobe_override

Message ID 20240710085939.11520-1-dongml2@chinatelecom.cn (mailing list archive)
State Not Applicable
Delegated to: BPF
Headers show
Series [bpf-next] bpf: kprobe: remove unused declaring of bpf_kprobe_override | expand

Checks

Context Check Description
bpf/vmtest-bpf-next-PR success PR summary
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for bpf-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 929 this patch: 929
netdev/build_tools success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers success CCed 5 of 5 maintainers
netdev/build_clang success Errors and warnings before: 926 this patch: 926
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 2291 this patch: 2291
netdev/checkpatch warning WARNING: From:/Signed-off-by: email address mismatch: 'From: Menglong Dong <menglong8.dong@gmail.com>' != 'Signed-off-by: Menglong Dong <dongml2@chinatelecom.cn>'
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 1 this patch: 1
netdev/source_inline success Was 0 now: 0
bpf/vmtest-bpf-next-VM_Test-39 success Logs for x86_64-llvm-18 / test (test_progs_cpuv4, false, 360) / test_progs_cpuv4 on x86_64 with llvm-18
bpf/vmtest-bpf-next-VM_Test-38 success Logs for x86_64-llvm-18 / test (test_progs, false, 360) / test_progs on x86_64 with llvm-18
bpf/vmtest-bpf-next-VM_Test-40 success Logs for x86_64-llvm-18 / test (test_progs_no_alu32, false, 360) / test_progs_no_alu32 on x86_64 with llvm-18
bpf/vmtest-bpf-next-VM_Test-8 fail Logs for aarch64-gcc / test (test_progs_no_alu32, false, 360) / test_progs_no_alu32 on aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-7 fail Logs for aarch64-gcc / test (test_progs, false, 360) / test_progs on aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-2 success Logs for Unittests
bpf/vmtest-bpf-next-VM_Test-18 success Logs for set-matrix
bpf/vmtest-bpf-next-VM_Test-0 success Logs for Lint
bpf/vmtest-bpf-next-VM_Test-3 success Logs for Validate matrix.py
bpf/vmtest-bpf-next-VM_Test-17 success Logs for s390x-gcc / veristat
bpf/vmtest-bpf-next-VM_Test-10 success Logs for aarch64-gcc / veristat
bpf/vmtest-bpf-next-VM_Test-1 success Logs for ShellCheck
bpf/vmtest-bpf-next-VM_Test-29 success Logs for x86_64-llvm-17 / build-release / build for x86_64 with llvm-17-O2
bpf/vmtest-bpf-next-VM_Test-36 success Logs for x86_64-llvm-18 / build-release / build for x86_64 with llvm-18-O2
bpf/vmtest-bpf-next-VM_Test-42 success Logs for x86_64-llvm-18 / veristat
bpf/vmtest-bpf-next-VM_Test-5 success Logs for aarch64-gcc / build-release
bpf/vmtest-bpf-next-VM_Test-11 success Logs for s390x-gcc / build / build for s390x with gcc
bpf/vmtest-bpf-next-VM_Test-4 success Logs for aarch64-gcc / build / build for aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-20 success Logs for x86_64-gcc / build-release
bpf/vmtest-bpf-next-VM_Test-12 success Logs for s390x-gcc / build-release
bpf/vmtest-bpf-next-VM_Test-35 success Logs for x86_64-llvm-18 / build / build for x86_64 with llvm-18
bpf/vmtest-bpf-next-VM_Test-28 success Logs for x86_64-llvm-17 / build / build for x86_64 with llvm-17
bpf/vmtest-bpf-next-VM_Test-19 success Logs for x86_64-gcc / build / build for x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-34 success Logs for x86_64-llvm-17 / veristat
bpf/vmtest-bpf-next-VM_Test-9 success Logs for aarch64-gcc / test (test_verifier, false, 360) / test_verifier on aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-6 success Logs for aarch64-gcc / test (test_maps, false, 360) / test_maps on aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-14 success Logs for s390x-gcc / test (test_progs, false, 360) / test_progs on s390x with gcc
bpf/vmtest-bpf-next-VM_Test-13 fail Logs for s390x-gcc / test (test_maps, false, 360) / test_maps on s390x with gcc
bpf/vmtest-bpf-next-VM_Test-15 success Logs for s390x-gcc / test (test_progs_no_alu32, false, 360) / test_progs_no_alu32 on s390x with gcc
bpf/vmtest-bpf-next-VM_Test-21 success Logs for x86_64-gcc / test (test_maps, false, 360) / test_maps on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-22 success Logs for x86_64-gcc / test (test_progs, false, 360) / test_progs on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-24 success Logs for x86_64-gcc / test (test_progs_no_alu32_parallel, true, 30) / test_progs_no_alu32_parallel on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-23 success Logs for x86_64-gcc / test (test_progs_no_alu32, false, 360) / test_progs_no_alu32 on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-25 success Logs for x86_64-gcc / test (test_progs_parallel, true, 30) / test_progs_parallel on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-16 success Logs for s390x-gcc / test (test_verifier, false, 360) / test_verifier on s390x with gcc
bpf/vmtest-bpf-next-VM_Test-31 success Logs for x86_64-llvm-17 / test (test_progs, false, 360) / test_progs on x86_64 with llvm-17
bpf/vmtest-bpf-next-VM_Test-33 success Logs for x86_64-llvm-17 / test (test_verifier, false, 360) / test_verifier on x86_64 with llvm-17
bpf/vmtest-bpf-next-VM_Test-26 success Logs for x86_64-gcc / test (test_verifier, false, 360) / test_verifier on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-32 success Logs for x86_64-llvm-17 / test (test_progs_no_alu32, false, 360) / test_progs_no_alu32 on x86_64 with llvm-17
bpf/vmtest-bpf-next-VM_Test-27 success Logs for x86_64-gcc / veristat / veristat on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-37 success Logs for x86_64-llvm-18 / test (test_maps, false, 360) / test_maps on x86_64 with llvm-18
bpf/vmtest-bpf-next-VM_Test-30 success Logs for x86_64-llvm-17 / test (test_maps, false, 360) / test_maps on x86_64 with llvm-17
bpf/vmtest-bpf-next-VM_Test-41 success Logs for x86_64-llvm-18 / test (test_verifier, false, 360) / test_verifier on x86_64 with llvm-18

Commit Message

Menglong Dong July 10, 2024, 8:59 a.m. UTC 
After the commit 66665ad2f102 ("tracing/kprobe: bpf: Compare instruction
pointer with original one"), "bpf_kprobe_override" is not used anywhere
anymore, and we can remove it now.

Signed-off-by: Menglong Dong <dongml2@chinatelecom.cn>
---
 include/linux/trace_events.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Jiri Olsa July 10, 2024, 1:13 p.m. UTC | #1 
On Wed, Jul 10, 2024 at 04:59:39PM +0800, Menglong Dong wrote:
> After the commit 66665ad2f102 ("tracing/kprobe: bpf: Compare instruction

should be in Fixes: tag probably ?

> pointer with original one"), "bpf_kprobe_override" is not used anywhere
> anymore, and we can remove it now.
> 
> Signed-off-by: Menglong Dong <dongml2@chinatelecom.cn>

lgtm, cc-ing Masami

Acked-by: Jiri Olsa <jolsa@kernel.org>

jirka

> ---
>  include/linux/trace_events.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/linux/trace_events.h b/include/linux/trace_events.h
> index 9df3e2973626..9435185c10ef 100644
> --- a/include/linux/trace_events.h
> +++ b/include/linux/trace_events.h
> @@ -880,7 +880,6 @@ do {									\
>  struct perf_event;
>  
>  DECLARE_PER_CPU(struct pt_regs, perf_trace_regs);
> -DECLARE_PER_CPU(int, bpf_kprobe_override);
>  
>  extern int  perf_trace_init(struct perf_event *event);
>  extern void perf_trace_destroy(struct perf_event *event);
> -- 
> 2.39.2
> 
>
Masami Hiramatsu (Google) July 10, 2024, 2:18 p.m. UTC | #2 
On Wed, 10 Jul 2024 15:13:07 +0200
Jiri Olsa <olsajiri@gmail.com> wrote:

> On Wed, Jul 10, 2024 at 04:59:39PM +0800, Menglong Dong wrote:
> > After the commit 66665ad2f102 ("tracing/kprobe: bpf: Compare instruction
> 
> should be in Fixes: tag probably ?

Yes, I'll add a Fixed tag.

> 
> > pointer with original one"), "bpf_kprobe_override" is not used anywhere
> > anymore, and we can remove it now.
> > 
> > Signed-off-by: Menglong Dong <dongml2@chinatelecom.cn>
> 
> lgtm, cc-ing Masami
> 
> Acked-by: Jiri Olsa <jolsa@kernel.org>

Thanks!

> 
> jirka
> 
> > ---
> >  include/linux/trace_events.h | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/include/linux/trace_events.h b/include/linux/trace_events.h
> > index 9df3e2973626..9435185c10ef 100644
> > --- a/include/linux/trace_events.h
> > +++ b/include/linux/trace_events.h
> > @@ -880,7 +880,6 @@ do {									\
> >  struct perf_event;
> >  
> >  DECLARE_PER_CPU(struct pt_regs, perf_trace_regs);
> > -DECLARE_PER_CPU(int, bpf_kprobe_override);
> >  
> >  extern int  perf_trace_init(struct perf_event *event);
> >  extern void perf_trace_destroy(struct perf_event *event);
> > -- 
> > 2.39.2
> > 
> >
Menglong Dong July 18, 2024, 1:32 a.m. UTC | #3 
On Wed, Jul 10, 2024 at 10:18 PM Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> On Wed, 10 Jul 2024 15:13:07 +0200
> Jiri Olsa <olsajiri@gmail.com> wrote:
>
> > On Wed, Jul 10, 2024 at 04:59:39PM +0800, Menglong Dong wrote:
> > > After the commit 66665ad2f102 ("tracing/kprobe: bpf: Compare instruction
> >
> > should be in Fixes: tag probably ?
>
> Yes, I'll add a Fixed tag.
>

Hello!

Should I send a v2 with the "Fixes" tag? It seems that this commit has
been pending for a while.

Thanks!
Menglong Dong

> >
> > > pointer with original one"), "bpf_kprobe_override" is not used anywhere
> > > anymore, and we can remove it now.
> > >
> > > Signed-off-by: Menglong Dong <dongml2@chinatelecom.cn>
> >
> > lgtm, cc-ing Masami
> >
> > Acked-by: Jiri Olsa <jolsa@kernel.org>
>
> Thanks!
>
> >
> > jirka
> >
> > > ---
> > >  include/linux/trace_events.h | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/include/linux/trace_events.h b/include/linux/trace_events.h
> > > index 9df3e2973626..9435185c10ef 100644
> > > --- a/include/linux/trace_events.h
> > > +++ b/include/linux/trace_events.h
> > > @@ -880,7 +880,6 @@ do {                                                                    \
> > >  struct perf_event;
> > >
> > >  DECLARE_PER_CPU(struct pt_regs, perf_trace_regs);
> > > -DECLARE_PER_CPU(int, bpf_kprobe_override);
> > >
> > >  extern int  perf_trace_init(struct perf_event *event);
> > >  extern void perf_trace_destroy(struct perf_event *event);
> > > --
> > > 2.39.2
> > >
> > >
>
>
> --
> Masami Hiramatsu (Google) <mhiramat@kernel.org>
Masami Hiramatsu (Google) July 18, 2024, 2:51 p.m. UTC | #4 
Hi,

On Thu, 18 Jul 2024 09:32:13 +0800
Menglong Dong <menglong8.dong@gmail.com> wrote:

> On Wed, Jul 10, 2024 at 10:18 PM Masami Hiramatsu <mhiramat@kernel.org> wrote:
> >
> > On Wed, 10 Jul 2024 15:13:07 +0200
> > Jiri Olsa <olsajiri@gmail.com> wrote:
> >
> > > On Wed, Jul 10, 2024 at 04:59:39PM +0800, Menglong Dong wrote:
> > > > After the commit 66665ad2f102 ("tracing/kprobe: bpf: Compare instruction
> > >
> > > should be in Fixes: tag probably ?
> >
> > Yes, I'll add a Fixed tag.
> >
> 
> Hello!
> 
> Should I send a v2 with the "Fixes" tag? It seems that this commit has
> been pending for a while.

No problem, but wait a bit. I need to send this to 6.11-rc1.

Thank you,


> 
> Thanks!
> Menglong Dong
> 
> > >
> > > > pointer with original one"), "bpf_kprobe_override" is not used anywhere
> > > > anymore, and we can remove it now.
> > > >
> > > > Signed-off-by: Menglong Dong <dongml2@chinatelecom.cn>
> > >
> > > lgtm, cc-ing Masami
> > >
> > > Acked-by: Jiri Olsa <jolsa@kernel.org>
> >
> > Thanks!
> >
> > >
> > > jirka
> > >
> > > > ---
> > > >  include/linux/trace_events.h | 1 -
> > > >  1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/include/linux/trace_events.h b/include/linux/trace_events.h
> > > > index 9df3e2973626..9435185c10ef 100644
> > > > --- a/include/linux/trace_events.h
> > > > +++ b/include/linux/trace_events.h
> > > > @@ -880,7 +880,6 @@ do {                                                                    \
> > > >  struct perf_event;
> > > >
> > > >  DECLARE_PER_CPU(struct pt_regs, perf_trace_regs);
> > > > -DECLARE_PER_CPU(int, bpf_kprobe_override);
> > > >
> > > >  extern int  perf_trace_init(struct perf_event *event);
> > > >  extern void perf_trace_destroy(struct perf_event *event);
> > > > --
> > > > 2.39.2
> > > >
> > > >
> >
> >
> > --
> > Masami Hiramatsu (Google) <mhiramat@kernel.org>
diff mbox series

Patch

diff --git a/include/linux/trace_events.h b/include/linux/trace_events.h
index 9df3e2973626..9435185c10ef 100644
--- a/include/linux/trace_events.h
+++ b/include/linux/trace_events.h
@@ -880,7 +880,6 @@  do {									\
 struct perf_event;
 
 DECLARE_PER_CPU(struct pt_regs, perf_trace_regs);
-DECLARE_PER_CPU(int, bpf_kprobe_override);
 
 extern int  perf_trace_init(struct perf_event *event);
 extern void perf_trace_destroy(struct perf_event *event);