| Message ID | 20240718165959.3983-1-dakr@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Nouveau fixes for TTM refcount rework | expand |
On 19/7/24 02:58, Danilo Krummrich wrote: > Hi Christian, > > Those three patches should unblock your series to use GEM references instead of > TTM ones. > > @Lyude, Dave: Can you please double check? Hi Danilo, These look fine to me, and appear to resolve the issues I see with just the refcount series applied. Ben. Reviewed-by: Ben Skeggs <bskeggs@nvidia.com> > > - Danilo > > Danilo Krummrich (3): > drm/nouveau: prime: fix refcount underflow > drm/nouveau: bo: remove unused functions > drm/nouveau: use GEM references instead of TTMs > > drivers/gpu/drm/nouveau/dispnv04/crtc.c | 43 +++++++++++++++------ > drivers/gpu/drm/nouveau/dispnv50/disp.c | 4 +- > drivers/gpu/drm/nouveau/nouveau_bo.h | 50 ++----------------------- > drivers/gpu/drm/nouveau/nouveau_chan.c | 2 +- > drivers/gpu/drm/nouveau/nouveau_dmem.c | 4 +- > drivers/gpu/drm/nouveau/nouveau_prime.c | 3 +- > drivers/gpu/drm/nouveau/nv10_fence.c | 2 +- > drivers/gpu/drm/nouveau/nv17_fence.c | 2 +- > drivers/gpu/drm/nouveau/nv50_fence.c | 2 +- > drivers/gpu/drm/nouveau/nv84_fence.c | 4 +- > 10 files changed, 46 insertions(+), 70 deletions(-) > > > base-commit: 99e0fb8b087120b5a7019f1cff6c5c2b5b925ae5
On 7/18/24 7:53 AM, Ben Skeggs wrote: > On 19/7/24 02:58, Danilo Krummrich wrote: > >> Hi Christian, >> >> Those three patches should unblock your series to use GEM references instead of >> TTM ones. >> >> @Lyude, Dave: Can you please double check? > > Hi Danilo, > > These look fine to me, and appear to resolve the issues I see with just the refcount series applied. > > Ben. > > > Reviewed-by: Ben Skeggs <bskeggs@nvidia.com> Thanks for reviewing! @Christian, I applied the series to drm-misc-next for you to go ahead and cherry-picked the bug fix to drm-misc-fixes. - Danilo > >> >> - Danilo >> >> Danilo Krummrich (3): >> drm/nouveau: prime: fix refcount underflow >> drm/nouveau: bo: remove unused functions >> drm/nouveau: use GEM references instead of TTMs >> >> drivers/gpu/drm/nouveau/dispnv04/crtc.c | 43 +++++++++++++++------ >> drivers/gpu/drm/nouveau/dispnv50/disp.c | 4 +- >> drivers/gpu/drm/nouveau/nouveau_bo.h | 50 ++----------------------- >> drivers/gpu/drm/nouveau/nouveau_chan.c | 2 +- >> drivers/gpu/drm/nouveau/nouveau_dmem.c | 4 +- >> drivers/gpu/drm/nouveau/nouveau_prime.c | 3 +- >> drivers/gpu/drm/nouveau/nv10_fence.c | 2 +- >> drivers/gpu/drm/nouveau/nv17_fence.c | 2 +- >> drivers/gpu/drm/nouveau/nv50_fence.c | 2 +- >> drivers/gpu/drm/nouveau/nv84_fence.c | 4 +- >> 10 files changed, 46 insertions(+), 70 deletions(-) >> >> >> base-commit: 99e0fb8b087120b5a7019f1cff6c5c2b5b925ae5
Am 22.07.24 um 23:01 schrieb Danilo Krummrich: > On 7/18/24 7:53 AM, Ben Skeggs wrote: >> On 19/7/24 02:58, Danilo Krummrich wrote: >> >>> Hi Christian, >>> >>> Those three patches should unblock your series to use GEM references >>> instead of >>> TTM ones. >>> >>> @Lyude, Dave: Can you please double check? >> >> Hi Danilo, >> >> These look fine to me, and appear to resolve the issues I see with >> just the refcount series applied. >> >> Ben. >> >> >> Reviewed-by: Ben Skeggs <bskeggs@nvidia.com> > > Thanks for reviewing! > > @Christian, I applied the series to drm-misc-next for you to go ahead and > cherry-picked the bug fix to drm-misc-fixes. Thanks, I was already about to re-base my stuff on it. Going to send out a new series today. Christian. > > - Danilo > >> >>> >>> - Danilo >>> >>> Danilo Krummrich (3): >>> drm/nouveau: prime: fix refcount underflow >>> drm/nouveau: bo: remove unused functions >>> drm/nouveau: use GEM references instead of TTMs >>> >>> drivers/gpu/drm/nouveau/dispnv04/crtc.c | 43 +++++++++++++++------ >>> drivers/gpu/drm/nouveau/dispnv50/disp.c | 4 +- >>> drivers/gpu/drm/nouveau/nouveau_bo.h | 50 >>> ++----------------------- >>> drivers/gpu/drm/nouveau/nouveau_chan.c | 2 +- >>> drivers/gpu/drm/nouveau/nouveau_dmem.c | 4 +- >>> drivers/gpu/drm/nouveau/nouveau_prime.c | 3 +- >>> drivers/gpu/drm/nouveau/nv10_fence.c | 2 +- >>> drivers/gpu/drm/nouveau/nv17_fence.c | 2 +- >>> drivers/gpu/drm/nouveau/nv50_fence.c | 2 +- >>> drivers/gpu/drm/nouveau/nv84_fence.c | 4 +- >>> 10 files changed, 46 insertions(+), 70 deletions(-) >>> >>> >>> base-commit: 99e0fb8b087120b5a7019f1cff6c5c2b5b925ae5