| Message ID | 20240718105718.11562-1-srinuvasan.a@siemens.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [isar-cip-core] classes/squashfs: exclude boot dir during squshfs image creation | expand |
On 18.07.24 12:57, srinuvasan.a@siemens.com wrote: > From: Srinuvasan A <srinuvasan.a@siemens.com> > > For all the UEFI based bsps we used bootloader as efi bootguard, this > linux.efi contains necessary boot files to boot the system, hence remove > the boot content from squash root filesystem. > I can understand the goal, but the squashfs class is not logically coupled with UEFI booting. I suspect we need a better place to add "boo" to SQUASHFS_EXCLUDE_DIRS, a place where it is clear what the class is packaging. Jan > Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com> > --- > classes/squashfs.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/classes/squashfs.bbclass b/classes/squashfs.bbclass > index b39be0c..f9c7bf4 100644 > --- a/classes/squashfs.bbclass > +++ b/classes/squashfs.bbclass > @@ -22,7 +22,7 @@ def get_free_mem(): > > IMAGER_INSTALL:squashfs += "squashfs-tools" > > -SQUASHFS_EXCLUDE_DIRS ?= "" > +SQUASHFS_EXCLUDE_DIRS ?= "boot" > SQUASHFS_CONTENT ?= "${PP_ROOTFS}" > SQUASHFS_CREATION_ARGS ?= "" >
Yes, it is valid point , I will come up with the changes in V2. Thanks, Srinu -----Original Message----- From: Kiszka, Jan (T CED) <jan.kiszka@siemens.com> Sent: 18 July 2024 17:00 To: Arjunan, Srinu (DI CTO FDS CES LX PBU 2) <srinuvasan.a@siemens.com>; cip-dev@lists.cip-project.org Subject: Re: [isar-cip-core] [PATCH] classes/squashfs: exclude boot dir during squshfs image creation On 18.07.24 12:57, srinuvasan.a@siemens.com wrote: > From: Srinuvasan A <srinuvasan.a@siemens.com> > > For all the UEFI based bsps we used bootloader as efi bootguard, this > linux.efi contains necessary boot files to boot the system, hence > remove the boot content from squash root filesystem. > I can understand the goal, but the squashfs class is not logically coupled with UEFI booting. I suspect we need a better place to add "boo" to SQUASHFS_EXCLUDE_DIRS, a place where it is clear what the class is packaging. Jan > Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com> > --- > classes/squashfs.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/classes/squashfs.bbclass b/classes/squashfs.bbclass index > b39be0c..f9c7bf4 100644 > --- a/classes/squashfs.bbclass > +++ b/classes/squashfs.bbclass > @@ -22,7 +22,7 @@ def get_free_mem(): > > IMAGER_INSTALL:squashfs += "squashfs-tools" > > -SQUASHFS_EXCLUDE_DIRS ?= "" > +SQUASHFS_EXCLUDE_DIRS ?= "boot" > SQUASHFS_CONTENT ?= "${PP_ROOTFS}" > SQUASHFS_CREATION_ARGS ?= "" > -- Siemens AG, Technology Linux Expert Center
On Thu, 2024-07-18 at 16:27 +0530, srinuvasan.a@siemens.com wrote: > From: Srinuvasan A <srinuvasan.a@siemens.com> > > For all the UEFI based bsps we used bootloader as efi bootguard, this > linux.efi contains necessary boot files to boot the system, hence > remove > the boot content from squash root filesystem. > > Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com> > --- > classes/squashfs.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/classes/squashfs.bbclass b/classes/squashfs.bbclass > index b39be0c..f9c7bf4 100644 > --- a/classes/squashfs.bbclass > +++ b/classes/squashfs.bbclass > @@ -22,7 +22,7 @@ def get_free_mem(): > > IMAGER_INSTALL:squashfs += "squashfs-tools" > > -SQUASHFS_EXCLUDE_DIRS ?= "" > +SQUASHFS_EXCLUDE_DIRS ?= "boot" Hi, we also need to exclude /var (but only from bookworm on). But we need to ensure that only everything below /var or /boot is removed, but not the mountpoint itself. In case of wic, the syntax is <dir> resp. <dir>/. I hope this is supported by squashfs as well. Felix > SQUASHFS_CONTENT ?= "${PP_ROOTFS}" > SQUASHFS_CREATION_ARGS ?= "" >
Hi Felix,
Sure , thanks for the suggestion, let me check on that and send the next version PR soon.
Thanks,
Srinu
-----Original Message-----
From: Moessbauer, Felix (T CED OES-DE) <felix.moessbauer@siemens.com>
Sent: 19 July 2024 12:26
To: cip-dev@lists.cip-project.org; Arjunan, Srinu (DI CTO FDS CES LX PBU 2) <srinuvasan.a@siemens.com>
Cc: Kiszka, Jan (T CED) <jan.kiszka@siemens.com>
Subject: Re: [isar-cip-core] [PATCH] classes/squashfs: exclude boot dir during squshfs image creation
On Thu, 2024-07-18 at 16:27 +0530, srinuvasan.a@siemens.com wrote:
> From: Srinuvasan A <srinuvasan.a@siemens.com>
>
> For all the UEFI based bsps we used bootloader as efi bootguard, this
> linux.efi contains necessary boot files to boot the system, hence
> remove the boot content from squash root filesystem.
>
> Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
> ---
> classes/squashfs.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/classes/squashfs.bbclass b/classes/squashfs.bbclass index
> b39be0c..f9c7bf4 100644
> --- a/classes/squashfs.bbclass
> +++ b/classes/squashfs.bbclass
> @@ -22,7 +22,7 @@ def get_free_mem():
>
> IMAGER_INSTALL:squashfs += "squashfs-tools"
>
> -SQUASHFS_EXCLUDE_DIRS ?= ""
> +SQUASHFS_EXCLUDE_DIRS ?= "boot"
Hi, we also need to exclude /var (but only from bookworm on).
But we need to ensure that only everything below /var or /boot is removed, but not the mountpoint itself. In case of wic, the syntax is <dir> resp. <dir>/. I hope this is supported by squashfs as well.
Felix
> SQUASHFS_CONTENT ?= "${PP_ROOTFS}"
> SQUASHFS_CREATION_ARGS ?= ""
>
--
Siemens AG, Technology
Linux Expert Center
diff --git a/classes/squashfs.bbclass b/classes/squashfs.bbclass index b39be0c..f9c7bf4 100644 --- a/classes/squashfs.bbclass +++ b/classes/squashfs.bbclass @@ -22,7 +22,7 @@ def get_free_mem(): IMAGER_INSTALL:squashfs += "squashfs-tools" -SQUASHFS_EXCLUDE_DIRS ?= "" +SQUASHFS_EXCLUDE_DIRS ?= "boot" SQUASHFS_CONTENT ?= "${PP_ROOTFS}" SQUASHFS_CREATION_ARGS ?= ""