| Message ID | 20240719131722.8343-2-johan+linaro@kernel.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: qcom: x1e80100: PCIe fixes and CRD modem support | expand |
On 19.07.2024 3:17 PM, Johan Hovold wrote: > The PCIe4 PHY is powered by vreg_l3i (not vreg_l3j). > > Fixes: d7e03cce0400 ("arm64: dts: qcom: x1e80100-crd: Enable more support") > Cc: stable@vger.kernel.org # 6.9 > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- Mind fixing that up on all laptops? Most of them are 80-85% CRD copypaste designs and regulators for precise things like PHYs are generally predefined for a set of PMICs Konrad
On Fri, Jul 19, 2024 at 08:34:27PM +0200, Konrad Dybcio wrote: > On 19.07.2024 3:17 PM, Johan Hovold wrote: > > The PCIe4 PHY is powered by vreg_l3i (not vreg_l3j). > > > > Fixes: d7e03cce0400 ("arm64: dts: qcom: x1e80100-crd: Enable more support") > > Cc: stable@vger.kernel.org # 6.9 > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > > --- > > Mind fixing that up on all laptops? > > Most of them are 80-85% CRD copypaste designs and regulators for > precise things like PHYs are generally predefined for a set of PMICs Sure. I worry that this blind fate in copy-pasting is going to bite people, but it seems like at least the PCIe PHY regulators were shared on sc8280xp too. Johan
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts index f97c80b4077c..6aa2ec1e7919 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts +++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts @@ -788,7 +788,7 @@ &pcie4 { }; &pcie4_phy { - vdda-phy-supply = <&vreg_l3j_0p8>; + vdda-phy-supply = <&vreg_l3i_0p8>; vdda-pll-supply = <&vreg_l3e_1p2>; status = "okay";
The PCIe4 PHY is powered by vreg_l3i (not vreg_l3j). Fixes: d7e03cce0400 ("arm64: dts: qcom: x1e80100-crd: Enable more support") Cc: stable@vger.kernel.org # 6.9 Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)