mbox series

[bpf-next,0/4] use network helpers, part 10

Message ID cover.1721475357.git.tanggeliang@kylinos.cn (mailing list archive)
Headers show
Series use network helpers, part 10 | expand

Message

Geliang Tang July 20, 2024, 11:40 a.m. UTC
From: Geliang Tang <tanggeliang@kylinos.cn>

This set is part 10 of series "use network helpers" all BPF selftests
wide.

Patches 1-3 drop local functions make_client(), make_socket() and
inetaddr_len() in sk_lookup.c. Patch 4 drops a useless function
__start_server() in network_helpers.c.

Geliang Tang (4):
  selftests/bpf: Drop make_client in sk_lookup
  selftests/bpf: Drop make_socket in sk_lookup
  selftests/bpf: Drop inetaddr_len in sk_lookup
  selftests/bpf: Drop __start_server in network_helpers

 tools/testing/selftests/bpf/network_helpers.c |  26 ++---
 .../selftests/bpf/prog_tests/sk_lookup.c      | 110 +++++-------------
 2 files changed, 40 insertions(+), 96 deletions(-)

Comments

bot+bpf-ci@kernel.org July 20, 2024, noon UTC | #1
Dear patch submitter,

CI has tested the following submission:
Status:     SUCCESS
Name:       [bpf-next,0/4] use network helpers, part 10
Patchwork:  https://patchwork.kernel.org/project/netdevbpf/list/?series=872683&state=*
Matrix:     https://github.com/kernel-patches/bpf/actions/runs/10019935133

No further action is necessary on your part.


Please note: this email is coming from an unmonitored mailbox. If you have
questions or feedback, please reach out to the Meta Kernel CI team at
kernel-ci@meta.com.
bot+bpf-ci@kernel.org July 23, 2024, 1:18 a.m. UTC | #2
Dear patch submitter,

CI has tested the following submission:
Status:     FAILURE
Name:       [bpf-next,0/4] use network helpers, part 10
Patchwork:  https://patchwork.kernel.org/project/netdevbpf/list/?series=872683&state=*
Matrix:     https://github.com/kernel-patches/bpf/actions/runs/10050705880

Failed jobs:
test_progs_no_alu32-aarch64-gcc: https://github.com/kernel-patches/bpf/actions/runs/10050705880/job/27779265107
test_progs_no_alu32-s390x-gcc: https://github.com/kernel-patches/bpf/actions/runs/10050705880/job/27779401509
test_progs_no_alu32-x86_64-gcc: https://github.com/kernel-patches/bpf/actions/runs/10050705880/job/27779392788
test_progs_no_alu32-x86_64-llvm-17: https://github.com/kernel-patches/bpf/actions/runs/10050705880/job/27779412425
test_progs_no_alu32-x86_64-llvm-18: https://github.com/kernel-patches/bpf/actions/runs/10050705880/job/27779413675

First test_progs failure (test_progs_no_alu32-aarch64-gcc):
#134 libbpf_get_fd_by_id_opts
libbpf: prog 'check_access': BPF program load failed: Invalid argument
libbpf: prog 'check_access': -- BEGIN PROG LOAD LOG --
0: R1=ctx() R10=fp0
; int BPF_PROG(check_access, struct bpf_map *map, fmode_t fmode) @ test_libbpf_get_fd_by_id_opts.c:27
0: (b7) r0 = 0                        ; R0_w=0
1: (79) r2 = *(u64 *)(r1 +0)
func 'bpf_lsm_bpf_map' arg0 has btf_id 2072 type STRUCT 'bpf_map'
2: R1=ctx() R2_w=trusted_ptr_bpf_map()
; if (map != (struct bpf_map *)&data_input) @ test_libbpf_get_fd_by_id_opts.c:29
2: (18) r3 = 0xffff0000c28d1a00       ; R3_w=map_ptr(map=data_input,ks=4,vs=4)
4: (5d) if r2 != r3 goto pc+4         ; R2_w=trusted_ptr_bpf_map() R3_w=map_ptr(map=data_input,ks=4,vs=4)
; int BPF_PROG(check_access, struct bpf_map *map, fmode_t fmode) @ test_libbpf_get_fd_by_id_opts.c:27
5: (79) r0 = *(u64 *)(r1 +8)          ; R0_w=scalar() R1=ctx()
; if (fmode & FMODE_WRITE) @ test_libbpf_get_fd_by_id_opts.c:32
6: (67) r0 <<= 62                     ; R0_w=scalar(smax=0x4000000000000000,umax=0xc000000000000000,smin32=0,smax32=umax32=0,var_off=(0x0; 0xc000000000000000))
7: (c7) r0 s>>= 63                    ; R0_w=scalar(smin=smin32=-1,smax=smax32=0)
;  @ test_libbpf_get_fd_by_id_opts.c:0
8: (57) r0 &= -13                     ; R0_w=scalar(smax=0x7ffffffffffffff3,umax=0xfffffffffffffff3,smax32=0x7ffffff3,umax32=0xfffffff3,var_off=(0x0; 0xfffffffffffffff3))
; int BPF_PROG(check_access, struct bpf_map *map, fmode_t fmode) @ test_libbpf_get_fd_by_id_opts.c:27
9: (95) exit
At program exit the register R0 has smax=9223372036854775795 should have been in [-4095, 0]
processed 9 insns (limit 1000000) max_states_per_insn 0 total_states 0 peak_states 0 mark_read 0
-- END PROG LOAD LOG --
libbpf: prog 'check_access': failed to load: -22
libbpf: failed to load object 'test_libbpf_get_fd_by_id_opts'
libbpf: failed to load BPF skeleton 'test_libbpf_get_fd_by_id_opts': -22
test_libbpf_get_fd_by_id_opts:FAIL:test_libbpf_get_fd_by_id_opts__open_and_load unexpected error: -22


Please note: this email is coming from an unmonitored mailbox. If you have
questions or feedback, please reach out to the Meta Kernel CI team at
kernel-ci@meta.com.
bot+bpf-ci@kernel.org July 23, 2024, 2:55 a.m. UTC | #3
Dear patch submitter,

CI has tested the following submission:
Status:     SUCCESS
Name:       [bpf-next,0/4] use network helpers, part 10
Patchwork:  https://patchwork.kernel.org/project/netdevbpf/list/?series=872683&state=*
Matrix:     https://github.com/kernel-patches/bpf/actions/runs/10051538319

No further action is necessary on your part.


Please note: this email is coming from an unmonitored mailbox. If you have
questions or feedback, please reach out to the Meta Kernel CI team at
kernel-ci@meta.com.
patchwork-bot+netdevbpf@kernel.org July 23, 2024, 6:40 p.m. UTC | #4
Hello:

This series was applied to bpf/bpf-next.git (master)
by Martin KaFai Lau <martin.lau@kernel.org>:

On Sat, 20 Jul 2024 19:40:02 +0800 you wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> This set is part 10 of series "use network helpers" all BPF selftests
> wide.
> 
> Patches 1-3 drop local functions make_client(), make_socket() and
> inetaddr_len() in sk_lookup.c. Patch 4 drops a useless function
> __start_server() in network_helpers.c.
> 
> [...]

Here is the summary with links:
  - [bpf-next,1/4] selftests/bpf: Drop make_client in sk_lookup
    https://git.kernel.org/bpf/bpf-next/c/a81b34bb2dc7
  - [bpf-next,2/4] selftests/bpf: Drop make_socket in sk_lookup
    https://git.kernel.org/bpf/bpf-next/c/c6b30248c21a
  - [bpf-next,3/4] selftests/bpf: Drop inetaddr_len in sk_lookup
    https://git.kernel.org/bpf/bpf-next/c/5849dff3414b
  - [bpf-next,4/4] selftests/bpf: Drop __start_server in network_helpers
    https://git.kernel.org/bpf/bpf-next/c/b27a9abd2dc1

You are awesome, thank you!