| Message ID | 20240711211558.106327-9-vassilisamir@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | BMP280: Minor cleanup and interrupt support | expand |
On Thu, 11 Jul 2024 23:15:56 +0200, Vasileios Amoiridis wrote: > Add interrupt options for BMP3xx and BMP5xx devices as well. > > Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com> > --- > .../devicetree/bindings/iio/pressure/bmp085.yaml | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml: properties:int-open-drain: 'anyOf' conditional failed, one must be fixed: 'desription' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'dependentRequired', 'dependentSchemas', 'deprecated', 'description', 'else', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'typeSize', 'unevaluatedProperties', 'uniqueItems'] 'type' was expected from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml: properties:interrupt-names:items: {'enum': ['DRDY']} is not of type 'array' from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml: int-open-drain: missing type definition doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240711211558.106327-9-vassilisamir@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Thu, Jul 11, 2024 at 11:15:56PM +0200, Vasileios Amoiridis wrote: > Add interrupt options for BMP3xx and BMP5xx devices as well. > > Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com> > --- > .../devicetree/bindings/iio/pressure/bmp085.yaml | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml > index 6fda887ee9d4..f06f119963bc 100644 > --- a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml > +++ b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml > @@ -48,9 +48,20 @@ properties: > > interrupts: > description: > - interrupt mapping for IRQ (BMP085 only) > + interrupt mapping for IRQ. Supported in BMP085, BMP3xx, BMP5xx > maxItems: 1 > > + interrupt-names: > + maxItems: 1 > + items: > + enum: > + - DRDY > + > + int-open-drain: Use the existing 'drive-open-drain' property. > + desription: > + set if the interrupt pin should be configured as open drain. > + If not set, defaults to push-pull configuration. > + > required: > - compatible > - vddd-supply > -- > 2.25.1 >
On Fri, Jul 12, 2024 at 06:48:05AM -0600, Rob Herring wrote: > On Thu, Jul 11, 2024 at 11:15:56PM +0200, Vasileios Amoiridis wrote: > > Add interrupt options for BMP3xx and BMP5xx devices as well. > > > > Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com> > > --- > > .../devicetree/bindings/iio/pressure/bmp085.yaml | 13 ++++++++++++- > > 1 file changed, 12 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml > > index 6fda887ee9d4..f06f119963bc 100644 > > --- a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml > > +++ b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml > > @@ -48,9 +48,20 @@ properties: > > > > interrupts: > > description: > > - interrupt mapping for IRQ (BMP085 only) > > + interrupt mapping for IRQ. Supported in BMP085, BMP3xx, BMP5xx > > maxItems: 1 > > > > + interrupt-names: > > + maxItems: 1 > > + items: > > + enum: > > + - DRDY > > + > > + int-open-drain: > > Use the existing 'drive-open-drain' property. > Hi Rob, Thanks for the feedback. I will also use the tools from your automated reply. Cheers, Vasilis > > + desription: > > + set if the interrupt pin should be configured as open drain. > > + If not set, defaults to push-pull configuration. > > + > > required: > > - compatible > > - vddd-supply > > -- > > 2.25.1 > >
diff --git a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml index 6fda887ee9d4..f06f119963bc 100644 --- a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml +++ b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml @@ -48,9 +48,20 @@ properties: interrupts: description: - interrupt mapping for IRQ (BMP085 only) + interrupt mapping for IRQ. Supported in BMP085, BMP3xx, BMP5xx maxItems: 1 + interrupt-names: + maxItems: 1 + items: + enum: + - DRDY + + int-open-drain: + desription: + set if the interrupt pin should be configured as open drain. + If not set, defaults to push-pull configuration. + required: - compatible - vddd-supply
Add interrupt options for BMP3xx and BMP5xx devices as well. Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com> --- .../devicetree/bindings/iio/pressure/bmp085.yaml | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)