diff mbox series

[v1,3/6] perf auxtrace s390: Set the 'auxtrace' flag for AUX events

Message ID 20240721202113.380750-4-leo.yan@arm.com (mailing list archive)
State New, archived
Headers show
Series perf auxtrace: Support multiple AUX events | expand

Commit Message

Leo Yan July 21, 2024, 8:21 p.m. UTC 
Set the 'auxtrace' flag for AUX events on s390.

Signed-off-by: Leo Yan <leo.yan@arm.com>
---
 tools/perf/arch/s390/util/auxtrace.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Adrian Hunter July 22, 2024, 10:54 a.m. UTC | #1 
On 21/07/24 23:21, Leo Yan wrote:
> Set the 'auxtrace' flag for AUX events on s390.
> 
> Signed-off-by: Leo Yan <leo.yan@arm.com>
> ---
>  tools/perf/arch/s390/util/auxtrace.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/perf/arch/s390/util/auxtrace.c b/tools/perf/arch/s390/util/auxtrace.c
> index 5068baa3e092..d7e72413b262 100644
> --- a/tools/perf/arch/s390/util/auxtrace.c
> +++ b/tools/perf/arch/s390/util/auxtrace.c
> @@ -99,6 +99,7 @@ struct auxtrace_record *auxtrace_record__init(struct evlist *evlist,
>  		if (pos->core.attr.config == PERF_EVENT_CPUM_SF_DIAG) {
>  			diagnose = 1;
>  			pos->needs_auxtrace_mmap = true;
> +			pos->pmu->auxtrace = true;

This is probably too late. See:

https://lore.kernel.org/all/20240715160712.127117-7-adrian.hunter@intel.com/

>  			break;
>  		}
>  	}
Leo Yan July 22, 2024, 2:48 p.m. UTC | #2 
On 7/22/24 11:54, Adrian Hunter wrote:

[...]

> On 21/07/24 23:21, Leo Yan wrote:
>> Set the 'auxtrace' flag for AUX events on s390.
>>
>> Signed-off-by: Leo Yan <leo.yan@arm.com>
>> ---
>>   tools/perf/arch/s390/util/auxtrace.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/perf/arch/s390/util/auxtrace.c b/tools/perf/arch/s390/util/auxtrace.c
>> index 5068baa3e092..d7e72413b262 100644
>> --- a/tools/perf/arch/s390/util/auxtrace.c
>> +++ b/tools/perf/arch/s390/util/auxtrace.c
>> @@ -99,6 +99,7 @@ struct auxtrace_record *auxtrace_record__init(struct evlist *evlist,
>>                if (pos->core.attr.config == PERF_EVENT_CPUM_SF_DIAG) {
>>                        diagnose = 1;
>>                        pos->needs_auxtrace_mmap = true;
>> +                     pos->pmu->auxtrace = true;
> 
> This is probably too late. See:
> 
> https://lore.kernel.org/all/20240715160712.127117-7-adrian.hunter@intel.com/

Okay, I will drop this patch.

Thanks,
Leo


> 
>>                        break;
>>                }
>>        }
>
diff mbox series

Patch

diff --git a/tools/perf/arch/s390/util/auxtrace.c b/tools/perf/arch/s390/util/auxtrace.c
index 5068baa3e092..d7e72413b262 100644
--- a/tools/perf/arch/s390/util/auxtrace.c
+++ b/tools/perf/arch/s390/util/auxtrace.c
@@ -99,6 +99,7 @@  struct auxtrace_record *auxtrace_record__init(struct evlist *evlist,
 		if (pos->core.attr.config == PERF_EVENT_CPUM_SF_DIAG) {
 			diagnose = 1;
 			pos->needs_auxtrace_mmap = true;
+			pos->pmu->auxtrace = true;
 			break;
 		}
 	}