diff mbox series

[v2] lib: test_objpool: add missing MODULE_DESCRIPTION() macro

Message ID 20240715-md-lib-test_objpool-v2-1-5a2b9369c37e@quicinc.com (mailing list archive)
State Accepted
Commit 053a5e4cbba88625ac6b53dea6371006237c34ba
Headers show
Series [v2] lib: test_objpool: add missing MODULE_DESCRIPTION() macro | expand

Commit Message

Jeff Johnson July 15, 2024, 2:18 p.m. UTC
make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_objpool.o

Add the missing invocation of the MODULE_DESCRIPTION() macro.

Reviewed-by: Matt Wu <wuqiang.matt@bytedance.com>
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
Changes in v2:
- No changes to actual patch, just rebased, picked up Matt's Reviewed-by
  tag, and added Masami & linux-trace-kernel
- Link to v1: https://lore.kernel.org/r/20240531-md-lib-test_objpool-v1-1-516efee92a05@quicinc.com
---
 lib/test_objpool.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)


---
base-commit: 0c3836482481200ead7b416ca80c68a29cfdaabd
change-id: 20240531-md-lib-test_objpool-338d937f8666

Comments

Jeff Johnson July 23, 2024, 6:51 p.m. UTC | #1
On 7/15/2024 7:18 AM, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_objpool.o
> 
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> 
> Reviewed-by: Matt Wu <wuqiang.matt@bytedance.com>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> Changes in v2:
> - No changes to actual patch, just rebased, picked up Matt's Reviewed-by
>   tag, and added Masami & linux-trace-kernel
> - Link to v1: https://lore.kernel.org/r/20240531-md-lib-test_objpool-v1-1-516efee92a05@quicinc.com
> ---
>  lib/test_objpool.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/test_objpool.c b/lib/test_objpool.c
> index bfdb81599832..5a3f6961a70f 100644
> --- a/lib/test_objpool.c
> +++ b/lib/test_objpool.c
> @@ -687,4 +687,5 @@ static void __exit ot_mod_exit(void)
>  module_init(ot_mod_init);
>  module_exit(ot_mod_exit);
>  
> -MODULE_LICENSE("GPL");
> \ No newline at end of file
> +MODULE_DESCRIPTION("Test module for lockless object pool");
> +MODULE_LICENSE("GPL");
> 
> ---
> base-commit: 0c3836482481200ead7b416ca80c68a29cfdaabd
> change-id: 20240531-md-lib-test_objpool-338d937f8666
> 

Hi Andrew & Masami,
I see this landed in linux-next, but is not currently in Linus' tree for 6.11.
Will you be able to have this pulled during the merge window?
I'm trying to eradicate all of these warnings before 6.11 rc-final.

Thanks!
/jeff
diff mbox series

Patch

diff --git a/lib/test_objpool.c b/lib/test_objpool.c
index bfdb81599832..5a3f6961a70f 100644
--- a/lib/test_objpool.c
+++ b/lib/test_objpool.c
@@ -687,4 +687,5 @@  static void __exit ot_mod_exit(void)
 module_init(ot_mod_init);
 module_exit(ot_mod_exit);
 
-MODULE_LICENSE("GPL");
\ No newline at end of file
+MODULE_DESCRIPTION("Test module for lockless object pool");
+MODULE_LICENSE("GPL");