| Message ID | 20240723161817.2191843-1-yuki.utk8g@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | client: use display_table_row for IPv6 in station | expand |
Hi Yuki, On 7/23/24 11:18 AM, Yuki Sireneva wrote: > IPv6 address entry was not updated to use display_table_row which led to > a shifted line in table, as shown below: > > $ iwctl station wlan0 show | head | sed 's| |.|g' > .................................Station:.wlan0................................ > -------------------------------------------------------------------------------- > ..Settable..Property..............Value.......................................... > -------------------------------------------------------------------------------- > ............Scanning..............no............................................... > ............State.................connected........................................ > ............Connected.network.....Clannad.Legacy................................... > ............IPv4.address..........192.168.1.12..................................... > ............IPv6.address........fdc3:541d:864f:0:96db:c9ff:fe36:b15............ > ............ConnectedBss..........cc:d8:43:77:91:0e................................ > > This patch aligns IPv6 address line with other lines in the table. > > Fixes: 35dd2c08219a (client: update station to use display_table_row, 2022-07-07) > --- > client/station.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > Applied, thanks. Regards, -Denis
diff --git a/client/station.c b/client/station.c index 1d958ef2..16c86dac 100644 --- a/client/station.c +++ b/client/station.c @@ -175,8 +175,7 @@ static void display_addresses(const char *device_name) continue; have_address = true; - display("%s%*s %-*s%-*s\n", MARGIN, 8, "", 20, - "IPv6 address", 47, addrstr); + display_table_row(MARGIN, 3, 8, "", 20, "IPv6 address", 47, addrstr); } else if (cur->ifa_addr->sa_family == AF_INET) { struct sockaddr_in *si = (struct sockaddr_in *) cur->ifa_addr;
IPv6 address entry was not updated to use display_table_row which led to a shifted line in table, as shown below: $ iwctl station wlan0 show | head | sed 's| |.|g' .................................Station:.wlan0................................ -------------------------------------------------------------------------------- ..Settable..Property..............Value.......................................... -------------------------------------------------------------------------------- ............Scanning..............no............................................... ............State.................connected........................................ ............Connected.network.....Clannad.Legacy................................... ............IPv4.address..........192.168.1.12..................................... ............IPv6.address........fdc3:541d:864f:0:96db:c9ff:fe36:b15............ ............ConnectedBss..........cc:d8:43:77:91:0e................................ This patch aligns IPv6 address line with other lines in the table. Fixes: 35dd2c08219a (client: update station to use display_table_row, 2022-07-07) --- client/station.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)