mbox series

[0/2] Add driver for Sharp Memory LCD

Message ID 20240725004734.644986-1-lanzano.alex@gmail.com (mailing list archive)
Headers show
Series Add driver for Sharp Memory LCD | expand

Message

Alex Lanzano July 25, 2024, 12:47 a.m. UTC 
This patch series add support for the monochrome Sharp Memory LCD
panels. This series is based off of the work done by Mehdi Djait.

References:
https://lore.kernel.org/dri-devel/71a9dbf4609dbba46026a31f60261830163a0b99.1701267411.git.mehdi.djait@bootlin.com/
https://www.sharpsde.com/fileadmin/products/Displays/2016_SDE_App_Note_for_Memory_LCD_programming_V1.3.pdf

Alex Lanzano (2):
  dt-bindings: display: Add Sharp Memory LCD bindings
  drm/tiny: Add driver for Sharp Memory LCD

 .../bindings/display/sharp,sharp-memory.yaml  |  97 +++
 MAINTAINERS                                   |   8 +
 drivers/gpu/drm/tiny/Kconfig                  |  20 +
 drivers/gpu/drm/tiny/Makefile                 |   1 +
 drivers/gpu/drm/tiny/sharp-memory.c           | 741 ++++++++++++++++++
 include/dt-bindings/display/sharp-memory.h    |   9 +
 6 files changed, 876 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/sharp,sharp-memory.yaml
 create mode 100644 drivers/gpu/drm/tiny/sharp-memory.c
 create mode 100644 include/dt-bindings/display/sharp-memory.h

Comments

Thomas Petazzoni July 25, 2024, 5:45 a.m. UTC | #1 
Hello Alex,

On Wed, 24 Jul 2024 20:47:01 -0400
Alex Lanzano <lanzano.alex@gmail.com> wrote:

> This patch series add support for the monochrome Sharp Memory LCD
> panels. This series is based off of the work done by Mehdi Djait.

Thanks for resuming the effort on this patch series! Since this patch
series is clearly heavily based on Mehdi's work, wouldn't it make sense
to preserve Mehdi's authorship for the patches?

Best regards,

Thomas
Alex Lanzano July 26, 2024, 12:07 a.m. UTC | #2 
On Thu, Jul 25, 2024 at 07:45:32AM GMT, Thomas Petazzoni wrote:
> Hello Alex,
> 
> On Wed, 24 Jul 2024 20:47:01 -0400
> Alex Lanzano <lanzano.alex@gmail.com> wrote:
> 
> > This patch series add support for the monochrome Sharp Memory LCD
> > panels. This series is based off of the work done by Mehdi Djait.
> 
> Thanks for resuming the effort on this patch series! Since this patch
> series is clearly heavily based on Mehdi's work, wouldn't it make sense
> to preserve Mehdi's authorship for the patches?

Hi! Thanks for the review. 

What would be the best way to go about doing this? I'm guessing appending to
MODULE_AUTHOR and adding a Signed-of-by or Co-Developed-by?
Thomas Petazzoni July 26, 2024, 6:27 a.m. UTC | #3 
Hello,

On Thu, 25 Jul 2024 20:07:01 -0400
Alex Lanzano <lanzano.alex@gmail.com> wrote:

> What would be the best way to go about doing this? I'm guessing appending to
> MODULE_AUTHOR and adding a Signed-of-by or Co-Developed-by?

Depends on how much you've changed things compared to Mehdi's version.
If you've mostly kept what Mehdi did, then I guess you should keep him
as the author of the commits (i.e the Author: field of the git commit +
the first Signed-off-by), and add your Signed-off-by underneath.

If you've made very significant changes to the point where the code
isn't really Mehdi's code anymore, but just inspired, then you should
set yourself as the author (Author: field of the git commit + the first
Signed-off-by), and credit Mehdi via a Co-developed-by: tag.

In any case, thanks a lot for this pushing this work, much appreciated!

Thomas