Message ID | 20240722223333.1137947-2-sunyeal.hong@samsung.com (mailing list archive) |
---|---|
State | Changes Requested, archived |
Headers | show |
Series | [v4,1/4] dt-bindings: clock: add ExynosAuto v920 SoC CMU bindings | expand |
On Tue, Jul 23, 2024 at 07:33:30AM +0900, Sunyeal Hong wrote: > Add dt-schema for ExynosAuto v920 SoC clock controller. > Add device tree clock binding definitions for below CMU blocks. > > - CMU_TOP > - CMU_PERIC0 > > Signed-off-by: Sunyeal Hong <sunyeal.hong@samsung.com> > --- > .../clock/samsung,exynosautov920-clock.yaml | 115 +++++++++++ > .../clock/samsung,exynosautov920.h | 191 ++++++++++++++++++ > 2 files changed, 306 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/samsung,exynosautov920-clock.yaml > create mode 100644 include/dt-bindings/clock/samsung,exynosautov920.h > > diff --git a/Documentation/devicetree/bindings/clock/samsung,exynosautov920-clock.yaml b/Documentation/devicetree/bindings/clock/samsung,exynosautov920-clock.yaml > new file mode 100644 > index 000000000000..90f9f17da959 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/samsung,exynosautov920-clock.yaml > @@ -0,0 +1,115 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/samsung,exynosautov920-clock.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Samsung ExynosAuto v920 SoC clock controller > + > +maintainers: > + - Sunyeal Hong <sunyeal.hong@samsung.com> > + - Chanwoo Choi <cw00.choi@samsung.com> > + - Krzysztof Kozlowski <krzk@kernel.org> > + - Sylwester Nawrocki <s.nawrocki@samsung.com> > + > +description: | > + ExynosAuto v920 clock controller is comprised of several CMU units, generating > + clocks for different domains. Those CMU units are modeled as separate device > + tree nodes, and might depend on each other. Root clocks in that clock tree are > + two external clocks:: OSCCLK/XTCXO (38.4 MHz) and RTCCLK/XrtcXTI (32768 Hz). > + The external OSCCLK must be defined as fixed-rate clock in dts. > + > + CMU_TOP is a top-level CMU, where all base clocks are prepared using PLLs and > + dividers; all other clocks of function blocks (other CMUs) are usually > + derived from CMU_TOP. > + > + Each clock is assigned an identifier and client nodes can use this identifier > + to specify the clock which they consume. All clocks available for usage > + in clock consumer nodes are defined as preprocessor macros in > + 'include/dt-bindings/clock/samsung,exynosautov920.h' header. > + > +properties: > + compatible: > + enum: > + - samsung,exynosautov920-cmu-top > + - samsung,exynosautov920-cmu-peric0 > + > + clocks: > + minItems: 1 > + maxItems: 3 > + > + clock-names: > + minItems: 1 > + maxItems: 3 Move the descriptions and names here. Then in the if/then schemas just set the number of items to 1 or 3 as appropriate. Rob
On 23/07/2024 00:33, Sunyeal Hong wrote: > Add dt-schema for ExynosAuto v920 SoC clock controller. > Add device tree clock binding definitions for below CMU blocks. > > - CMU_TOP > - CMU_PERIC0 > > Signed-off-by: Sunyeal Hong <sunyeal.hong@samsung.com> > --- > .../clock/samsung,exynosautov920-clock.yaml | 115 +++++++++++ > .../clock/samsung,exynosautov920.h | 191 ++++++++++++++++++ > 2 files changed, 306 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/samsung,exynosautov920-clock.yaml > create mode 100644 include/dt-bindings/clock/samsung,exynosautov920.h > > diff --git a/Documentation/devicetree/bindings/clock/samsung,exynosautov920-clock.yaml b/Documentation/devicetree/bindings/clock/samsung,exynosautov920-clock.yaml > new file mode 100644 > index 000000000000..90f9f17da959 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/samsung,exynosautov920-clock.yaml > @@ -0,0 +1,115 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/samsung,exynosautov920-clock.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Samsung ExynosAuto v920 SoC clock controller > + > +maintainers: > + - Sunyeal Hong <sunyeal.hong@samsung.com> > + - Chanwoo Choi <cw00.choi@samsung.com> > + - Krzysztof Kozlowski <krzk@kernel.org> > + - Sylwester Nawrocki <s.nawrocki@samsung.com> > + > +description: | > + ExynosAuto v920 clock controller is comprised of several CMU units, generating > + clocks for different domains. Those CMU units are modeled as separate device > + tree nodes, and might depend on each other. Root clocks in that clock tree are > + two external clocks:: OSCCLK/XTCXO (38.4 MHz) and RTCCLK/XrtcXTI (32768 Hz). > + The external OSCCLK must be defined as fixed-rate clock in dts. > + > + CMU_TOP is a top-level CMU, where all base clocks are prepared using PLLs and > + dividers; all other clocks of function blocks (other CMUs) are usually > + derived from CMU_TOP. > + > + Each clock is assigned an identifier and client nodes can use this identifier > + to specify the clock which they consume. All clocks available for usage > + in clock consumer nodes are defined as preprocessor macros in > + 'include/dt-bindings/clock/samsung,exynosautov920.h' header. > + > +properties: > + compatible: > + enum: > + - samsung,exynosautov920-cmu-top > + - samsung,exynosautov920-cmu-peric0 > + > + clocks: > + minItems: 1 > + maxItems: 3 > + > + clock-names: > + minItems: 1 > + maxItems: 3 > + > + "#clock-cells": > + const: 1 > + > + reg: > + maxItems: 1 > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: samsung,exynosautov920-cmu-top > + > + then: > + properties: > + clocks: > + items: > + - description: External reference clock (38.4 MHz) > + > + clock-names: > + items: > + - const: oscclk > + > + - if: > + properties: > + compatible: > + contains: > + const: samsung,exynosautov920-cmu-peric0 > + > + then: > + properties: > + clocks: > + items: > + - description: External reference clock (38.4 MHz) > + - description: CMU_PERIC0 NOC clock (from CMU_TOP) > + - description: CMU_PERIC0 IP clock (from CMU_TOP) > + > + clock-names: > + items: > + - const: oscclk > + - const: noc > + - const: ip > + > +required: > + - compatible > + - "#clock-cells" > + - clocks > + - clock-names > + - reg > + > +additionalProperties: false > + > +examples: > + # Clock controller node for CMU_PERIC0 > + - | > + #include <dt-bindings/clock/samsung,exynosautov920.h> > + > + cmu_peric0: clock-controller@10800000 { > + compatible = "samsung,exynosautov920-cmu-peric0"; > + reg = <0x10800000 0x8000>; > + #clock-cells = <1>; > + > + clocks = <&xtcxo>, > + <&cmu_top DOUT_CLKCMU_PERIC0_NOC>, > + <&cmu_top DOUT_CLKCMU_PERIC0_IP>; > + clock-names = "oscclk", > + "noc", > + "ip"; > + }; > + > +... > diff --git a/include/dt-bindings/clock/samsung,exynosautov920.h b/include/dt-bindings/clock/samsung,exynosautov920.h > new file mode 100644 > index 000000000000..ad89728a4396 > --- /dev/null > +++ b/include/dt-bindings/clock/samsung,exynosautov920.h > @@ -0,0 +1,191 @@ > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ > +/* > + * Copyright (c) 2024 Samsung Electronics Co., Ltd. > + * Author: Sunyeal Hong <sunyeal.hong@samsung.com> > + * > + * Device Tree binding constants for ExynosAuto v920 clock controller. > + */ > + > +#ifndef _DT_BINDINGS_CLOCK_EXYNOSAUTOV920_H > +#define _DT_BINDINGS_CLOCK_EXYNOSAUTOV920_H > + > +/* CMU_TOP */ > +#define FOUT_SHARED0_PLL 1 > +#define FOUT_SHARED1_PLL 2 > +#define FOUT_SHARED2_PLL 3 > +#define FOUT_SHARED3_PLL 4 > +#define FOUT_SHARED4_PLL 5 > +#define FOUT_SHARED5_PLL 6 > +#define FOUT_MMC_PLL 7 > + > +/* MUX in CMU_TOP */ > +#define MOUT_SHARED0_PLL 101 This is some odd numbering. Numbers start from 0 or 1 and are continuous. Best regards, Krzysztof
Hello Rob, > -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: Wednesday, July 24, 2024 5:57 AM > To: Sunyeal Hong <sunyeal.hong@samsung.com> > Cc: Krzysztof Kozlowski <krzk@kernel.org>; Sylwester Nawrocki > <s.nawrocki@samsung.com>; Chanwoo Choi <cw00.choi@samsung.com>; Alim > Akhtar <alim.akhtar@samsung.com>; Michael Turquette > <mturquette@baylibre.com>; Stephen Boyd <sboyd@kernel.org>; Conor Dooley > <conor+dt@kernel.org>; linux-samsung-soc@vger.kernel.org; linux- > clk@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v4 1/4] dt-bindings: clock: add ExynosAuto v920 SoC > CMU bindings > > On Tue, Jul 23, 2024 at 07:33:30AM +0900, Sunyeal Hong wrote: > > Add dt-schema for ExynosAuto v920 SoC clock controller. > > Add device tree clock binding definitions for below CMU blocks. > > > > - CMU_TOP > > - CMU_PERIC0 > > > > Signed-off-by: Sunyeal Hong <sunyeal.hong@samsung.com> > > --- > > .../clock/samsung,exynosautov920-clock.yaml | 115 +++++++++++ > > .../clock/samsung,exynosautov920.h | 191 ++++++++++++++++++ > > 2 files changed, 306 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/clock/samsung,exynosautov920-clock.y > > aml create mode 100644 > > include/dt-bindings/clock/samsung,exynosautov920.h > > > > diff --git > > a/Documentation/devicetree/bindings/clock/samsung,exynosautov920-clock > > .yaml > > b/Documentation/devicetree/bindings/clock/samsung,exynosautov920-clock > > .yaml > > new file mode 100644 > > index 000000000000..90f9f17da959 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/samsung,exynosautov920-c > > +++ lock.yaml > > @@ -0,0 +1,115 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > +--- > > +$id: > > +https://protect2.fireeye.com/v1/url?k=9932a88e-c6ae81a4-993323c1-000b > > +abe598f7-779f1e959ac8eab9&q=1&e=539edfa4-b4e4-460a-93f4-1e6f17030945& > > +u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fclock%2Fsamsung%2Cexynosaut > > +ov920-clock.yaml%23 > > +$schema: > > +https://protect2.fireeye.com/v1/url?k=4dbf6fb9-12234693-4dbee4f6-000b > > +abe598f7-363a2f64c69b9542&q=1&e=539edfa4-b4e4-460a-93f4-1e6f17030945& > > +u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 > > + > > +title: Samsung ExynosAuto v920 SoC clock controller > > + > > +maintainers: > > + - Sunyeal Hong <sunyeal.hong@samsung.com> > > + - Chanwoo Choi <cw00.choi@samsung.com> > > + - Krzysztof Kozlowski <krzk@kernel.org> > > + - Sylwester Nawrocki <s.nawrocki@samsung.com> > > + > > +description: | > > + ExynosAuto v920 clock controller is comprised of several CMU units, > > +generating > > + clocks for different domains. Those CMU units are modeled as > > +separate device > > + tree nodes, and might depend on each other. Root clocks in that > > +clock tree are > > + two external clocks:: OSCCLK/XTCXO (38.4 MHz) and RTCCLK/XrtcXTI > (32768 Hz). > > + The external OSCCLK must be defined as fixed-rate clock in dts. > > + > > + CMU_TOP is a top-level CMU, where all base clocks are prepared > > + using PLLs and dividers; all other clocks of function blocks (other > > + CMUs) are usually derived from CMU_TOP. > > + > > + Each clock is assigned an identifier and client nodes can use this > > + identifier to specify the clock which they consume. All clocks > > + available for usage in clock consumer nodes are defined as > > + preprocessor macros in 'include/dt- > bindings/clock/samsung,exynosautov920.h' header. > > + > > +properties: > > + compatible: > > + enum: > > + - samsung,exynosautov920-cmu-top > > + - samsung,exynosautov920-cmu-peric0 > > + > > + clocks: > > + minItems: 1 > > + maxItems: 3 > > + > > + clock-names: > > + minItems: 1 > > + maxItems: 3 > > Move the descriptions and names here. Then in the if/then schemas just set > the number of items to 1 or 3 as appropriate. > > Rob Thank you for your review. I will update by reflecting the fixes. Thanks, Sunyeal Hong
Hello Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Wednesday, July 24, 2024 7:12 PM > To: Sunyeal Hong <sunyeal.hong@samsung.com>; Sylwester Nawrocki > <s.nawrocki@samsung.com>; Chanwoo Choi <cw00.choi@samsung.com>; Alim > Akhtar <alim.akhtar@samsung.com>; Michael Turquette > <mturquette@baylibre.com>; Stephen Boyd <sboyd@kernel.org>; Rob Herring > <robh@kernel.org>; Conor Dooley <conor+dt@kernel.org> > Cc: linux-samsung-soc@vger.kernel.org; linux-clk@vger.kernel.org; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org > Subject: Re: [PATCH v4 1/4] dt-bindings: clock: add ExynosAuto v920 SoC > CMU bindings > > On 23/07/2024 00:33, Sunyeal Hong wrote: > > Add dt-schema for ExynosAuto v920 SoC clock controller. > > Add device tree clock binding definitions for below CMU blocks. > > > > - CMU_TOP > > - CMU_PERIC0 > > > > Signed-off-by: Sunyeal Hong <sunyeal.hong@samsung.com> > > --- > > .../clock/samsung,exynosautov920-clock.yaml | 115 +++++++++++ > > .../clock/samsung,exynosautov920.h | 191 ++++++++++++++++++ > > 2 files changed, 306 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/clock/samsung,exynosautov920-clock.y > > aml create mode 100644 > > include/dt-bindings/clock/samsung,exynosautov920.h > > > > diff --git > > a/Documentation/devicetree/bindings/clock/samsung,exynosautov920-clock > > .yaml > > b/Documentation/devicetree/bindings/clock/samsung,exynosautov920-clock > > .yaml > > new file mode 100644 > > index 000000000000..90f9f17da959 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/samsung,exynosautov920-c > > +++ lock.yaml > > @@ -0,0 +1,115 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > +--- > > +$id: > > +https://protect2.fireeye.com/v1/url?k=79ef652b-1864700b-79eeee64-74fe > > +485fb347-9d0b27f7b9bcf4cc&q=1&e=af4d44eb-4030-4020-8a28-394e2a873516& > > +u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fclock%2Fsamsung%2Cexynosaut > > +ov920-clock.yaml%23 > > +$schema: > > +https://protect2.fireeye.com/v1/url?k=4f1f645c-2e94717c-4f1eef13-74fe > > +485fb347-e7ad6ce5885cf0ba&q=1&e=af4d44eb-4030-4020-8a28-394e2a873516& > > +u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 > > + > > +title: Samsung ExynosAuto v920 SoC clock controller > > + > > +maintainers: > > + - Sunyeal Hong <sunyeal.hong@samsung.com> > > + - Chanwoo Choi <cw00.choi@samsung.com> > > + - Krzysztof Kozlowski <krzk@kernel.org> > > + - Sylwester Nawrocki <s.nawrocki@samsung.com> > > + > > +description: | > > + ExynosAuto v920 clock controller is comprised of several CMU units, > > +generating > > + clocks for different domains. Those CMU units are modeled as > > +separate device > > + tree nodes, and might depend on each other. Root clocks in that > > +clock tree are > > + two external clocks:: OSCCLK/XTCXO (38.4 MHz) and RTCCLK/XrtcXTI > (32768 Hz). > > + The external OSCCLK must be defined as fixed-rate clock in dts. > > + > > + CMU_TOP is a top-level CMU, where all base clocks are prepared > > + using PLLs and dividers; all other clocks of function blocks (other > > + CMUs) are usually derived from CMU_TOP. > > + > > + Each clock is assigned an identifier and client nodes can use this > > + identifier to specify the clock which they consume. All clocks > > + available for usage in clock consumer nodes are defined as > > + preprocessor macros in 'include/dt- > bindings/clock/samsung,exynosautov920.h' header. > > + > > +properties: > > + compatible: > > + enum: > > + - samsung,exynosautov920-cmu-top > > + - samsung,exynosautov920-cmu-peric0 > > + > > + clocks: > > + minItems: 1 > > + maxItems: 3 > > + > > + clock-names: > > + minItems: 1 > > + maxItems: 3 > > + > > + "#clock-cells": > > + const: 1 > > + > > + reg: > > + maxItems: 1 > > + > > +allOf: > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: samsung,exynosautov920-cmu-top > > + > > + then: > > + properties: > > + clocks: > > + items: > > + - description: External reference clock (38.4 MHz) > > + > > + clock-names: > > + items: > > + - const: oscclk > > + > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: samsung,exynosautov920-cmu-peric0 > > + > > + then: > > + properties: > > + clocks: > > + items: > > + - description: External reference clock (38.4 MHz) > > + - description: CMU_PERIC0 NOC clock (from CMU_TOP) > > + - description: CMU_PERIC0 IP clock (from CMU_TOP) > > + > > + clock-names: > > + items: > > + - const: oscclk > > + - const: noc > > + - const: ip > > + > > +required: > > + - compatible > > + - "#clock-cells" > > + - clocks > > + - clock-names > > + - reg > > + > > +additionalProperties: false > > + > > +examples: > > + # Clock controller node for CMU_PERIC0 > > + - | > > + #include <dt-bindings/clock/samsung,exynosautov920.h> > > + > > + cmu_peric0: clock-controller@10800000 { > > + compatible = "samsung,exynosautov920-cmu-peric0"; > > + reg = <0x10800000 0x8000>; > > + #clock-cells = <1>; > > + > > + clocks = <&xtcxo>, > > + <&cmu_top DOUT_CLKCMU_PERIC0_NOC>, > > + <&cmu_top DOUT_CLKCMU_PERIC0_IP>; > > + clock-names = "oscclk", > > + "noc", > > + "ip"; > > + }; > > + > > +... > > diff --git a/include/dt-bindings/clock/samsung,exynosautov920.h > > b/include/dt-bindings/clock/samsung,exynosautov920.h > > new file mode 100644 > > index 000000000000..ad89728a4396 > > --- /dev/null > > +++ b/include/dt-bindings/clock/samsung,exynosautov920.h > > @@ -0,0 +1,191 @@ > > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ > > +/* > > + * Copyright (c) 2024 Samsung Electronics Co., Ltd. > > + * Author: Sunyeal Hong <sunyeal.hong@samsung.com> > > + * > > + * Device Tree binding constants for ExynosAuto v920 clock controller. > > + */ > > + > > +#ifndef _DT_BINDINGS_CLOCK_EXYNOSAUTOV920_H > > +#define _DT_BINDINGS_CLOCK_EXYNOSAUTOV920_H > > + > > +/* CMU_TOP */ > > +#define FOUT_SHARED0_PLL 1 > > +#define FOUT_SHARED1_PLL 2 > > +#define FOUT_SHARED2_PLL 3 > > +#define FOUT_SHARED3_PLL 4 > > +#define FOUT_SHARED4_PLL 5 > > +#define FOUT_SHARED5_PLL 6 > > +#define FOUT_MMC_PLL 7 > > + > > +/* MUX in CMU_TOP */ > > +#define MOUT_SHARED0_PLL 101 > > This is some odd numbering. Numbers start from 0 or 1 and are continuous. > Okay, I will update. > > Best regards, > Krzysztof Thanks, Sunyeal Hong.
Hello Rob, > -----Original Message----- > From: sunyeal.hong <sunyeal.hong@samsung.com> > Sent: Thursday, July 25, 2024 10:24 AM > To: 'Rob Herring' <robh@kernel.org> > Cc: 'Krzysztof Kozlowski' <krzk@kernel.org>; 'Sylwester Nawrocki' > <s.nawrocki@samsung.com>; 'Chanwoo Choi' <cw00.choi@samsung.com>; 'Alim > Akhtar' <alim.akhtar@samsung.com>; 'Michael Turquette' > <mturquette@baylibre.com>; 'Stephen Boyd' <sboyd@kernel.org>; 'Conor > Dooley' <conor+dt@kernel.org>; linux-samsung-soc@vger.kernel.org; linux- > clk@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: RE: [PATCH v4 1/4] dt-bindings: clock: add ExynosAuto v920 SoC > CMU bindings > > Hello Rob, > > > -----Original Message----- > > From: Rob Herring <robh@kernel.org> > > Sent: Wednesday, July 24, 2024 5:57 AM > > To: Sunyeal Hong <sunyeal.hong@samsung.com> > > Cc: Krzysztof Kozlowski <krzk@kernel.org>; Sylwester Nawrocki > > <s.nawrocki@samsung.com>; Chanwoo Choi <cw00.choi@samsung.com>; Alim > > Akhtar <alim.akhtar@samsung.com>; Michael Turquette > > <mturquette@baylibre.com>; Stephen Boyd <sboyd@kernel.org>; Conor > > Dooley <conor+dt@kernel.org>; linux-samsung-soc@vger.kernel.org; > > linux- clk@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- > > kernel@lists.infradead.org; linux-kernel@vger.kernel.org > > Subject: Re: [PATCH v4 1/4] dt-bindings: clock: add ExynosAuto v920 > > SoC CMU bindings > > > > On Tue, Jul 23, 2024 at 07:33:30AM +0900, Sunyeal Hong wrote: > > > Add dt-schema for ExynosAuto v920 SoC clock controller. > > > Add device tree clock binding definitions for below CMU blocks. > > > > > > - CMU_TOP > > > - CMU_PERIC0 > > > > > > Signed-off-by: Sunyeal Hong <sunyeal.hong@samsung.com> > > > --- > > > .../clock/samsung,exynosautov920-clock.yaml | 115 +++++++++++ > > > .../clock/samsung,exynosautov920.h | 191 ++++++++++++++++++ > > > 2 files changed, 306 insertions(+) > > > create mode 100644 > > > Documentation/devicetree/bindings/clock/samsung,exynosautov920-clock > > > .y > > > aml create mode 100644 > > > include/dt-bindings/clock/samsung,exynosautov920.h > > > > > > diff --git > > > a/Documentation/devicetree/bindings/clock/samsung,exynosautov920-clo > > > ck > > > .yaml > > > b/Documentation/devicetree/bindings/clock/samsung,exynosautov920-clo > > > ck > > > .yaml > > > new file mode 100644 > > > index 000000000000..90f9f17da959 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/clock/samsung,exynosautov920 > > > +++ -c > > > +++ lock.yaml > > > @@ -0,0 +1,115 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > > +--- > > > +$id: > > > +https://protect2.fireeye.com/v1/url?k=9932a88e-c6ae81a4-993323c1-00 > > > +0b > > > +abe598f7-779f1e959ac8eab9&q=1&e=539edfa4-b4e4-460a-93f4-1e6f1703094 > > > +5& > > > +u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fclock%2Fsamsung%2Cexynosa > > > +ut > > > +ov920-clock.yaml%23 > > > +$schema: > > > +https://protect2.fireeye.com/v1/url?k=4dbf6fb9-12234693-4dbee4f6-00 > > > +0b > > > +abe598f7-363a2f64c69b9542&q=1&e=539edfa4-b4e4-460a-93f4-1e6f1703094 > > > +5& > > > +u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 > > > + > > > +title: Samsung ExynosAuto v920 SoC clock controller > > > + > > > +maintainers: > > > + - Sunyeal Hong <sunyeal.hong@samsung.com> > > > + - Chanwoo Choi <cw00.choi@samsung.com> > > > + - Krzysztof Kozlowski <krzk@kernel.org> > > > + - Sylwester Nawrocki <s.nawrocki@samsung.com> > > > + > > > +description: | > > > + ExynosAuto v920 clock controller is comprised of several CMU > > > +units, generating > > > + clocks for different domains. Those CMU units are modeled as > > > +separate device > > > + tree nodes, and might depend on each other. Root clocks in that > > > +clock tree are > > > + two external clocks:: OSCCLK/XTCXO (38.4 MHz) and RTCCLK/XrtcXTI > > (32768 Hz). > > > + The external OSCCLK must be defined as fixed-rate clock in dts. > > > + > > > + CMU_TOP is a top-level CMU, where all base clocks are prepared > > > + using PLLs and dividers; all other clocks of function blocks > > > + (other > > > + CMUs) are usually derived from CMU_TOP. > > > + > > > + Each clock is assigned an identifier and client nodes can use > > > + this identifier to specify the clock which they consume. All > > > + clocks available for usage in clock consumer nodes are defined as > > > + preprocessor macros in 'include/dt- > > bindings/clock/samsung,exynosautov920.h' header. > > > + > > > +properties: > > > + compatible: > > > + enum: > > > + - samsung,exynosautov920-cmu-top > > > + - samsung,exynosautov920-cmu-peric0 > > > + > > > + clocks: > > > + minItems: 1 > > > + maxItems: 3 > > > + > > > + clock-names: > > > + minItems: 1 > > > + maxItems: 3 > > > > Move the descriptions and names here. Then in the if/then schemas just > > set the number of items to 1 or 3 as appropriate. > > > > Rob > > Thank you for your review. I will update by reflecting the fixes. > > Thanks, > Sunyeal Hong > > I faced a new problem after modifying it as you reviewed. For example, if I declare a new cmu block that uses only osclk and noc to dt, it seems that a problem occurs in check dtb. - yaml properties: compatible: enum: - samsung,exynosautov920-cmu-top - samsung,exynosautov920-cmu-peric0 - samsung,exynosautov920-cmu-misc clocks: minItems: 1 items: - description: External reference clock (38.4 MHz) - description: Block IP clock (from CMU_TOP) - description: Block NOC clock (from CMU_TOP) clock-names: minItems: 1 items: - const: oscclk - const: ip - const: noc - dts cmu_misc: clock-controller@10020000 { compatible = "samsung,exynosautov920-cmu-misc"; reg = <0x10020000 0x8000>; #clock-cells = <1>; clocks = <&xtcxo>, <&cmu_top DOUT_CLKCMU_MISC_NOC>; clock-names = "oscclk", "noc"; }; In this case, can you tell me how to handle it? And if a new clock item is added and a new cmu block uses only the clock item added and oscclk, a problem may occur. Thanks, Sunyeal Hong.
On 25/07/2024 05:03, sunyeal.hong wrote: > - dts > cmu_misc: clock-controller@10020000 { > compatible = "samsung,exynosautov920-cmu-misc"; > reg = <0x10020000 0x8000>; > #clock-cells = <1>; > > clocks = <&xtcxo>, > <&cmu_top DOUT_CLKCMU_MISC_NOC>; > clock-names = "oscclk", > "noc"; > }; > > In this case, can you tell me how to handle it? > And if a new clock item is added and a new cmu block uses only the clock item added and oscclk, a problem may occur. The same problem was in your original version, so why suddenly it appeared? Anyway, why clock would be missing? You just wrote in the bindings that there is such input clock. Best regards, Krzysztof
Hello Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Thursday, July 25, 2024 3:21 PM > To: sunyeal.hong <sunyeal.hong@samsung.com>; 'Rob Herring' > <robh@kernel.org> > Cc: 'Sylwester Nawrocki' <s.nawrocki@samsung.com>; 'Chanwoo Choi' > <cw00.choi@samsung.com>; 'Alim Akhtar' <alim.akhtar@samsung.com>; 'Michael > Turquette' <mturquette@baylibre.com>; 'Stephen Boyd' <sboyd@kernel.org>; > 'Conor Dooley' <conor+dt@kernel.org>; linux-samsung-soc@vger.kernel.org; > linux-clk@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v4 1/4] dt-bindings: clock: add ExynosAuto v920 SoC > CMU bindings > > On 25/07/2024 05:03, sunyeal.hong wrote: > > > - dts > > cmu_misc: clock-controller@10020000 { > > compatible = "samsung,exynosautov920-cmu-misc"; > > reg = <0x10020000 0x8000>; > > #clock-cells = <1>; > > > > clocks = <&xtcxo>, > > <&cmu_top DOUT_CLKCMU_MISC_NOC>; > > clock-names = "oscclk", > > "noc"; > > }; > > > > In this case, can you tell me how to handle it? > > And if a new clock item is added and a new cmu block uses only the clock > item added and oscclk, a problem may occur. > > The same problem was in your original version, so why suddenly it appeared? > > Anyway, why clock would be missing? You just wrote in the bindings that > there is such input clock. > > Best regards, > Krzysztof > If I reflect Rob's review, it will be changed as below. - yaml properties: compatible: enum: - samsung,exynosautov920-cmu-top - samsung,exynosautov920-cmu-peric0 clocks: minItems: 1 items: - description: External reference clock (38.4 MHz) - description: Block IP clock (from CMU_TOP) - description: Block NOC clock (from CMU_TOP) clock-names: minItems: 1 items: - const: oscclk - const: ip - const: noc "#clock-cells": const: 1 reg: maxItems: 1 if: properties: compatible: enum: - samsung,exynosautov920-cmu-misc then: properties: clocks: minItems: 2 maxItems: 2 clock-names: minItems: 2 maxItems: 2 - device tree cmu_misc: clock-controller@10020000 { compatible = "samsung,exynosautov920-cmu-misc"; reg = <0x10020000 0x8000>; #clock-cells = <1>; clocks = <&xtcxo>, <&cmu_top DOUT_CLKCMU_MISC_NOC>; clock-names = "oscclk", "noc"; }; In this case, ip should be used after oscclk, but misc does not use ip, so there is a problem in dt check. The code of v4 version has clock items for each block, so there was no problem like this. - yaml(v4) if: properties: compatible: contains: const: samsung,exynosautov920-cmu-misc then: properties: clocks: items: - description: External reference clock (38.4 MHz) - description: CMU_MISC NOC clock (from CMU_MISC) clock-names: items: - const: oscclk - const: noc If there is anything I misunderstand, please guide me. Thanks, Sunyeal Hong.
On 25/07/2024 08:35, sunyeal.hong wrote: > Hello Krzysztof, > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzk@kernel.org> >> Sent: Thursday, July 25, 2024 3:21 PM >> To: sunyeal.hong <sunyeal.hong@samsung.com>; 'Rob Herring' >> <robh@kernel.org> >> Cc: 'Sylwester Nawrocki' <s.nawrocki@samsung.com>; 'Chanwoo Choi' >> <cw00.choi@samsung.com>; 'Alim Akhtar' <alim.akhtar@samsung.com>; 'Michael >> Turquette' <mturquette@baylibre.com>; 'Stephen Boyd' <sboyd@kernel.org>; >> 'Conor Dooley' <conor+dt@kernel.org>; linux-samsung-soc@vger.kernel.org; >> linux-clk@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- >> kernel@lists.infradead.org; linux-kernel@vger.kernel.org >> Subject: Re: [PATCH v4 1/4] dt-bindings: clock: add ExynosAuto v920 SoC >> CMU bindings >> >> On 25/07/2024 05:03, sunyeal.hong wrote: >> >>> - dts >>> cmu_misc: clock-controller@10020000 { >>> compatible = "samsung,exynosautov920-cmu-misc"; >>> reg = <0x10020000 0x8000>; >>> #clock-cells = <1>; >>> >>> clocks = <&xtcxo>, >>> <&cmu_top DOUT_CLKCMU_MISC_NOC>; >>> clock-names = "oscclk", >>> "noc"; >>> }; >>> >>> In this case, can you tell me how to handle it? >>> And if a new clock item is added and a new cmu block uses only the clock >> item added and oscclk, a problem may occur. >> >> The same problem was in your original version, so why suddenly it appeared? >> >> Anyway, why clock would be missing? You just wrote in the bindings that >> there is such input clock. >> >> Best regards, >> Krzysztof >> > > If I reflect Rob's review, it will be changed as below. > > - yaml > properties: > compatible: > enum: > - samsung,exynosautov920-cmu-top > - samsung,exynosautov920-cmu-peric0 > > clocks: > minItems: 1 > items: > - description: External reference clock (38.4 MHz) > - description: Block IP clock (from CMU_TOP) > - description: Block NOC clock (from CMU_TOP) > > clock-names: > minItems: 1 > items: > - const: oscclk > - const: ip > - const: noc > > "#clock-cells": > const: 1 > > reg: > maxItems: 1 > > if: > properties: > compatible: > enum: > - samsung,exynosautov920-cmu-misc > > then: > properties: > clocks: > minItems: 2 > maxItems: 2 > > clock-names: > minItems: 2 > maxItems: 2 > > - device tree > cmu_misc: clock-controller@10020000 { > compatible = "samsung,exynosautov920-cmu-misc"; > reg = <0x10020000 0x8000>; > #clock-cells = <1>; > > clocks = <&xtcxo>, > <&cmu_top DOUT_CLKCMU_MISC_NOC>; > clock-names = "oscclk", > "noc"; > }; > > In this case, ip should be used after oscclk, but misc does not use ip, so there is a problem in dt check. > > The code of v4 version has clock items for each block, so there was no problem like this. > - yaml(v4) > > if: > properties: > compatible: > contains: > const: samsung,exynosautov920-cmu-misc > > then: > properties: > clocks: > items: > - description: External reference clock (38.4 MHz) > - description: CMU_MISC NOC clock (from CMU_MISC) > > clock-names: > items: > - const: oscclk > - const: noc > > If there is anything I misunderstand, please guide me. > You did not address my questions at all instead just copied again the same. It is not how it works. I am not going to discuss like this. Best regards, Krzysztof
On 25/07/2024 08:37, Krzysztof Kozlowski wrote: >> then: >> properties: >> clocks: >> items: >> - description: External reference clock (38.4 MHz) >> - description: CMU_MISC NOC clock (from CMU_MISC) >> >> clock-names: >> items: >> - const: oscclk >> - const: noc >> >> If there is anything I misunderstand, please guide me. >> > > You did not address my questions at all instead just copied again the > same. It is not how it works. > > I am not going to discuss like this. And in case it is still unclear - just look at your bindings and DTS. They say you have three clocks! Best regards, Krzysztof
Hello Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Thursday, July 25, 2024 3:41 PM > To: sunyeal.hong <sunyeal.hong@samsung.com>; 'Rob Herring' > <robh@kernel.org> > Cc: 'Sylwester Nawrocki' <s.nawrocki@samsung.com>; 'Chanwoo Choi' > <cw00.choi@samsung.com>; 'Alim Akhtar' <alim.akhtar@samsung.com>; 'Michael > Turquette' <mturquette@baylibre.com>; 'Stephen Boyd' <sboyd@kernel.org>; > 'Conor Dooley' <conor+dt@kernel.org>; linux-samsung-soc@vger.kernel.org; > linux-clk@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v4 1/4] dt-bindings: clock: add ExynosAuto v920 SoC > CMU bindings > > On 25/07/2024 08:37, Krzysztof Kozlowski wrote: > >> then: > >> properties: > >> clocks: > >> items: > >> - description: External reference clock (38.4 MHz) > >> - description: CMU_MISC NOC clock (from CMU_MISC) > >> > >> clock-names: > >> items: > >> - const: oscclk > >> - const: noc > >> > >> If there is anything I misunderstand, please guide me. > >> > > > > You did not address my questions at all instead just copied again the > > same. It is not how it works. > > > > I am not going to discuss like this. > > And in case it is still unclear - just look at your bindings and DTS. > They say you have three clocks! > > Best regards, > Krzysztof > Let me answer your questions first. In the existing V4 patch, clock items were declared in if then for each block, so there was no problem. If modified according to Rob's comment, problems may occur as the input clock is configured differently for each block. I think it would be better to keep the bindings in v4 patch form like the existing exynos models. Thanks for your comment. Best regards, Sunyeal
On 25/07/2024 09:14, sunyeal.hong wrote: > Hello Krzysztof, > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzk@kernel.org> >> Sent: Thursday, July 25, 2024 3:41 PM >> To: sunyeal.hong <sunyeal.hong@samsung.com>; 'Rob Herring' >> <robh@kernel.org> >> Cc: 'Sylwester Nawrocki' <s.nawrocki@samsung.com>; 'Chanwoo Choi' >> <cw00.choi@samsung.com>; 'Alim Akhtar' <alim.akhtar@samsung.com>; 'Michael >> Turquette' <mturquette@baylibre.com>; 'Stephen Boyd' <sboyd@kernel.org>; >> 'Conor Dooley' <conor+dt@kernel.org>; linux-samsung-soc@vger.kernel.org; >> linux-clk@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- >> kernel@lists.infradead.org; linux-kernel@vger.kernel.org >> Subject: Re: [PATCH v4 1/4] dt-bindings: clock: add ExynosAuto v920 SoC >> CMU bindings >> >> On 25/07/2024 08:37, Krzysztof Kozlowski wrote: >>>> then: >>>> properties: >>>> clocks: >>>> items: >>>> - description: External reference clock (38.4 MHz) >>>> - description: CMU_MISC NOC clock (from CMU_MISC) >>>> >>>> clock-names: >>>> items: >>>> - const: oscclk >>>> - const: noc >>>> >>>> If there is anything I misunderstand, please guide me. >>>> >>> >>> You did not address my questions at all instead just copied again the >>> same. It is not how it works. >>> >>> I am not going to discuss like this. >> >> And in case it is still unclear - just look at your bindings and DTS. >> They say you have three clocks! >> >> Best regards, >> Krzysztof >> > > Let me answer your questions first. > In the existing V4 patch, clock items were declared in if then for each block, so there was no problem. No. Again, look at your binding and DTS. 1. What clocks did you define for cmu-top? 2. What clocks did you define for cmu-peric0? Rob's advice is reasonable and you must follow it, unless you are not telling us something. There is no other choice, no other compatibles, no other devices. > If modified according to Rob's comment, problems may occur as the input clock is configured differently for each block. But it is not! Look at your binding. Best regards, Krzysztof
Hello Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Thursday, July 25, 2024 4:32 PM > To: sunyeal.hong <sunyeal.hong@samsung.com>; 'Rob Herring' > <robh@kernel.org> > Cc: 'Sylwester Nawrocki' <s.nawrocki@samsung.com>; 'Chanwoo Choi' > <cw00.choi@samsung.com>; 'Alim Akhtar' <alim.akhtar@samsung.com>; 'Michael > Turquette' <mturquette@baylibre.com>; 'Stephen Boyd' <sboyd@kernel.org>; > 'Conor Dooley' <conor+dt@kernel.org>; linux-samsung-soc@vger.kernel.org; > linux-clk@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v4 1/4] dt-bindings: clock: add ExynosAuto v920 SoC > CMU bindings > > On 25/07/2024 09:14, sunyeal.hong wrote: > > Hello Krzysztof, > > > >> -----Original Message----- > >> From: Krzysztof Kozlowski <krzk@kernel.org> > >> Sent: Thursday, July 25, 2024 3:41 PM > >> To: sunyeal.hong <sunyeal.hong@samsung.com>; 'Rob Herring' > >> <robh@kernel.org> > >> Cc: 'Sylwester Nawrocki' <s.nawrocki@samsung.com>; 'Chanwoo Choi' > >> <cw00.choi@samsung.com>; 'Alim Akhtar' <alim.akhtar@samsung.com>; > >> 'Michael Turquette' <mturquette@baylibre.com>; 'Stephen Boyd' > >> <sboyd@kernel.org>; 'Conor Dooley' <conor+dt@kernel.org>; > >> linux-samsung-soc@vger.kernel.org; > >> linux-clk@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- > >> kernel@lists.infradead.org; linux-kernel@vger.kernel.org > >> Subject: Re: [PATCH v4 1/4] dt-bindings: clock: add ExynosAuto v920 > >> SoC CMU bindings > >> > >> On 25/07/2024 08:37, Krzysztof Kozlowski wrote: > >>>> then: > >>>> properties: > >>>> clocks: > >>>> items: > >>>> - description: External reference clock (38.4 MHz) > >>>> - description: CMU_MISC NOC clock (from CMU_MISC) > >>>> > >>>> clock-names: > >>>> items: > >>>> - const: oscclk > >>>> - const: noc > >>>> > >>>> If there is anything I misunderstand, please guide me. > >>>> > >>> > >>> You did not address my questions at all instead just copied again > >>> the same. It is not how it works. > >>> > >>> I am not going to discuss like this. > >> > >> And in case it is still unclear - just look at your bindings and DTS. > >> They say you have three clocks! > >> > >> Best regards, > >> Krzysztof > >> > > > > Let me answer your questions first. > > In the existing V4 patch, clock items were declared in if then for each > block, so there was no problem. > > No. Again, look at your binding and DTS. > > 1. What clocks did you define for cmu-top? Cmu-top has one clock(oscclk). > 2. What clocks did you define for cmu-peric0? Cmu-peric0 has three clocks(oscclk, noc and ip) > > Rob's advice is reasonable and you must follow it, unless you are not > telling us something. There is no other choice, no other compatibles, no > other devices. > Yes, that's right. In this patch, modifications are possible according to Rob's review. > > If modified according to Rob's comment, problems may occur as the input > clock is configured differently for each block. > > But it is not! Look at your binding. The reason I mentioned this was to ask how to handle problems that may occur when adding cmu for a new block in a new patch. As you mentioned, this issue does not exist in this patch. > > > Best regards, > Krzysztof Best regard, sunyeal
On 25/07/2024 09:50, sunyeal.hong wrote: > Hello Krzysztof, > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzk@kernel.org> >> Sent: Thursday, July 25, 2024 4:32 PM >> To: sunyeal.hong <sunyeal.hong@samsung.com>; 'Rob Herring' >> <robh@kernel.org> >> Cc: 'Sylwester Nawrocki' <s.nawrocki@samsung.com>; 'Chanwoo Choi' >> <cw00.choi@samsung.com>; 'Alim Akhtar' <alim.akhtar@samsung.com>; 'Michael >> Turquette' <mturquette@baylibre.com>; 'Stephen Boyd' <sboyd@kernel.org>; >> 'Conor Dooley' <conor+dt@kernel.org>; linux-samsung-soc@vger.kernel.org; >> linux-clk@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- >> kernel@lists.infradead.org; linux-kernel@vger.kernel.org >> Subject: Re: [PATCH v4 1/4] dt-bindings: clock: add ExynosAuto v920 SoC >> CMU bindings >> >> On 25/07/2024 09:14, sunyeal.hong wrote: >>> Hello Krzysztof, >>> >>>> -----Original Message----- >>>> From: Krzysztof Kozlowski <krzk@kernel.org> >>>> Sent: Thursday, July 25, 2024 3:41 PM >>>> To: sunyeal.hong <sunyeal.hong@samsung.com>; 'Rob Herring' >>>> <robh@kernel.org> >>>> Cc: 'Sylwester Nawrocki' <s.nawrocki@samsung.com>; 'Chanwoo Choi' >>>> <cw00.choi@samsung.com>; 'Alim Akhtar' <alim.akhtar@samsung.com>; >>>> 'Michael Turquette' <mturquette@baylibre.com>; 'Stephen Boyd' >>>> <sboyd@kernel.org>; 'Conor Dooley' <conor+dt@kernel.org>; >>>> linux-samsung-soc@vger.kernel.org; >>>> linux-clk@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- >>>> kernel@lists.infradead.org; linux-kernel@vger.kernel.org >>>> Subject: Re: [PATCH v4 1/4] dt-bindings: clock: add ExynosAuto v920 >>>> SoC CMU bindings >>>> >>>> On 25/07/2024 08:37, Krzysztof Kozlowski wrote: >>>>>> then: >>>>>> properties: >>>>>> clocks: >>>>>> items: >>>>>> - description: External reference clock (38.4 MHz) >>>>>> - description: CMU_MISC NOC clock (from CMU_MISC) >>>>>> >>>>>> clock-names: >>>>>> items: >>>>>> - const: oscclk >>>>>> - const: noc >>>>>> >>>>>> If there is anything I misunderstand, please guide me. >>>>>> >>>>> >>>>> You did not address my questions at all instead just copied again >>>>> the same. It is not how it works. >>>>> >>>>> I am not going to discuss like this. >>>> >>>> And in case it is still unclear - just look at your bindings and DTS. >>>> They say you have three clocks! >>>> >>>> Best regards, >>>> Krzysztof >>>> >>> >>> Let me answer your questions first. >>> In the existing V4 patch, clock items were declared in if then for each >> block, so there was no problem. >> >> No. Again, look at your binding and DTS. >> >> 1. What clocks did you define for cmu-top? > Cmu-top has one clock(oscclk). >> 2. What clocks did you define for cmu-peric0? > Cmu-peric0 has three clocks(oscclk, noc and ip) >> >> Rob's advice is reasonable and you must follow it, unless you are not >> telling us something. There is no other choice, no other compatibles, no >> other devices. >> > Yes, that's right. In this patch, modifications are possible according to Rob's review. >>> If modified according to Rob's comment, problems may occur as the input >> clock is configured differently for each block. >> >> But it is not! Look at your binding. > The reason I mentioned this was to ask how to handle problems that may occur when adding cmu for a new block in a new patch. > As you mentioned, this issue does not exist in this patch. A new block? And how do we know about it? Bindings are supposed to be complete. We see bindings and you receive review. Post complete bindings. Best regards, Krzysztof
Hello Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Thursday, July 25, 2024 4:56 PM > To: sunyeal.hong <sunyeal.hong@samsung.com>; 'Rob Herring' > <robh@kernel.org> > Cc: 'Sylwester Nawrocki' <s.nawrocki@samsung.com>; 'Chanwoo Choi' > <cw00.choi@samsung.com>; 'Alim Akhtar' <alim.akhtar@samsung.com>; 'Michael > Turquette' <mturquette@baylibre.com>; 'Stephen Boyd' <sboyd@kernel.org>; > 'Conor Dooley' <conor+dt@kernel.org>; linux-samsung-soc@vger.kernel.org; > linux-clk@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v4 1/4] dt-bindings: clock: add ExynosAuto v920 SoC > CMU bindings > > On 25/07/2024 09:50, sunyeal.hong wrote: > > Hello Krzysztof, > > > >> -----Original Message----- > >> From: Krzysztof Kozlowski <krzk@kernel.org> > >> Sent: Thursday, July 25, 2024 4:32 PM > >> To: sunyeal.hong <sunyeal.hong@samsung.com>; 'Rob Herring' > >> <robh@kernel.org> > >> Cc: 'Sylwester Nawrocki' <s.nawrocki@samsung.com>; 'Chanwoo Choi' > >> <cw00.choi@samsung.com>; 'Alim Akhtar' <alim.akhtar@samsung.com>; > >> 'Michael Turquette' <mturquette@baylibre.com>; 'Stephen Boyd' > >> <sboyd@kernel.org>; 'Conor Dooley' <conor+dt@kernel.org>; > >> linux-samsung-soc@vger.kernel.org; > >> linux-clk@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- > >> kernel@lists.infradead.org; linux-kernel@vger.kernel.org > >> Subject: Re: [PATCH v4 1/4] dt-bindings: clock: add ExynosAuto v920 > >> SoC CMU bindings > >> > >> On 25/07/2024 09:14, sunyeal.hong wrote: > >>> Hello Krzysztof, > >>> > >>>> -----Original Message----- > >>>> From: Krzysztof Kozlowski <krzk@kernel.org> > >>>> Sent: Thursday, July 25, 2024 3:41 PM > >>>> To: sunyeal.hong <sunyeal.hong@samsung.com>; 'Rob Herring' > >>>> <robh@kernel.org> > >>>> Cc: 'Sylwester Nawrocki' <s.nawrocki@samsung.com>; 'Chanwoo Choi' > >>>> <cw00.choi@samsung.com>; 'Alim Akhtar' <alim.akhtar@samsung.com>; > >>>> 'Michael Turquette' <mturquette@baylibre.com>; 'Stephen Boyd' > >>>> <sboyd@kernel.org>; 'Conor Dooley' <conor+dt@kernel.org>; > >>>> linux-samsung-soc@vger.kernel.org; > >>>> linux-clk@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- > >>>> kernel@lists.infradead.org; linux-kernel@vger.kernel.org > >>>> Subject: Re: [PATCH v4 1/4] dt-bindings: clock: add ExynosAuto v920 > >>>> SoC CMU bindings > >>>> > >>>> On 25/07/2024 08:37, Krzysztof Kozlowski wrote: > >>>>>> then: > >>>>>> properties: > >>>>>> clocks: > >>>>>> items: > >>>>>> - description: External reference clock (38.4 MHz) > >>>>>> - description: CMU_MISC NOC clock (from CMU_MISC) > >>>>>> > >>>>>> clock-names: > >>>>>> items: > >>>>>> - const: oscclk > >>>>>> - const: noc > >>>>>> > >>>>>> If there is anything I misunderstand, please guide me. > >>>>>> > >>>>> > >>>>> You did not address my questions at all instead just copied again > >>>>> the same. It is not how it works. > >>>>> > >>>>> I am not going to discuss like this. > >>>> > >>>> And in case it is still unclear - just look at your bindings and DTS. > >>>> They say you have three clocks! > >>>> > >>>> Best regards, > >>>> Krzysztof > >>>> > >>> > >>> Let me answer your questions first. > >>> In the existing V4 patch, clock items were declared in if then for > >>> each > >> block, so there was no problem. > >> > >> No. Again, look at your binding and DTS. > >> > >> 1. What clocks did you define for cmu-top? > > Cmu-top has one clock(oscclk). > >> 2. What clocks did you define for cmu-peric0? > > Cmu-peric0 has three clocks(oscclk, noc and ip) > >> > >> Rob's advice is reasonable and you must follow it, unless you are not > >> telling us something. There is no other choice, no other compatibles, > >> no other devices. > >> > > Yes, that's right. In this patch, modifications are possible according > to Rob's review. > >>> If modified according to Rob's comment, problems may occur as the > >>> input > >> clock is configured differently for each block. > >> > >> But it is not! Look at your binding. > > The reason I mentioned this was to ask how to handle problems that may > occur when adding cmu for a new block in a new patch. > > As you mentioned, this issue does not exist in this patch. > > A new block? And how do we know about it? Bindings are supposed to be > complete. We see bindings and you receive review. > > Post complete bindings. > > Best regards, > Krzysztof > I understand your intention. I will re-upload the patch based on Rob's review based on the current patch. Best regards, sunyeal
diff --git a/Documentation/devicetree/bindings/clock/samsung,exynosautov920-clock.yaml b/Documentation/devicetree/bindings/clock/samsung,exynosautov920-clock.yaml new file mode 100644 index 000000000000..90f9f17da959 --- /dev/null +++ b/Documentation/devicetree/bindings/clock/samsung,exynosautov920-clock.yaml @@ -0,0 +1,115 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/clock/samsung,exynosautov920-clock.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Samsung ExynosAuto v920 SoC clock controller + +maintainers: + - Sunyeal Hong <sunyeal.hong@samsung.com> + - Chanwoo Choi <cw00.choi@samsung.com> + - Krzysztof Kozlowski <krzk@kernel.org> + - Sylwester Nawrocki <s.nawrocki@samsung.com> + +description: | + ExynosAuto v920 clock controller is comprised of several CMU units, generating + clocks for different domains. Those CMU units are modeled as separate device + tree nodes, and might depend on each other. Root clocks in that clock tree are + two external clocks:: OSCCLK/XTCXO (38.4 MHz) and RTCCLK/XrtcXTI (32768 Hz). + The external OSCCLK must be defined as fixed-rate clock in dts. + + CMU_TOP is a top-level CMU, where all base clocks are prepared using PLLs and + dividers; all other clocks of function blocks (other CMUs) are usually + derived from CMU_TOP. + + Each clock is assigned an identifier and client nodes can use this identifier + to specify the clock which they consume. All clocks available for usage + in clock consumer nodes are defined as preprocessor macros in + 'include/dt-bindings/clock/samsung,exynosautov920.h' header. + +properties: + compatible: + enum: + - samsung,exynosautov920-cmu-top + - samsung,exynosautov920-cmu-peric0 + + clocks: + minItems: 1 + maxItems: 3 + + clock-names: + minItems: 1 + maxItems: 3 + + "#clock-cells": + const: 1 + + reg: + maxItems: 1 + +allOf: + - if: + properties: + compatible: + contains: + const: samsung,exynosautov920-cmu-top + + then: + properties: + clocks: + items: + - description: External reference clock (38.4 MHz) + + clock-names: + items: + - const: oscclk + + - if: + properties: + compatible: + contains: + const: samsung,exynosautov920-cmu-peric0 + + then: + properties: + clocks: + items: + - description: External reference clock (38.4 MHz) + - description: CMU_PERIC0 NOC clock (from CMU_TOP) + - description: CMU_PERIC0 IP clock (from CMU_TOP) + + clock-names: + items: + - const: oscclk + - const: noc + - const: ip + +required: + - compatible + - "#clock-cells" + - clocks + - clock-names + - reg + +additionalProperties: false + +examples: + # Clock controller node for CMU_PERIC0 + - | + #include <dt-bindings/clock/samsung,exynosautov920.h> + + cmu_peric0: clock-controller@10800000 { + compatible = "samsung,exynosautov920-cmu-peric0"; + reg = <0x10800000 0x8000>; + #clock-cells = <1>; + + clocks = <&xtcxo>, + <&cmu_top DOUT_CLKCMU_PERIC0_NOC>, + <&cmu_top DOUT_CLKCMU_PERIC0_IP>; + clock-names = "oscclk", + "noc", + "ip"; + }; + +... diff --git a/include/dt-bindings/clock/samsung,exynosautov920.h b/include/dt-bindings/clock/samsung,exynosautov920.h new file mode 100644 index 000000000000..ad89728a4396 --- /dev/null +++ b/include/dt-bindings/clock/samsung,exynosautov920.h @@ -0,0 +1,191 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ +/* + * Copyright (c) 2024 Samsung Electronics Co., Ltd. + * Author: Sunyeal Hong <sunyeal.hong@samsung.com> + * + * Device Tree binding constants for ExynosAuto v920 clock controller. + */ + +#ifndef _DT_BINDINGS_CLOCK_EXYNOSAUTOV920_H +#define _DT_BINDINGS_CLOCK_EXYNOSAUTOV920_H + +/* CMU_TOP */ +#define FOUT_SHARED0_PLL 1 +#define FOUT_SHARED1_PLL 2 +#define FOUT_SHARED2_PLL 3 +#define FOUT_SHARED3_PLL 4 +#define FOUT_SHARED4_PLL 5 +#define FOUT_SHARED5_PLL 6 +#define FOUT_MMC_PLL 7 + +/* MUX in CMU_TOP */ +#define MOUT_SHARED0_PLL 101 +#define MOUT_SHARED1_PLL 102 +#define MOUT_SHARED2_PLL 103 +#define MOUT_SHARED3_PLL 104 +#define MOUT_SHARED4_PLL 105 +#define MOUT_SHARED5_PLL 106 +#define MOUT_MMC_PLL 107 +#define MOUT_CLKCMU_CMU_BOOST 108 +#define MOUT_CLKCMU_CMU_CMUREF 109 +#define MOUT_CLKCMU_ACC_NOC 110 +#define MOUT_CLKCMU_ACC_ORB 111 +#define MOUT_CLKCMU_APM_NOC 112 +#define MOUT_CLKCMU_AUD_CPU 113 +#define MOUT_CLKCMU_AUD_NOC 114 +#define MOUT_CLKCMU_CPUCL0_SWITCH 115 +#define MOUT_CLKCMU_CPUCL0_CLUSTER 116 +#define MOUT_CLKCMU_CPUCL0_DBG 117 +#define MOUT_CLKCMU_CPUCL1_SWITCH 118 +#define MOUT_CLKCMU_CPUCL1_CLUSTER 119 +#define MOUT_CLKCMU_CPUCL2_SWITCH 120 +#define MOUT_CLKCMU_CPUCL2_CLUSTER 121 +#define MOUT_CLKCMU_DNC_NOC 122 +#define MOUT_CLKCMU_DPTX_NOC 123 +#define MOUT_CLKCMU_DPTX_DPGTC 124 +#define MOUT_CLKCMU_DPTX_DPOSC 125 +#define MOUT_CLKCMU_DPUB_NOC 126 +#define MOUT_CLKCMU_DPUB_DSIM 127 +#define MOUT_CLKCMU_DPUF0_NOC 128 +#define MOUT_CLKCMU_DPUF1_NOC 129 +#define MOUT_CLKCMU_DPUF2_NOC 130 +#define MOUT_CLKCMU_DSP_NOC 131 +#define MOUT_CLKCMU_G3D_SWITCH 132 +#define MOUT_CLKCMU_G3D_NOCP 133 +#define MOUT_CLKCMU_GNPU_NOC 134 +#define MOUT_CLKCMU_HSI0_NOC 135 +#define MOUT_CLKCMU_HSI1_NOC 136 +#define MOUT_CLKCMU_HSI1_USBDRD 137 +#define MOUT_CLKCMU_HSI1_MMC_CARD 138 +#define MOUT_CLKCMU_HSI2_NOC 139 +#define MOUT_CLKCMU_HSI2_NOC_UFS 140 +#define MOUT_CLKCMU_HSI2_UFS_EMBD 141 +#define MOUT_CLKCMU_HSI2_ETHERNET 142 +#define MOUT_CLKCMU_ISP_NOC 143 +#define MOUT_CLKCMU_M2M_NOC 144 +#define MOUT_CLKCMU_M2M_JPEG 145 +#define MOUT_CLKCMU_MFC_MFC 146 +#define MOUT_CLKCMU_MFC_WFD 147 +#define MOUT_CLKCMU_MFD_NOC 148 +#define MOUT_CLKCMU_MIF_SWITCH 149 +#define MOUT_CLKCMU_MIF_NOCP 150 +#define MOUT_CLKCMU_MISC_NOC 151 +#define MOUT_CLKCMU_NOCL0_NOC 152 +#define MOUT_CLKCMU_NOCL1_NOC 153 +#define MOUT_CLKCMU_NOCL2_NOC 154 +#define MOUT_CLKCMU_PERIC0_NOC 155 +#define MOUT_CLKCMU_PERIC0_IP 156 +#define MOUT_CLKCMU_PERIC1_NOC 157 +#define MOUT_CLKCMU_PERIC1_IP 158 +#define MOUT_CLKCMU_SDMA_NOC 159 +#define MOUT_CLKCMU_SNW_NOC 160 +#define MOUT_CLKCMU_SSP_NOC 161 +#define MOUT_CLKCMU_TAA_NOC 162 + +/* DIV in CMU_TOP */ +#define DOUT_SHARED0_DIV1 201 +#define DOUT_SHARED0_DIV2 202 +#define DOUT_SHARED0_DIV3 203 +#define DOUT_SHARED0_DIV4 204 +#define DOUT_SHARED1_DIV1 205 +#define DOUT_SHARED1_DIV2 206 +#define DOUT_SHARED1_DIV3 207 +#define DOUT_SHARED1_DIV4 208 +#define DOUT_SHARED2_DIV1 209 +#define DOUT_SHARED2_DIV2 210 +#define DOUT_SHARED2_DIV3 211 +#define DOUT_SHARED2_DIV4 212 +#define DOUT_SHARED3_DIV1 213 +#define DOUT_SHARED3_DIV2 214 +#define DOUT_SHARED3_DIV3 215 +#define DOUT_SHARED3_DIV4 216 +#define DOUT_SHARED4_DIV1 217 +#define DOUT_SHARED4_DIV2 218 +#define DOUT_SHARED4_DIV3 219 +#define DOUT_SHARED4_DIV4 220 +#define DOUT_SHARED5_DIV1 221 +#define DOUT_SHARED5_DIV2 222 +#define DOUT_SHARED5_DIV3 223 +#define DOUT_SHARED5_DIV4 224 +#define DOUT_CLKCMU_CMU_BOOST 225 +#define DOUT_CLKCMU_ACC_NOC 226 +#define DOUT_CLKCMU_ACC_ORB 227 +#define DOUT_CLKCMU_APM_NOC 228 +#define DOUT_CLKCMU_AUD_CPU 229 +#define DOUT_CLKCMU_AUD_NOC 230 +#define DOUT_CLKCMU_CPUCL0_SWITCH 231 +#define DOUT_CLKCMU_CPUCL0_CLUSTER 232 +#define DOUT_CLKCMU_CPUCL0_DBG 233 +#define DOUT_CLKCMU_CPUCL1_SWITCH 234 +#define DOUT_CLKCMU_CPUCL1_CLUSTER 235 +#define DOUT_CLKCMU_CPUCL2_SWITCH 236 +#define DOUT_CLKCMU_CPUCL2_CLUSTER 237 +#define DOUT_CLKCMU_DNC_NOC 238 +#define DOUT_CLKCMU_DPTX_NOC 239 +#define DOUT_CLKCMU_DPTX_DPGTC 240 +#define DOUT_CLKCMU_DPTX_DPOSC 241 +#define DOUT_CLKCMU_DPUB_NOC 242 +#define DOUT_CLKCMU_DPUB_DSIM 243 +#define DOUT_CLKCMU_DPUF0_NOC 244 +#define DOUT_CLKCMU_DPUF1_NOC 245 +#define DOUT_CLKCMU_DPUF2_NOC 246 +#define DOUT_CLKCMU_DSP_NOC 247 +#define DOUT_CLKCMU_G3D_SWITCH 248 +#define DOUT_CLKCMU_G3D_NOCP 249 +#define DOUT_CLKCMU_GNPU_NOC 250 +#define DOUT_CLKCMU_HSI0_NOC 251 +#define DOUT_CLKCMU_HSI1_NOC 252 +#define DOUT_CLKCMU_HSI1_USBDRD 253 +#define DOUT_CLKCMU_HSI1_MMC_CARD 254 +#define DOUT_CLKCMU_HSI2_NOC 255 +#define DOUT_CLKCMU_HSI2_NOC_UFS 256 +#define DOUT_CLKCMU_HSI2_UFS_EMBD 257 +#define DOUT_CLKCMU_HSI2_ETHERNET 258 +#define DOUT_CLKCMU_ISP_NOC 259 +#define DOUT_CLKCMU_M2M_NOC 260 +#define DOUT_CLKCMU_M2M_JPEG 261 +#define DOUT_CLKCMU_MFC_MFC 262 +#define DOUT_CLKCMU_MFC_WFD 263 +#define DOUT_CLKCMU_MFD_NOC 264 +#define DOUT_CLKCMU_MIF_NOCP 265 +#define DOUT_CLKCMU_MISC_NOC 266 +#define DOUT_CLKCMU_NOCL0_NOC 267 +#define DOUT_CLKCMU_NOCL1_NOC 268 +#define DOUT_CLKCMU_NOCL2_NOC 269 +#define DOUT_CLKCMU_PERIC0_NOC 270 +#define DOUT_CLKCMU_PERIC0_IP 271 +#define DOUT_CLKCMU_PERIC1_NOC 272 +#define DOUT_CLKCMU_PERIC1_IP 273 +#define DOUT_CLKCMU_SDMA_NOC 274 +#define DOUT_CLKCMU_SNW_NOC 275 +#define DOUT_CLKCMU_SSP_NOC 276 +#define DOUT_CLKCMU_TAA_NOC 277 + +/* CMU_PERIC0 */ +#define CLK_MOUT_PERIC0_IP_USER 1 +#define CLK_MOUT_PERIC0_NOC_USER 2 +#define CLK_MOUT_PERIC0_USI00_USI 3 +#define CLK_MOUT_PERIC0_USI01_USI 4 +#define CLK_MOUT_PERIC0_USI02_USI 5 +#define CLK_MOUT_PERIC0_USI03_USI 6 +#define CLK_MOUT_PERIC0_USI04_USI 7 +#define CLK_MOUT_PERIC0_USI05_USI 8 +#define CLK_MOUT_PERIC0_USI06_USI 9 +#define CLK_MOUT_PERIC0_USI07_USI 10 +#define CLK_MOUT_PERIC0_USI08_USI 11 +#define CLK_MOUT_PERIC0_USI_I2C 12 +#define CLK_MOUT_PERIC0_I3C 13 + +#define CLK_DOUT_PERIC0_USI00_USI 14 +#define CLK_DOUT_PERIC0_USI01_USI 15 +#define CLK_DOUT_PERIC0_USI02_USI 16 +#define CLK_DOUT_PERIC0_USI03_USI 17 +#define CLK_DOUT_PERIC0_USI04_USI 18 +#define CLK_DOUT_PERIC0_USI05_USI 19 +#define CLK_DOUT_PERIC0_USI06_USI 20 +#define CLK_DOUT_PERIC0_USI07_USI 21 +#define CLK_DOUT_PERIC0_USI08_USI 22 +#define CLK_DOUT_PERIC0_USI_I2C 23 +#define CLK_DOUT_PERIC0_I3C 24 + +#endif /* _DT_BINDINGS_CLOCK_EXYNOSAUTOV920_H */
Add dt-schema for ExynosAuto v920 SoC clock controller. Add device tree clock binding definitions for below CMU blocks. - CMU_TOP - CMU_PERIC0 Signed-off-by: Sunyeal Hong <sunyeal.hong@samsung.com> --- .../clock/samsung,exynosautov920-clock.yaml | 115 +++++++++++ .../clock/samsung,exynosautov920.h | 191 ++++++++++++++++++ 2 files changed, 306 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock/samsung,exynosautov920-clock.yaml create mode 100644 include/dt-bindings/clock/samsung,exynosautov920.h