| Message ID | PH7P223MB1039C0F7DAC6FFB32F61DE48F7AB2@PH7P223MB1039.NAMP223.PROD.OUTLOOK.COM (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mm: Capitalize letters for readability | expand |
On Thu, 25 Jul 2024 15:28:29 -0400 Steven Davis <goldside000@outlook.com> wrote: > This patch capitalizes the first letters of error and > debug messages to enhance readability. This is important > for adhering to the style of other error messages in the > kernel, and making it easier and clearer to read the > messages upon the (likely dark) terminal. hm. x1:/usr/src/25> grep " pr_[^(]*.*: [A-Z]" mm/*.c | wc -l 34 x1:/usr/src/25> grep " pr_[^(]*.*: [a-z]" mm/*.c | wc -l 97 If we're going to make this change then we should change everything, add a checkpatch rule, etc. But I do think such a change is too trivial to justify churning the code around.
On Thu, 25 Jul 2024 13:21:24 -0700, Andrew Morton <akpm@linux-foundation.org> wrote: > x1:/usr/src/25> grep " pr_[^(]*.*: [A-Z]" mm/*.c | wc -l > 34 > x1:/usr/src/25> grep " pr_[^(]*.*: [a-z]" mm/*.c | wc -l > 97 Huh. I guess I missed a lot of them. > If we're going to make this change then we should change everything, > add a checkpatch rule, etc. If that approach works, we could do it, I guess. Sounds like a lot of work for capitalization changes. > But I do think such a change is too trivial to justify churning the > code around. So how do we proceed? I could move onto another patch, or, as you said, change everything and add a checkpatch rule. You're the boss. Steven
On Thu, 25 Jul 2024 16:49:51 -0400 Steven Davis <goldside000@outlook.com> wrote: > > But I do think such a change is too trivial to justify churning the > > code around. > > So how do we proceed? I could move onto another patch, or, as you said, > change everything and add a checkpatch rule. Let's not bother with this, unless others feel more strongly than I.
On 25.07.24 23:27, Andrew Morton wrote: > On Thu, 25 Jul 2024 16:49:51 -0400 Steven Davis <goldside000@outlook.com> wrote: > >>> But I do think such a change is too trivial to justify churning the >>> code around. >> >> So how do we proceed? I could move onto another patch, or, as you said, >> change everything and add a checkpatch rule. > > Let's not bother with this, unless others feel more strongly than I. I don't think it's worth the churn. I'll note that "mm: Capitalize letters for readability" is inconsistent with most other MM commits where would have instead "mm: capitalize letters for readability" :P
diff --git a/mm/execmem.c b/mm/execmem.c index 0c4b36bc6d10..ce4334087b1b 100644 --- a/mm/execmem.c +++ b/mm/execmem.c @@ -40,7 +40,7 @@ static void *__execmem_alloc(struct execmem_range *range, size_t size) } if (!p) { - pr_warn_ratelimited("execmem: unable to allocate memory\n"); + pr_warn_ratelimited("execmem: Unable to allocate memory\n"); return NULL; } diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 6b783baf12a1..131b05aef593 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -108,7 +108,7 @@ static int vmap_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end, if (!pte_none(ptep_get(pte))) { if (pfn_valid(pfn)) { page = pfn_to_page(pfn); - dump_page(page, "remapping already mapped page"); + dump_page(page, "Remapping already mapped page"); } BUG(); } diff --git a/mm/zpool.c b/mm/zpool.c index b9fda1fa857d..3c766a1d065b 100644 --- a/mm/zpool.c +++ b/mm/zpool.c @@ -198,7 +198,7 @@ struct zpool *zpool_create_pool(const char *type, const char *name, gfp_t gfp) */ void zpool_destroy_pool(struct zpool *zpool) { - pr_debug("destroying pool type %s\n", zpool->driver->type); + pr_debug("Destroying pool type %s\n", zpool->driver->type); zpool->driver->destroy(zpool->pool); zpool_put_driver(zpool->driver);
This patch capitalizes the first letters of error and debug messages to enhance readability. This is important for adhering to the style of other error messages in the kernel, and making it easier and clearer to read the messages upon the (likely dark) terminal. Signed-off-by: Steven Davis <goldside000@outlook.com> --- mm/execmem.c | 2 +- mm/vmalloc.c | 2 +- mm/zpool.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)