| Message ID | 20240722023913.54788-1-sunjunchao2870@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d1e1ff971d1aafeaedda69136e6974e3a8792cbd |
| Headers | show |
| Series | [f2fs-dev,v2,1/2] f2fs: fix macro definition on_f2fs_build_free_nids | expand |
On 2024/7/22 10:39, Julian Sun wrote: > The macro on_f2fs_build_free_nids accepts a parameter nmi, > but it was not used, rather the variable nm_i was directly used, > which may be a local variable inside a function that calls the macros. > > Signed-off-by: Julian Sun <sunjunchao2870@gmail.com> Reviewed-by: Chao Yu <chao@kernel.org> Thanks,
Hello: This series was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <jaegeuk@kernel.org>: On Sun, 21 Jul 2024 22:39:12 -0400 you wrote: > The macro on_f2fs_build_free_nids accepts a parameter nmi, > but it was not used, rather the variable nm_i was directly used, > which may be a local variable inside a function that calls the macros. > > Signed-off-by: Julian Sun <sunjunchao2870@gmail.com> > --- > fs/f2fs/node.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [f2fs-dev,v2,1/2] f2fs: fix macro definition on_f2fs_build_free_nids https://git.kernel.org/jaegeuk/f2fs/c/d1e1ff971d1a - [f2fs-dev,v2,2/2] f2fs: fix macro definition stat_inc_cp_count https://git.kernel.org/jaegeuk/f2fs/c/d72750e4a752 You are awesome, thank you!
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index b72ef96f7e33..58721a55f173 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -20,7 +20,7 @@ #include "iostat.h" #include <trace/events/f2fs.h> -#define on_f2fs_build_free_nids(nmi) mutex_is_locked(&(nm_i)->build_lock) +#define on_f2fs_build_free_nids(nm_i) mutex_is_locked(&(nm_i)->build_lock) static struct kmem_cache *nat_entry_slab; static struct kmem_cache *free_nid_slab;
The macro on_f2fs_build_free_nids accepts a parameter nmi, but it was not used, rather the variable nm_i was directly used, which may be a local variable inside a function that calls the macros. Signed-off-by: Julian Sun <sunjunchao2870@gmail.com> --- fs/f2fs/node.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)