| Message ID | 20240725-more-qseecom-v1-1-a55a3553d1fe@linaro.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | firmware: qcom: enable qseecom on Lenovo Yoga C630 | expand |
On Thu, Jul 25, 2024 at 02:27:39PM +0300, Dmitry Baryshkov wrote:
> qseecom driver end uefi vars access works on the Lenovo Yoga C630.
Really? Wasn't it the yoga where you could not write variables (you can
try but they don't persist after a reboot)? Perhaps I'm confusing it
with another machine.
Johan
On Thu, 25 Jul 2024 at 14:38, Johan Hovold <johan@kernel.org> wrote: > > On Thu, Jul 25, 2024 at 02:27:39PM +0300, Dmitry Baryshkov wrote: > > qseecom driver end uefi vars access works on the Lenovo Yoga C630. > > Really? Wasn't it the yoga where you could not write variables (you can > try but they don't persist after a reboot)? Perhaps I'm confusing it > with another machine. No, you were right, I checked only the read operations and that write succeeds, but I didn't check that writing persists across the reboot. Either I will fix that, or I will post it as a read-only implementation.
diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c index 00c379a3cceb..9b427bab2028 100644 --- a/drivers/firmware/qcom/qcom_scm.c +++ b/drivers/firmware/qcom/qcom_scm.c @@ -1725,6 +1725,7 @@ EXPORT_SYMBOL_GPL(qcom_scm_qseecom_app_send); static const struct of_device_id qcom_scm_qseecom_allowlist[] __maybe_unused = { { .compatible = "lenovo,flex-5g" }, { .compatible = "lenovo,thinkpad-x13s", }, + { .compatible = "lenovo,yoga-c630", }, { .compatible = "qcom,sc8180x-primus" }, { .compatible = "qcom,x1e80100-crd" }, { .compatible = "qcom,x1e80100-qcp" },
qseecom driver end uefi vars access works on the Lenovo Yoga C630. Enable the QSEECOM device on that laptop. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/firmware/qcom/qcom_scm.c | 1 + 1 file changed, 1 insertion(+) --- base-commit: 864b1099d16fc7e332c3ad7823058c65f890486c change-id: 20240725-more-qseecom-379933b9c769 Best regards,