diff mbox series

[v2] s390/cio: add missing MODULE_DESCRIPTION() macros

Message ID 20240715-md-s390-drivers-s390-cio-v2-1-97eaa6971124@quicinc.com (mailing list archive)
State New, archived
Headers show
Series [v2] s390/cio: add missing MODULE_DESCRIPTION() macros | expand

Commit Message

Jeff Johnson July 15, 2024, 3:58 p.m. UTC
With ARCH=s390, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/cio/ccwgroup.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/cio/vfio_ccw.o

Add the missing invocations of the MODULE_DESCRIPTION() macro.

Reviewed-by: Eric Farman <farman@linux.ibm.com>
Reviewed-by: Vineeth Vijayan <vneethv@linux.ibm.com>
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
I hope this can get into the 6.11 merge window.
I originally had almost 300 patches to fix these issues treewide, and
this is one of only 13 left which have not landed in linux-next
---
Changes in v2:
- changed CCW Group to ccwgroup in ccwgroup.c description
- removed "Physical" in vfio_ccw_drv.c description
- applied Reviewed-by tags from Eric Farman & Vineeth Vijayan since these edits
  seem to be aligned with their comments
- Link to v1: https://lore.kernel.org/r/20240615-md-s390-drivers-s390-cio-v1-1-8fc9584e8595@quicinc.com
---
 drivers/s390/cio/ccwgroup.c     | 1 +
 drivers/s390/cio/vfio_ccw_drv.c | 1 +
 2 files changed, 2 insertions(+)


---
base-commit: 0c3836482481200ead7b416ca80c68a29cfdaabd
change-id: 20240615-md-s390-drivers-s390-cio-3598abb802ad

Comments

Vasily Gorbik July 26, 2024, 11:14 a.m. UTC | #1
On Mon, Jul 15, 2024 at 08:58:51AM -0700, Jeff Johnson wrote:
> With ARCH=s390, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/cio/ccwgroup.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/cio/vfio_ccw.o
> 
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
> 
> Reviewed-by: Eric Farman <farman@linux.ibm.com>
> Reviewed-by: Vineeth Vijayan <vneethv@linux.ibm.com>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> I hope this can get into the 6.11 merge window.
> I originally had almost 300 patches to fix these issues treewide, and
> this is one of only 13 left which have not landed in linux-next
> ---
> Changes in v2:
> - changed CCW Group to ccwgroup in ccwgroup.c description
> - removed "Physical" in vfio_ccw_drv.c description
> - applied Reviewed-by tags from Eric Farman & Vineeth Vijayan since these edits
>   seem to be aligned with their comments
> - Link to v1: https://lore.kernel.org/r/20240615-md-s390-drivers-s390-cio-v1-1-8fc9584e8595@quicinc.com
> ---
>  drivers/s390/cio/ccwgroup.c     | 1 +
>  drivers/s390/cio/vfio_ccw_drv.c | 1 +
>  2 files changed, 2 insertions(+)
 
Applied, thank you!
diff mbox series

Patch

diff --git a/drivers/s390/cio/ccwgroup.c b/drivers/s390/cio/ccwgroup.c
index b72f672a7720..66b1bdc63284 100644
--- a/drivers/s390/cio/ccwgroup.c
+++ b/drivers/s390/cio/ccwgroup.c
@@ -550,4 +550,5 @@  void ccwgroup_remove_ccwdev(struct ccw_device *cdev)
 	put_device(&gdev->dev);
 }
 EXPORT_SYMBOL(ccwgroup_remove_ccwdev);
+MODULE_DESCRIPTION("ccwgroup bus driver");
 MODULE_LICENSE("GPL");
diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_drv.c
index 8ad49030a7bf..914dde041675 100644
--- a/drivers/s390/cio/vfio_ccw_drv.c
+++ b/drivers/s390/cio/vfio_ccw_drv.c
@@ -488,4 +488,5 @@  static void __exit vfio_ccw_sch_exit(void)
 module_init(vfio_ccw_sch_init);
 module_exit(vfio_ccw_sch_exit);
 
+MODULE_DESCRIPTION("VFIO based Subchannel device driver");
 MODULE_LICENSE("GPL v2");