| Message ID | 20240729081039.3904797-1-xu.yang_2@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] dt-bindings: usb: gpio-sbu-mux: Add an entry for PTN36043 | expand |
On 29/07/2024 10:10, Xu Yang wrote: > Add a compatible entry for the NXP PTN36043 GPIO-based mux hardware > used for connecting, disconnecting and switching orientation of > the SBU lines in USB Type-C applications. > > PTN36043 datasheet: https://www.nxp.com/docs/en/data-sheet/PTN36043A.pdf > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > --- Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Mon, 29 Jul 2024 16:10:37 +0800, Xu Yang wrote: > Add a compatible entry for the NXP PTN36043 GPIO-based mux hardware > used for connecting, disconnecting and switching orientation of > the SBU lines in USB Type-C applications. > > PTN36043 datasheet: https://www.nxp.com/docs/en/data-sheet/PTN36043A.pdf > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > --- > Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 1 + > 1 file changed, 1 insertion(+) > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y freescale/imx8mp-evk.dtb freescale/imx8mq-evk.dtb' for 20240729081039.3904797-1-xu.yang_2@nxp.com: arch/arm64/boot/dts/freescale/imx8mq-evk.dtb: usb@38100000: role-switch-default-mode:0: 'none' is not one of ['host', 'peripheral'] from schema $id: http://devicetree.org/schemas/usb/snps,dwc3.yaml# arch/arm64/boot/dts/freescale/imx8mq-evk.dtb: usb@38100000: Unevaluated properties are not allowed ('adp-disable', 'dr_mode', 'hnp-disable', 'role-switch-default-mode', 'srp-disable', 'usb-role-switch' were unexpected) from schema $id: http://devicetree.org/schemas/usb/snps,dwc3.yaml# arch/arm64/boot/dts/freescale/imx8mq-evk.dtb: usb@38100000: role-switch-default-mode:0: 'none' is not one of ['host', 'peripheral'] from schema $id: http://devicetree.org/schemas/usb/fsl,imx8mq-dwc3.yaml# arch/arm64/boot/dts/freescale/imx8mq-evk.dtb: usb@38100000: Unevaluated properties are not allowed ('adp-disable', 'dr_mode', 'hnp-disable', 'role-switch-default-mode', 'srp-disable', 'usb-role-switch' were unexpected) from schema $id: http://devicetree.org/schemas/usb/fsl,imx8mq-dwc3.yaml# arch/arm64/boot/dts/freescale/imx8mq-evk.dtb: usb@38100000: Unevaluated properties are not allowed ('adp-disable', 'assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks', 'dr_mode', 'hnp-disable', 'interrupts', 'phy-names', 'phys', 'port', 'power-domains', 'reg', 'role-switch-default-mode', 'snps,dis-u1-entry-quirk', 'snps,dis-u2-entry-quirk', 'snps,parkmode-disable-ss-quirk', 'srp-disable', 'usb-role-switch' were unexpected) from schema $id: http://devicetree.org/schemas/usb/fsl,imx8mq-dwc3.yaml# arch/arm64/boot/dts/freescale/imx8mp-evk.dtb: usb-phy@381f0040: 'fsl,pcs-tx-deemph-3p5db', 'fsl,phy-comp-dis-tune', 'fsl,phy-pcs-tx-swing-full', 'fsl,phy-tx-preemp-amp-tune', 'fsl,phy-tx-vboost-level', 'fsl,phy-tx-vref-tune' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/phy/fsl,imx8mq-usb-phy.yaml# arch/arm64/boot/dts/freescale/imx8mp-evk.dtb: usb@32f10100: usb@38100000:role-switch-default-mode:0: 'none' is not one of ['host', 'peripheral'] from schema $id: http://devicetree.org/schemas/usb/fsl,imx8mp-dwc3.yaml# arch/arm64/boot/dts/freescale/imx8mp-evk.dtb: usb@32f10100: usb@38100000: Unevaluated properties are not allowed ('adp-disable', 'dr_mode', 'hnp-disable', 'role-switch-default-mode', 'srp-disable', 'usb-role-switch' were unexpected) from schema $id: http://devicetree.org/schemas/usb/fsl,imx8mp-dwc3.yaml# arch/arm64/boot/dts/freescale/imx8mp-evk.dtb: usb@38100000: role-switch-default-mode:0: 'none' is not one of ['host', 'peripheral'] from schema $id: http://devicetree.org/schemas/usb/snps,dwc3.yaml# arch/arm64/boot/dts/freescale/imx8mp-evk.dtb: usb@38100000: Unevaluated properties are not allowed ('adp-disable', 'dr_mode', 'hnp-disable', 'role-switch-default-mode', 'srp-disable', 'usb-role-switch' were unexpected) from schema $id: http://devicetree.org/schemas/usb/snps,dwc3.yaml# arch/arm64/boot/dts/freescale/imx8mp-evk.dtb: usb-phy@382f0040: 'fsl,phy-tx-preemp-amp-tune', 'fsl,phy-tx-vref-tune' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/phy/fsl,imx8mq-usb-phy.yaml#
On Mon, Jul 29, 2024 at 04:10:37PM GMT, Xu Yang wrote: > Add a compatible entry for the NXP PTN36043 GPIO-based mux hardware > used for connecting, disconnecting and switching orientation of > the SBU lines in USB Type-C applications. NAK, this is not correct. PTN36043 switchies SuperSpeed lines and not SBU. > > PTN36043 datasheet: https://www.nxp.com/docs/en/data-sheet/PTN36043A.pdf > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > --- > Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml > index 8a5f837eff94..152849f744c1 100644 > --- a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml > +++ b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml > @@ -20,6 +20,7 @@ properties: > items: > - enum: > - nxp,cbdtu02043 > + - nxp,ptn36043 > - onnn,fsusb43l10x > - pericom,pi3usb102 > - ti,tmuxhs4212 > -- > 2.34.1 >
On Mon, Jul 29, 2024 at 12:52:56PM -0600, Rob Herring (Arm) wrote: > > On Mon, 29 Jul 2024 16:10:37 +0800, Xu Yang wrote: > > Add a compatible entry for the NXP PTN36043 GPIO-based mux hardware > > used for connecting, disconnecting and switching orientation of > > the SBU lines in USB Type-C applications. > > > > PTN36043 datasheet: https://www.nxp.com/docs/en/data-sheet/PTN36043A.pdf > > > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > > --- > > Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > > My bot found new DTB warnings on the .dts files added or changed in this > series. > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > New warnings running 'make CHECK_DTBS=y freescale/imx8mp-evk.dtb freescale/imx8mq-evk.dtb' for 20240729081039.3904797-1-xu.yang_2@nxp.com: > > arch/arm64/boot/dts/freescale/imx8mq-evk.dtb: usb@38100000: role-switch-default-mode:0: 'none' is not one of ['host', 'peripheral'] > from schema $id: http://devicetree.org/schemas/usb/snps,dwc3.yaml# > arch/arm64/boot/dts/freescale/imx8mq-evk.dtb: usb@38100000: Unevaluated properties are not allowed ('adp-disable', 'dr_mode', 'hnp-disable', 'role-switch-default-mode', 'srp-disable', 'usb-role-switch' were unexpected) > from schema $id: http://devicetree.org/schemas/usb/snps,dwc3.yaml# > arch/arm64/boot/dts/freescale/imx8mq-evk.dtb: usb@38100000: role-switch-default-mode:0: 'none' is not one of ['host', 'peripheral'] > from schema $id: http://devicetree.org/schemas/usb/fsl,imx8mq-dwc3.yaml# > arch/arm64/boot/dts/freescale/imx8mq-evk.dtb: usb@38100000: Unevaluated properties are not allowed ('adp-disable', 'dr_mode', 'hnp-disable', 'role-switch-default-mode', 'srp-disable', 'usb-role-switch' were unexpected) > from schema $id: http://devicetree.org/schemas/usb/fsl,imx8mq-dwc3.yaml# > arch/arm64/boot/dts/freescale/imx8mq-evk.dtb: usb@38100000: Unevaluated properties are not allowed ('adp-disable', 'assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks', 'dr_mode', 'hnp-disable', 'interrupts', 'phy-names', 'phys', 'port', 'power-domains', 'reg', 'role-switch-default-mode', 'snps,dis-u1-entry-quirk', 'snps,dis-u2-entry-quirk', 'snps,parkmode-disable-ss-quirk', 'srp-disable', 'usb-role-switch' were unexpected) > from schema $id: http://devicetree.org/schemas/usb/fsl,imx8mq-dwc3.yaml# > arch/arm64/boot/dts/freescale/imx8mp-evk.dtb: usb-phy@381f0040: 'fsl,pcs-tx-deemph-3p5db', 'fsl,phy-comp-dis-tune', 'fsl,phy-pcs-tx-swing-full', 'fsl,phy-tx-preemp-amp-tune', 'fsl,phy-tx-vboost-level', 'fsl,phy-tx-vref-tune' do not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/phy/fsl,imx8mq-usb-phy.yaml# > arch/arm64/boot/dts/freescale/imx8mp-evk.dtb: usb@32f10100: usb@38100000:role-switch-default-mode:0: 'none' is not one of ['host', 'peripheral'] > from schema $id: http://devicetree.org/schemas/usb/fsl,imx8mp-dwc3.yaml# > arch/arm64/boot/dts/freescale/imx8mp-evk.dtb: usb@32f10100: usb@38100000: Unevaluated properties are not allowed ('adp-disable', 'dr_mode', 'hnp-disable', 'role-switch-default-mode', 'srp-disable', 'usb-role-switch' were unexpected) > from schema $id: http://devicetree.org/schemas/usb/fsl,imx8mp-dwc3.yaml# > arch/arm64/boot/dts/freescale/imx8mp-evk.dtb: usb@38100000: role-switch-default-mode:0: 'none' is not one of ['host', 'peripheral'] > from schema $id: http://devicetree.org/schemas/usb/snps,dwc3.yaml# > arch/arm64/boot/dts/freescale/imx8mp-evk.dtb: usb@38100000: Unevaluated properties are not allowed ('adp-disable', 'dr_mode', 'hnp-disable', 'role-switch-default-mode', 'srp-disable', 'usb-role-switch' were unexpected) > from schema $id: http://devicetree.org/schemas/usb/snps,dwc3.yaml# > arch/arm64/boot/dts/freescale/imx8mp-evk.dtb: usb-phy@382f0040: 'fsl,phy-tx-preemp-amp-tune', 'fsl,phy-tx-vref-tune' do not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/phy/fsl,imx8mq-usb-phy.yaml# Sorry for this. I've checked gpio-sbu-mux and ptn5110 binding but missed usb part. Will fix it. Thanks, Xu Yang > > > > >
On Mon, Jul 29, 2024 at 10:57:33PM +0300, Dmitry Baryshkov wrote: > On Mon, Jul 29, 2024 at 04:10:37PM GMT, Xu Yang wrote: > > Add a compatible entry for the NXP PTN36043 GPIO-based mux hardware > > used for connecting, disconnecting and switching orientation of > > the SBU lines in USB Type-C applications. > > NAK, this is not correct. PTN36043 switchies SuperSpeed lines and not > SBU. Yes. Since this gpio mux is able to switch both sbu line and ss line, I will change SBU to SuperSpeed in next version in commit message to avoid confusion. Thanks, Xu Yang > > > > > PTN36043 datasheet: https://www.nxp.com/docs/en/data-sheet/PTN36043A.pdf > > > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > > --- > > Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml > > index 8a5f837eff94..152849f744c1 100644 > > --- a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml > > +++ b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml > > @@ -20,6 +20,7 @@ properties: > > items: > > - enum: > > - nxp,cbdtu02043 > > + - nxp,ptn36043 > > - onnn,fsusb43l10x > > - pericom,pi3usb102 > > - ti,tmuxhs4212 > > -- > > 2.34.1 > > > > -- > With best wishes > Dmitry
On Tue, Jul 30, 2024 at 10:58:44AM GMT, Xu Yang wrote: > On Mon, Jul 29, 2024 at 10:57:33PM +0300, Dmitry Baryshkov wrote: > > On Mon, Jul 29, 2024 at 04:10:37PM GMT, Xu Yang wrote: > > > Add a compatible entry for the NXP PTN36043 GPIO-based mux hardware > > > used for connecting, disconnecting and switching orientation of > > > the SBU lines in USB Type-C applications. > > > > NAK, this is not correct. PTN36043 switchies SuperSpeed lines and not > > SBU. > > Yes. Since this gpio mux is able to switch both sbu line and ss line, > I will change SBU to SuperSpeed in next version in commit message to avoid > confusion. Ack. This needs new compatible and probably more schema (and driver) changes. I think you can't just terminate SS lanes in the mux, they should go to the actual SoC part (like the SS controller or PHY). > > Thanks, > Xu Yang > > > > > > > > > PTN36043 datasheet: https://www.nxp.com/docs/en/data-sheet/PTN36043A.pdf > > > > > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > > > --- > > > Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml > > > index 8a5f837eff94..152849f744c1 100644 > > > --- a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml > > > +++ b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml > > > @@ -20,6 +20,7 @@ properties: > > > items: > > > - enum: > > > - nxp,cbdtu02043 > > > + - nxp,ptn36043 > > > - onnn,fsusb43l10x > > > - pericom,pi3usb102 > > > - ti,tmuxhs4212 > > > -- > > > 2.34.1 > > > > > > > -- > > With best wishes > > Dmitry
On Tue, Jul 30, 2024 at 02:12:32PM +0300, Dmitry Baryshkov wrote: > On Tue, Jul 30, 2024 at 10:58:44AM GMT, Xu Yang wrote: > > On Mon, Jul 29, 2024 at 10:57:33PM +0300, Dmitry Baryshkov wrote: > > > On Mon, Jul 29, 2024 at 04:10:37PM GMT, Xu Yang wrote: > > > > Add a compatible entry for the NXP PTN36043 GPIO-based mux hardware > > > > used for connecting, disconnecting and switching orientation of > > > > the SBU lines in USB Type-C applications. > > > > > > NAK, this is not correct. PTN36043 switchies SuperSpeed lines and not > > > SBU. > > > > Yes. Since this gpio mux is able to switch both sbu line and ss line, > > I will change SBU to SuperSpeed in next version in commit message to avoid > > confusion. > > Ack. This needs new compatible and probably more schema (and driver) > changes. I think you can't just terminate SS lanes in the mux, they > should go to the actual SoC part (like the SS controller or PHY). Thanks for your remainder. The SS signals already go to i.MX8MP soc (USB PHY) on my board. Thanks, Xu Yang > > > > > Thanks, > > Xu Yang > > > > > > > > > > > > > PTN36043 datasheet: https://www.nxp.com/docs/en/data-sheet/PTN36043A.pdf > > > > > > > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > > > > --- > > > > Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml > > > > index 8a5f837eff94..152849f744c1 100644 > > > > --- a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml > > > > +++ b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml > > > > @@ -20,6 +20,7 @@ properties: > > > > items: > > > > - enum: > > > > - nxp,cbdtu02043 > > > > + - nxp,ptn36043 > > > > - onnn,fsusb43l10x > > > > - pericom,pi3usb102 > > > > - ti,tmuxhs4212 > > > > -- > > > > 2.34.1 > > > > > > > > > > -- > > > With best wishes > > > Dmitry > > -- > With best wishes > Dmitry
diff --git a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml index 8a5f837eff94..152849f744c1 100644 --- a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml +++ b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml @@ -20,6 +20,7 @@ properties: items: - enum: - nxp,cbdtu02043 + - nxp,ptn36043 - onnn,fsusb43l10x - pericom,pi3usb102 - ti,tmuxhs4212
Add a compatible entry for the NXP PTN36043 GPIO-based mux hardware used for connecting, disconnecting and switching orientation of the SBU lines in USB Type-C applications. PTN36043 datasheet: https://www.nxp.com/docs/en/data-sheet/PTN36043A.pdf Signed-off-by: Xu Yang <xu.yang_2@nxp.com> --- Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 1 + 1 file changed, 1 insertion(+)