diff mbox series

[v6,17/27] irqchip/atmel-aic5: Add support for sam9x7 aic

Message ID 20240729070829.1991064-1-varshini.rajendran@microchip.com (mailing list archive)
State New, archived
Headers show
Series Add support for sam9x7 SoC family | expand

Commit Message

Varshini Rajendran July 29, 2024, 7:08 a.m. UTC 
From: Hari Prasath <Hari.PrasathGE@microchip.com>

Add support for the Advanced interrupt controller(AIC) chip in the sam9x7.

Signed-off-by: Hari Prasath <Hari.PrasathGE@microchip.com>
Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
---
Changes in v6:

 - Reverted back to the patch in version 3 considering the complexity
   involving in using DT match data.
---
 drivers/irqchip/irq-atmel-aic5.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Thomas Gleixner July 29, 2024, 10:16 a.m. UTC | #1 
On Mon, Jul 29 2024 at 12:38, Varshini Rajendran wrote:
> +
> +#define NR_SAM9X7_IRQS		70
> +
> +static int __init sam9x7_aic5_of_init(struct device_node *node,
> +				      struct device_node *parent)

Please get rid of the pointless line break.

Thanks,

        tglx
Varshini Rajendran July 29, 2024, 10:24 a.m. UTC | #2 
Hi Thomas,

On 29/07/24 3:46 pm, Thomas Gleixner wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Mon, Jul 29 2024 at 12:38, Varshini Rajendran wrote:
>> +
>> +#define NR_SAM9X7_IRQS               70
>> +
>> +static int __init sam9x7_aic5_of_init(struct device_node *node,
>> +                                   struct device_node *parent)
> 
> Please get rid of the pointless line break.
> 

Is it okay if the line exceeds 80 chars then ?

> Thanks,
> 
>          tglx
diff mbox series

Patch

diff --git a/drivers/irqchip/irq-atmel-aic5.c b/drivers/irqchip/irq-atmel-aic5.c
index 145535bd7560..bab11900f3ef 100644
--- a/drivers/irqchip/irq-atmel-aic5.c
+++ b/drivers/irqchip/irq-atmel-aic5.c
@@ -320,6 +320,7 @@  static const struct of_device_id aic5_irq_fixups[] __initconst = {
 	{ .compatible = "atmel,sama5d3", .data = sama5d3_aic_irq_fixup },
 	{ .compatible = "atmel,sama5d4", .data = sama5d3_aic_irq_fixup },
 	{ .compatible = "microchip,sam9x60", .data = sam9x60_aic_irq_fixup },
+	{ .compatible = "microchip,sam9x7", .data = sam9x60_aic_irq_fixup },
 	{ /* sentinel */ },
 };
 
@@ -406,3 +407,12 @@  static int __init sam9x60_aic5_of_init(struct device_node *node,
 	return aic5_of_init(node, parent, NR_SAM9X60_IRQS);
 }
 IRQCHIP_DECLARE(sam9x60_aic5, "microchip,sam9x60-aic", sam9x60_aic5_of_init);
+
+#define NR_SAM9X7_IRQS		70
+
+static int __init sam9x7_aic5_of_init(struct device_node *node,
+				      struct device_node *parent)
+{
+	return aic5_of_init(node, parent, NR_SAM9X7_IRQS);
+}
+IRQCHIP_DECLARE(sam9x7_aic5, "microchip,sam9x7-aic", sam9x7_aic5_of_init);