| Message ID | b0880888-6719-4614-91fc-8ee63b71d304@stanley.mountain (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3c526089a663e25ac78b6a61d84a52a83680d0c3 |
| Headers | show |
| Series | usb: typec: tcpci: Fix error code in tcpci_check_std_output_cap() | expand |
Hi, On 24-07-12, Dan Carpenter wrote: > The tcpci_check_std_output_cap() function is supposed to return negative > error codes but it's declared as type bool so the error handling doesn't > work. Declare it as an int instead. sorry I missed this :/ in the first place, thank you for the fix. > Fixes: 62ce9ef14797 ("usb: typec: tcpci: add support to set connector orientation") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
On Fri, Jul 12, 2024 at 09:05:50AM -0500, Dan Carpenter wrote: > The tcpci_check_std_output_cap() function is supposed to return negative > error codes but it's declared as type bool so the error handling doesn't > work. Declare it as an int instead. > > Fixes: 62ce9ef14797 ("usb: typec: tcpci: add support to set connector orientation") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/tcpm/tcpci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/tcpm/tcpci.c b/drivers/usb/typec/tcpm/tcpci.c > index 8a18d561b063..b5e49af48f43 100644 > --- a/drivers/usb/typec/tcpm/tcpci.c > +++ b/drivers/usb/typec/tcpm/tcpci.c > @@ -67,7 +67,7 @@ static int tcpci_write16(struct tcpci *tcpci, unsigned int reg, u16 val) > return regmap_raw_write(tcpci->regmap, reg, &val, sizeof(u16)); > } > > -static bool tcpci_check_std_output_cap(struct regmap *regmap, u8 mask) > +static int tcpci_check_std_output_cap(struct regmap *regmap, u8 mask) > { > unsigned int reg; > int ret; > -- > 2.43.0
diff --git a/drivers/usb/typec/tcpm/tcpci.c b/drivers/usb/typec/tcpm/tcpci.c index 8a18d561b063..b5e49af48f43 100644 --- a/drivers/usb/typec/tcpm/tcpci.c +++ b/drivers/usb/typec/tcpm/tcpci.c @@ -67,7 +67,7 @@ static int tcpci_write16(struct tcpci *tcpci, unsigned int reg, u16 val) return regmap_raw_write(tcpci->regmap, reg, &val, sizeof(u16)); } -static bool tcpci_check_std_output_cap(struct regmap *regmap, u8 mask) +static int tcpci_check_std_output_cap(struct regmap *regmap, u8 mask) { unsigned int reg; int ret;
The tcpci_check_std_output_cap() function is supposed to return negative error codes but it's declared as type bool so the error handling doesn't work. Declare it as an int instead. Fixes: 62ce9ef14797 ("usb: typec: tcpci: add support to set connector orientation") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/usb/typec/tcpm/tcpci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)