| Message ID | 20240724162356.992763-2-harshit.m.mogalapalli@oracle.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b1dad2f091382b0049c72dab8153779248fa8016 |
| Headers | show |
| Series | [1/2] usb: typec: tipd: Fix dereferencing freeing memory in tps6598x_apply_patch() | expand |
On 24/07/2024 18:23, Harshit Mogalapalli wrote: > There shouldn't be a ; at the end of the function, delete it. > > Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> > --- > drivers/usb/typec/tipd/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c > index eb5596e3406a..dd51a25480bf 100644 > --- a/drivers/usb/typec/tipd/core.c > +++ b/drivers/usb/typec/tipd/core.c > @@ -1198,7 +1198,7 @@ static int tps6598x_apply_patch(struct tps6598x *tps) > release_firmware(fw); > > return ret; > -}; > +} > > static int cd321x_init(struct tps6598x *tps) > { Reviewed-by: Javier Carrasco <javier.carrasco@wolfvision.net>
On Wed, Jul 24, 2024 at 09:23:51AM -0700, Harshit Mogalapalli wrote: > There shouldn't be a ; at the end of the function, delete it. > > Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/tipd/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c > index eb5596e3406a..dd51a25480bf 100644 > --- a/drivers/usb/typec/tipd/core.c > +++ b/drivers/usb/typec/tipd/core.c > @@ -1198,7 +1198,7 @@ static int tps6598x_apply_patch(struct tps6598x *tps) > release_firmware(fw); > > return ret; > -}; > +} > > static int cd321x_init(struct tps6598x *tps) > { > -- > 2.45.2
diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c index eb5596e3406a..dd51a25480bf 100644 --- a/drivers/usb/typec/tipd/core.c +++ b/drivers/usb/typec/tipd/core.c @@ -1198,7 +1198,7 @@ static int tps6598x_apply_patch(struct tps6598x *tps) release_firmware(fw); return ret; -}; +} static int cd321x_init(struct tps6598x *tps) {
There shouldn't be a ; at the end of the function, delete it. Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> --- drivers/usb/typec/tipd/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)