| Message ID | 20240730143324.114146-2-j-mcarthur@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: ti: k3-am62p/j722s: Fix gpio-ranges | expand |
On 09:33-20240730, Jared McArthur wrote: > Commit d72d73a44c3c ("arm64: dts: ti: k3-am62p: Add gpio-ranges > properties") introduced pinmux range definition for gpio-ranges, > however missed introducing the range description for the mcu_gpio0 > node. As a result, automatic mapping of GPIO to pin control for mcu > gpios is broken. Fix this by introducing the proper ranges. > > Fixes: d72d73a44c3c ("arm64: dts: ti: k3-am62p: Add gpio-ranges properties") > Signed-off-by: Jared McArthur <j-mcarthur@ti.com> > --- > arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi > index e65db6ce02bf..c0bdbd00dc23 100644 > --- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi > @@ -146,6 +146,9 @@ mcu_gpio0: gpio@4201000 { > power-domains = <&k3_pds 79 TI_SCI_PD_EXCLUSIVE>; > clocks = <&k3_clks 79 0>; > clock-names = "gpio"; > + gpio-ranges = <&mcu_pmx0 0 0 21>, <&mcu_pmx0 21 23 1>, > + <&mcu_pmx0 22 32 2>; > + ti,ngpio = <24>; we already have ti,ngpio - please drop > }; > > mcu_rti0: watchdog@4880000 { > -- > 2.34.1 >
On 7/30/24 09:59, Nishanth Menon wrote: > On 09:33-20240730, Jared McArthur wrote: >> Commit d72d73a44c3c ("arm64: dts: ti: k3-am62p: Add gpio-ranges >> properties") introduced pinmux range definition for gpio-ranges, >> however missed introducing the range description for the mcu_gpio0 >> node. As a result, automatic mapping of GPIO to pin control for mcu >> gpios is broken. Fix this by introducing the proper ranges. >> >> Fixes: d72d73a44c3c ("arm64: dts: ti: k3-am62p: Add gpio-ranges properties") >> Signed-off-by: Jared McArthur <j-mcarthur@ti.com> >> --- >> arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi >> index e65db6ce02bf..c0bdbd00dc23 100644 >> --- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi >> @@ -146,6 +146,9 @@ mcu_gpio0: gpio@4201000 { >> power-domains = <&k3_pds 79 TI_SCI_PD_EXCLUSIVE>; >> clocks = <&k3_clks 79 0>; >> clock-names = "gpio"; >> + gpio-ranges = <&mcu_pmx0 0 0 21>, <&mcu_pmx0 21 23 1>, >> + <&mcu_pmx0 22 32 2>; >> + ti,ngpio = <24>; > we already have ti,ngpio - please drop Sorry, missed that. I will fix it and resend the patch. >> }; >> >> mcu_rti0: watchdog@4880000 { >> -- >> 2.34.1 >>
diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi index e65db6ce02bf..c0bdbd00dc23 100644 --- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi @@ -146,6 +146,9 @@ mcu_gpio0: gpio@4201000 { power-domains = <&k3_pds 79 TI_SCI_PD_EXCLUSIVE>; clocks = <&k3_clks 79 0>; clock-names = "gpio"; + gpio-ranges = <&mcu_pmx0 0 0 21>, <&mcu_pmx0 21 23 1>, + <&mcu_pmx0 22 32 2>; + ti,ngpio = <24>; }; mcu_rti0: watchdog@4880000 {
Commit d72d73a44c3c ("arm64: dts: ti: k3-am62p: Add gpio-ranges properties") introduced pinmux range definition for gpio-ranges, however missed introducing the range description for the mcu_gpio0 node. As a result, automatic mapping of GPIO to pin control for mcu gpios is broken. Fix this by introducing the proper ranges. Fixes: d72d73a44c3c ("arm64: dts: ti: k3-am62p: Add gpio-ranges properties") Signed-off-by: Jared McArthur <j-mcarthur@ti.com> --- arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi | 3 +++ 1 file changed, 3 insertions(+)