| Message ID | 20240731071950.989113-1-alexander.stein@ew.tq-group.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 16d731890db94e23d5483402494ef378f2271ba1 |
| Headers | show |
| Series | [1/1] dt-bindings: usb: microchip,usb2514: Add USB2517 compatible | expand |
Am Mittwoch, 31. Juli 2024, 09:19:50 CEST schrieb Alexander Stein: > USB2517 is a 7-port variant of this USB hub. Add an USB compatible > based on USB vendor & product ID. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > Documentation/devicetree/bindings/usb/microchip,usb2514.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml > index 783c27591e564..245e8c3ce6699 100644 > --- a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml > +++ b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml > @@ -18,6 +18,7 @@ properties: > - usb424,2412 > - usb424,2417 > - usb424,2514 > + - usb424,2517 > > reg: true > > One question unrelated to this change but regarding this binding: Why is this referring usb-hcd.yaml and not usb-device.yaml? This USB hub is not a host controller but a USB device. Best regards, Alexander
On 31/07/2024 09:19, Alexander Stein wrote: > USB2517 is a 7-port variant of this USB hub. Add an USB compatible > based on USB vendor & product ID. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 31/07/2024 09:27, Krzysztof Kozlowski wrote: > On 31/07/2024 09:19, Alexander Stein wrote: >> USB2517 is a 7-port variant of this USB hub. Add an USB compatible >> based on USB vendor & product ID. >> >> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Of course assuming there is some user? If so, where? Best regards, Krzysztof
Am Mittwoch, 31. Juli 2024, 09:32:43 CEST schrieb Krzysztof Kozlowski: > On 31/07/2024 09:27, Krzysztof Kozlowski wrote: > > On 31/07/2024 09:19, Alexander Stein wrote: > >> USB2517 is a 7-port variant of this USB hub. Add an USB compatible > >> based on USB vendor & product ID. > >> > >> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Of course assuming there is some user? If so, where? There is: arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dts introduced by commit ba9943f47dca1 ("arm64: dts: mba93xxla: Add USB support") Best regards, Alexander
On 31/07/2024 09:34, Alexander Stein wrote: > Am Mittwoch, 31. Juli 2024, 09:32:43 CEST schrieb Krzysztof Kozlowski: >> On 31/07/2024 09:27, Krzysztof Kozlowski wrote: >>> On 31/07/2024 09:19, Alexander Stein wrote: >>>> USB2517 is a 7-port variant of this USB hub. Add an USB compatible >>>> based on USB vendor & product ID. >>>> >>>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> >>> >>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> Of course assuming there is some user? If so, where? > > There is: arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dts > introduced by commit ba9943f47dca1 ("arm64: dts: mba93xxla: Add USB support") Bindings 1.5 years after you added compatible... checkpatch told you that you miss bindings that time. This should be explained in commit msg - you add compatible for a compatible already present in the kernel. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml index 783c27591e564..245e8c3ce6699 100644 --- a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml +++ b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml @@ -18,6 +18,7 @@ properties: - usb424,2412 - usb424,2417 - usb424,2514 + - usb424,2517 reg: true
USB2517 is a 7-port variant of this USB hub. Add an USB compatible based on USB vendor & product ID. Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- Documentation/devicetree/bindings/usb/microchip,usb2514.yaml | 1 + 1 file changed, 1 insertion(+)